Received-SPF: pass (google.com: domain of linux-kernel+bounces-84410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d7611a8f-c266-4545-b0d9-a5e6ef3abf0e@linux.dev>
Date: Wed, 28 Feb 2024 10:17:02 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] mm/zsmalloc: don't need to save tag bit in handle
Content-Language: en-US
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: minchan@kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org,
 nphamcs@gmail.com, yosryahmed@google.com, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Chengming Zhou <zhouchengming@bytedance.com>
References: <20240227030045.3443702-1-chengming.zhou@linux.dev>
 <20240227075209.GA11972@google.com>
 <b54646e3-44bd-4937-a2dd-4b88ca7ab672@linux.dev>
 <20240228015437.GB11972@google.com>
From: Chengming Zhou <chengming.zhou@linux.dev>
In-Reply-To: <20240228015437.GB11972@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2024/2/28 09:54, Sergey Senozhatsky wrote:
> On (24/02/27 16:16), Chengming Zhou wrote:
>> On 2024/2/27 15:52, Sergey Senozhatsky wrote:
>>> On (24/02/27 03:00), chengming.zhou@linux.dev wrote:
>>>>
>>>> We only need to save the position (pfn + obj_idx) in the handle, don't
>>>> need to save tag bit in handle. So one more bit can be used as obj_idx.
>>>
>>> [..]
>>>
>>>> mm/zsmalloc: don't need to save tag bit in handle
>>>
>>> Does this mean "don't need to reserve LSB for tag"?
>> The head of object still need to reverve LSB, to save (handle | OBJ_ALLOCATED_TAG),
>> only the handle doesn't need to reserve LSB, which save (pfn | obj_idx).
> 
> Correct.
> 
>>> We still save allocated tag in the handle, that's what
>>>
>>> 	handle |= OBJ_ALLOCATED_TAG;
>>
>> Yes, this result will be saved in the head of each allocated object.
> 
> Right, that's what I was talking about.
> 
>>>> Actually, the tag bit is only useful in zspage's memory space, to tell
>>>> if an object is allocated or not.
>>>
>>> I'm not completely sure if I follow this sentence.
>>
>> What I mean is that only the head of each allocated object need to reverve LSB,
>> which is used to check if allocated or not.
>>
>> handle address -> handle (pfn + obj_idx) -> object: (handle | tag), real_object start
>>
>> I'm not sure if this makes it clearer?
> 
> Yes, thanks. I think separating handle and object header in the commit
> message will be helpful.

Right, I will improve the commit message and send v2.

Thanks!