Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2296378rbb; Tue, 27 Feb 2024 18:21:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW0F2HTIo1NUWacQzy81/ytECwD0ijh+x8Unk7I7RgkzzgNRZV4YoBI5XFLPAc9SBOEM/hPVkJ+CknkNBUky+D66+fK9I0UxL9I/nA/qQ== X-Google-Smtp-Source: AGHT+IEvVdAvHAXMGnMhhjmMnsShblMDF1/pTAdOXlIFjoeUw0OW3pt40Tgw0DL+2GcUIVZW+3CA X-Received: by 2002:a9d:6a05:0:b0:6e4:545b:3bb with SMTP id g5-20020a9d6a05000000b006e4545b03bbmr12970558otn.17.1709086903453; Tue, 27 Feb 2024 18:21:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709086903; cv=pass; d=google.com; s=arc-20160816; b=VY537vSPAsvRdczpFipOdVW0txiCXXczzQNm7jNqXvAL2HdMXtFgcgdjFIkZebGkNt vLb2JfLmz9jEKinkg5i6QEOAoTEJdSQiFas4d0KZzmkAZm63rr6Az2bEVvDje4glkTbN hWVet9Xl/GPhaKxA+W9DI84gncrxxqFcbkbqBrjrWIg8PwzGo53vkGeKG85AQLs5Kqx7 AOXfg66+zAV2Dpa2IzStYRBlpNHwoM7HIZoyboyMyXm+hQAM0s/HMdDZmlYoQtIQ5qzS gd/yW+hRp0rXQv0uafqD1kCzAcCtCBfoYe2ld2xKJ3/NkSuViXy7n12gYDmhNm+i1xmo 0gjA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=39kPlQPGirA2pHmJdm0l2cPPkTyqHwb5Acho1j6B5XU=; fh=AgD5slY6jO/zOpPqfKSFNWwyZQD4Ie32v6AwKSSe3Tk=; b=L5fOXfJRiRyHkrwtiWTgQPqrycmuTytuWGspgc0Mvw5YWw8gaDkE5cLXtq1G9QUoVr 9Qik+7EsavcKSkHhNriULsyIfFXpg8ARpTbgO1TcVWpmzHeB9sRBEoJDh4VXuE79CDBE YxaxSNgHm/GQcUZGHGIYteCpuyFRZD9wfTenxkxKycecvIuTxVJhFKrGbp7PyDqir17U Warixn1zI/Pbpo2/e++qz9h5Rep5H4Bu2wgLP//O2TVg8PUjM0f/1WGs4KxU972TQS8F LhyJ7wWC4bBeZT0rIY/iiwr6hbvrzDmO0hYQuE1H7eOYnoBqdocG1WQG91MHaFwnr/AB wmWA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a8dq+jJx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-84415-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84415-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h7-20020a635307000000b005e43a9f911fsi6489084pgb.53.2024.02.27.18.21.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 18:21:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84415-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a8dq+jJx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-84415-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84415-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8B4AC283B0C for ; Wed, 28 Feb 2024 02:21:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 114E5199AB; Wed, 28 Feb 2024 02:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a8dq+jJx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38D8F63BF; Wed, 28 Feb 2024 02:21:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709086883; cv=none; b=qNH9U871rmEajAHr8dVGS7JCgf7HVLd8o9USkJVOzBpTX8oVdw9ZZIDsDWUWNFbiM3i+hykL8Tydxtrt1QJtzrEZTJdgLlm0Or2yHRSpUviuvD96Is62f/Xbf5BaX+aGqV8/PvRP47UTLFlXO5tzzCr5J4hQPJqCfixL4Carf/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709086883; c=relaxed/simple; bh=xZxmXfqYKc+OAJ6LSPpz1sYEgmU+RdmlU27lF29hLrY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KX2JqBpwK/DRHsxIVKhANjPxZf9NcYL3LU4xBdEWv8qFzsEW+ZNvV5+R36Bu15RvHAP0s21+TXrWxdnf1/PJBe9Lpi73df8HhMaMKulTkLTgnmjoqFLcTSwvYHIeOYKYeuRqEdQzivrE8i2eFEoMo8E1QaXyqJyJNLqSiddxe+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a8dq+jJx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 371FAC433C7; Wed, 28 Feb 2024 02:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709086882; bh=xZxmXfqYKc+OAJ6LSPpz1sYEgmU+RdmlU27lF29hLrY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a8dq+jJxOgYA8WGLYp6tcJ/2kW/gr8MXR+GJVVNv07PU5+V1cJm2iGQ5FkFArEXJV LvguIfMWhwHw+bgn4AnagWgMeLdoJb0JFxXC9HFg0wjWnZa6+iJGpCuukJ6caZTr10 OK0pp2HHWKeiYaVFf5USMQP3ixWLXu4aBYI7nGa+fceq5e/WMn6HAQ8xd0a22EzXDj EpEirJ0vxTZAG7cbM3i1SKL+FRkOk7zSyDJFYnC97wUCwyBiU1EEUgSpEiJtrJAK/a ODxlzOIxt4oysIYnVX8RXLn0OZU+BJeSe75YwAog0JPdhwKML2NwjcrUpQCl3dXez3 vQ1apNBEeXFZQ== Date: Tue, 27 Feb 2024 18:21:21 -0800 From: Jakub Kicinski To: Steffen =?UTF-8?B?QsOkdHo=?= Cc: Fabio Estevam , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Russell King , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/2] net: dsa: mv88e6xxx: fix marvell 6320/21 switch probing Message-ID: <20240227182121.055df038@kernel.org> In-Reply-To: <20240226091325.53986-1-steffen@innosonix.de> References: <20240226091325.53986-1-steffen@innosonix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 26 Feb 2024 10:13:23 +0100 Steffen B=C3=A4tz wrote: > +static void mv88e632x_phylink_get_caps(struct mv88e6xxx_chip *chip, int = port, > + struct phylink_config *config) > +{ > + unsigned long *supported =3D config->supported_interfaces; > + int err, cmode; err and cmode are unused in this patch, please move cmode addition to patch 2 and drop err which appears to remain unused after patch 2. --=20 pw-bot: cr