Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2304909rbb; Tue, 27 Feb 2024 18:48:25 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXOD/ZCJZ4/EsJAYMM0IQbfWt8Jm3sECxfzakYat+6PkDSFO5ICprLq2arUTzS0PUKrMXwmolxSjQMKkABHM1HUAR4f0n2/LRPachpEHg== X-Google-Smtp-Source: AGHT+IHT9NjBC0Tq2m4MusY28y9xyET1YHWNNM5AKA31sz8jJ+nqiq61cDQ5SqjeC37GW0YDxrA2 X-Received: by 2002:a05:6808:4281:b0:3c1:83fb:ee34 with SMTP id dq1-20020a056808428100b003c183fbee34mr3349323oib.29.1709088505543; Tue, 27 Feb 2024 18:48:25 -0800 (PST) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id fb26-20020a056a002d9a00b006e4d1f9ba33si6553198pfb.156.2024.02.27.18.48.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 18:48:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84448-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=dEmXryY2; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-84448-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84448-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3FA18283335 for ; Wed, 28 Feb 2024 02:48:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 523A520332; Wed, 28 Feb 2024 02:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dEmXryY2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D27621342; Wed, 28 Feb 2024 02:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709088419; cv=none; b=gJZ2CyZNTE/1GLwRJ3NSWM96CiONyx9xI8lyyr87NBdzN+s36FMWfFjjLP10j4R6GZayMaqpAcJwQlKnl9oluPexHTam9gmClEeh9LxOPAjRGEchK2MuKJYHadITdQ2yuFA+mOTimU6dY77EOYhHS2keWuvW4LZBs7s6UvIbaD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709088419; c=relaxed/simple; bh=Tnku9fdfb4RAYA9RXtUVS6U+UK5al6iZT05jrsPWoS0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L6WJ4KELXAZx72l11XULB/ruaFcaN3cWkgBDr9INKzBlrxNWintrNOPchMGHKIM2CFExZGZpSr646bgsX9cCG7wSXZiQtxoN5A+ZPW+hqQ+IsyZHws3sB4Vy2eU4oHBnst8g+5D2KTpzYSWlAhSA4nvdtY0fZIghQGiTPrZaqjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dEmXryY2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 940E3C433F1; Wed, 28 Feb 2024 02:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709088419; bh=Tnku9fdfb4RAYA9RXtUVS6U+UK5al6iZT05jrsPWoS0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dEmXryY25ebRwANbBUGtI6ksIrGC+yw6XPMwJUBMd6m2Gi30xmZVbqbY8Ko3brVrW HJpbknBs/B7AblepqcptwN0rSZFglUjP7NgdHr+wqwY6c2Hmb2idx4tMhbz8TH+4u2 QZe4fXRNcgYAMqMGrSN5Wjf84Hd9E9QDtsn/gjyW1WSB/ZWDnwNbb5NgJoeLIU63VW z4nEgV7p+Klt1JHkvDzOesqBietzTRZWD5sNC+UQO4t5k54lxYypBDajtyz6c0ZlUF m8W4WTKn1hwFhbvx/9ROKNDaYy0A8aST1VFUd8LT9Qb231W7pPAtVIgKSt2r/dFiD3 ut8Px/Nuw/5Ng== Date: Tue, 27 Feb 2024 18:46:57 -0800 From: Jakub Kicinski To: Markus Elfring Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, "David S. Miller" , Eric Dumazet , Madalin Bucur , Paolo Abeni , Sean Anderson , LKML Subject: Re: [PATCH] net: fman: Use common error handling code in dtsec_init() Message-ID: <20240227184657.76ec4e82@kernel.org> In-Reply-To: <9b879c8d-4c28-4748-acf6-18dc69d8ebdf@web.de> References: <9b879c8d-4c28-4748-acf6-18dc69d8ebdf@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 27 Feb 2024 14:14:52 +0100 Markus Elfring wrote: > Adjust jump targets so that a bit of exception handling can be better > reused at the end of this function implementation. Okay, but.. > .../net/ethernet/freescale/fman/fman_dtsec.c | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) .you've added more lines than you've removed so what's the point. -- pw-bot: reject