Received-SPF: pass (google.com: domain of linux-kernel+bounces-84464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e30fa7b9-e04b-48f8-9068-0a7afed2107e@linux.dev>
Date: Wed, 28 Feb 2024 11:16:45 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] dax: remove SLAB_MEM_SPREAD flag usage
Content-Language: en-US
To: Dave Jiang <dave.jiang@intel.com>, dan.j.williams@intel.com,
 vishal.l.verma@intel.com
Cc: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240224134728.829289-1-chengming.zhou@linux.dev>
 <b9966efa-8efe-4de7-b962-a6edcf2f6904@intel.com>
From: Chengming Zhou <chengming.zhou@linux.dev>
In-Reply-To: <b9966efa-8efe-4de7-b962-a6edcf2f6904@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2024/2/28 00:29, Dave Jiang wrote:
> 
> 
> On 2/24/24 6:47 AM, chengming.zhou@linux.dev wrote:
>> From: Chengming Zhou <zhouchengming@bytedance.com>
>>
>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>> its usage so we can delete it from slab. No functional change.
> 
> Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete explicitly to avoid confusion
for users. Here we can just remove all its users, which has no any
functional change.

[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/

Thanks!

>>
>> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
>> ---
>>  drivers/dax/super.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dax/super.c b/drivers/dax/super.c
>> index 54e528779877..cff0a15b7236 100644
>> --- a/drivers/dax/super.c
>> +++ b/drivers/dax/super.c
>> @@ -547,7 +547,7 @@ static int dax_fs_init(void)
>>  
>>  	dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
>>  			(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
>> -			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
>> +			 SLAB_ACCOUNT),
>>  			init_once);
>>  	if (!dax_cache)
>>  		return -ENOMEM;