Received-SPF: pass (google.com: domain of linux-kernel+bounces-84466-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] net: usb: dm9601: fix wrong return value in
 dm9601_mdio_read
From: patchwork-bot+netdevbpf@kernel.org
Message-Id: 
 <170909043155.27277.1060670387014071329.git-patchwork-notify@kernel.org>
Date: Wed, 28 Feb 2024 03:20:31 +0000
References: <20240225-dm9601_ret_err-v1-1-02c1d959ea59@gmail.com>
In-Reply-To: <20240225-dm9601_ret_err-v1-1-02c1d959ea59@gmail.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: peter@korsgaard.com, davem@davemloft.net, edumazet@google.com,
 kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
 linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 25 Feb 2024 00:20:06 +0100 you wrote:
> The MII code does not check the return value of mdio_read (among
> others), and therefore no error code should be sent. A previous fix to
> the use of an uninitialized variable propagates negative error codes,
> that might lead to wrong operations by the MII library.
> 
> An example of such issues is the use of mii_nway_restart by the dm9601
> driver. The mii_nway_restart function does not check the value returned
> by mdio_read, which in this case might be a negative number which could
> contain the exact bit the function checks (BMCR_ANENABLE = 0x1000).
> 
> [...]

Here is the summary with links:
  - net: usb: dm9601: fix wrong return value in dm9601_mdio_read
    https://git.kernel.org/netdev/net/c/c68b2c9eba38

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html