Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2317311rbb; Tue, 27 Feb 2024 19:27:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWLe7eOUm6N9cpCcuDc2WII7RRWtjGmnAQPJ0OO07+MGGA7VMD0aKdC+UooKzBpkn6jtoag5FYgHP2qSECyyhe/+89VvhppinKP0E/PZQ== X-Google-Smtp-Source: AGHT+IH91AhKtc41iV3uKM75bGP7S+982Afo8jj+yyZcQJ+TeWTmHQp2B6R6Aun7y7rDMJ+CqqQV X-Received: by 2002:a05:6214:e4e:b0:68f:e821:71ac with SMTP id o14-20020a0562140e4e00b0068fe82171acmr1095801qvc.63.1709090869985; Tue, 27 Feb 2024 19:27:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709090869; cv=pass; d=google.com; s=arc-20160816; b=C4krIKMIKh8OQjhZ+fP4OQzWlyiyDRkCfpjUuJ300Tzr67aoJ8Pcr3h1OjDJw9+olb 6dyUKNIQp1k0lg+B/G4Hh7kkUNqZkMMDReXAutqLKXHJ8ZMyndQ1t4O9/MAMgHSAZMtB tK9V0ZmKdozh1MfqdYYbScukY0TjHXCMMM1WTDozkITpXfusO11s6MuDziwGN4wwaSwa N+pHw7z5oQcslP4JMGdB5/Xr5lsePTWABhuBVtw6xujrMdSUdNMIX+LIbrO2bdRT8i40 VjX7RPKKVr36hUIfCAni4VBymlclAO4XwnVi+QA71QjsIBmTZQSGF5wcc44jPA6cZXE2 4SZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=x75P49PJH2W2/R48j3tGKRaMp5OAufEcO7TINsKp6lg=; fh=AF8u3Hq2LCAR86VDBUa9qi/2kjQJaPvHiqWvnKg4Z08=; b=Pd18733+ln85KWe8B+sdHcC0+fo7FNHXGpukkGE1AhG5JKZ0n8zwAKkl0/JvGmyXpC xN0LyJfqIoE7qqlHqIW7/wtZ05FxgjiHGjfCjTdRgJcZsrNdi0rMNfx0Q+BtqtGZvJV7 NfhtyslN3DtiIo24eRgxD4UKrvhQSZ3DMjPLxLiM3ae1s52HCVKHcnPA4dTvzOZLAkEV 64JxUBfZRYVaF/EoERepQkiFAiCfNQjqCOokRImF/HYMmSj8c/2KpyMaoWsuy4c253po MzJrvG0jUDuG0BZV1JW/cTjBjzAVxxX9eagEB+03K+ZxWF6jBS2BEGFysH0HzdHXK0YA Ezjw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QohiKP2o; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-84476-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84476-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id pt1-20020a056214048100b00690172d848csi4346632qvb.26.2024.02.27.19.27.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 19:27:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84476-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QohiKP2o; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-84476-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84476-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B7D591C24531 for ; Wed, 28 Feb 2024 03:27:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 123F3200C4; Wed, 28 Feb 2024 03:27:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QohiKP2o" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 318DE200A8; Wed, 28 Feb 2024 03:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709090859; cv=none; b=e1VtvUzfosd6d60OKhKY9/aRwP2ZhOH1EbJVMtwT7nl20QqzUWV06kiirUYmtlwDJJ19iLfJOzm+V6Un6Fy9eijfusnZiP2P4fNW7QFrbPasP/ZND2CA31G85Dd0B2ave9Cu4xzjRZkctOlNilXEbyu4nm0iyxqgstli+thTweQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709090859; c=relaxed/simple; bh=PxStEec/OucY88faF3IBr5N3T4pzL8MHzbg0huNkeQQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LngL6Un/NwScGnLxkQExdTMNBqDp6+9IvHf3AWv9h6wZAcX5IsUXG3/vUharvCen5EzbV942EYjTK2flTR//J4YxrCsWmm4h82ul9nbfYQ1w/n3An+jlUZmJ/ExTpEMMRTz5YBC30UJNUX1JEOsegf0/nCrRPzx5fyh99soMU5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QohiKP2o; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7E73C433F1; Wed, 28 Feb 2024 03:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709090859; bh=PxStEec/OucY88faF3IBr5N3T4pzL8MHzbg0huNkeQQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QohiKP2oUlYmBY59Cy+RuyemEWPJDO5INyMmAP4cnWYa61MvqxzWbOWQ7QrkAr57U sPpg2I9PAiQzmbh9Iq3kC5nizezkGjbTn2K677Ci8RM0B5MPa5LEYDpDBWRFxVnOxv t7jm4Z8ZGZ+7HELUw5a+ri35666+dhnF4QEC7+ycodAEqtCR1ZpB3fnhllDmrQ6i2l uHWckA9X5pRSMuh0VJVv9cbl4bC/lavkenE0SYuieyYYFuJ1NZY904mEj7XJrk4rH4 bOKFA5biMK++N9Y3xLJ8aq/RBcyJ3REIsDT68i7DsaVrM2ojBxaEAnBQva3sVviBmb tr1pEEF3/gjYw== Date: Tue, 27 Feb 2024 19:27:37 -0800 From: Jakub Kicinski To: Kory Maincent Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier , Rahul Rameshbabu Subject: Re: [PATCH net-next v9 06/13] net: Add struct kernel_ethtool_ts_info Message-ID: <20240227192737.5d834155@kernel.org> In-Reply-To: <20240226-feature_ptp_netnext-v9-6-455611549f21@bootlin.com> References: <20240226-feature_ptp_netnext-v9-0-455611549f21@bootlin.com> <20240226-feature_ptp_netnext-v9-6-455611549f21@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 26 Feb 2024 14:39:57 +0100 Kory Maincent wrote: > In prevision to add new UAPI for hwtstamp we will be limited to the struct > ethtool_ts_info that is currently passed in fixed binary format through the > ETHTOOL_GET_TS_INFO ethtool ioctl. It would be good if new kernel code > already started operating on an extensible kernel variant of that > structure, similar in concept to struct kernel_hwtstamp_config vs struct > hwtstamp_config. > > Since struct ethtool_ts_info is in include/uapi/linux/ethtool.h, here > we introduce the kernel-only structure in include/linux/ethtool.h. > The manual copy is then made in the function called by ETHTOOL_GET_TS_INFO. This one doesn't apply. It's going to be a pain to keep rebasing it, since its a nop AFAICT - do you want to post it separately to get it merged quickly? -- pw-bot: cr