Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757519AbYABVYy (ORCPT ); Wed, 2 Jan 2008 16:24:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753034AbYABVYo (ORCPT ); Wed, 2 Jan 2008 16:24:44 -0500 Received: from monty.telenet-ops.be ([195.130.132.56]:56932 "EHLO monty.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752931AbYABVYn (ORCPT ); Wed, 2 Jan 2008 16:24:43 -0500 Date: Wed, 2 Jan 2008 22:24:38 +0100 (CET) From: Geert Uytterhoeven To: Christoph Hellwig cc: schwidefsky@de.ibm.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Benjamin Herrenschmidt Subject: Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables. In-Reply-To: <20080102204435.GB15460@infradead.org> Message-ID: References: <20071112143009.425807965@de.ibm.com> <20071112144009.831296895@de.ibm.com> <20080102204435.GB15460@infradead.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1900 Lines: 38 On Wed, 2 Jan 2008, Christoph Hellwig wrote: > On Mon, Nov 12, 2007 at 03:30:11PM +0100, schwidefsky@de.ibm.com wrote: > > From: Martin Schwidefsky > > Solution: The only solution I found to this dilemma is a new typedef: > > a pgtable_t. For s390 pgtable_t will be a (pte *) - to be introduced > > with a later patch. For everybody else it will be a (struct page *). > > The additional problem with the initialization of the ptl lock and the > > NR_PAGETABLE accounting is solved with a constructor pgtable_page_ctor > > and a destructor pgtable_page_dtor. The page table allocation and free > > functions need to call these two whenever a page table page is allocated > > or freed. pmd_populate will get a pgtable_t instead of a struct page > > pointer. To get the pgtable_t back from a pmd entry that has been > > installed with pmd_populate a new function pmd_pgtable is added. It > > replaces the pmd_page call in free_pte_range and apply_to_pte_range. > > Can we please just nuke CONFIG_HIGHPTE? There's only been a small > amount of 32bit machines with so much memory that they'd need it > and they can happily stay on the currently supported enterprise > distro releases instead of dragging this cruft around forever. And all MMU-equipped FR-V machines with more than 256 MiB of RAM, according to arch/frv/Kconfig? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/