Received-SPF: pass (google.com: domain of linux-kernel+bounces-84496-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 27 Feb 2024 20:02:05 -0800
From: "Darrick J. Wong" <djwong@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: chandan.babu@oracle.com, linux-xfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH 2/2] xfs: Remove duplicate include
Message-ID: <20240228040205.GC1927156@frogsfrogsfrogs>
References: <20240228035612.25396-1-jiapeng.chong@linux.alibaba.com>
 <20240228035612.25396-2-jiapeng.chong@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240228035612.25396-2-jiapeng.chong@linux.alibaba.com>

On Wed, Feb 28, 2024 at 11:56:12AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/xfs_trace.c: xfs_bmap.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8385
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  fs/xfs/xfs_trace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_trace.c b/fs/xfs/xfs_trace.c
> index 1a963382e5e9..23e906b60f21 100644
> --- a/fs/xfs/xfs_trace.c
> +++ b/fs/xfs/xfs_trace.c
> @@ -17,7 +17,6 @@
>  #include "xfs_btree.h"
>  #include "xfs_da_btree.h"
>  #include "xfs_alloc.h"
> -#include "xfs_bmap.h"

Shouldn't this remove the second #include?

--D

>  #include "xfs_attr.h"
>  #include "xfs_trans.h"
>  #include "xfs_log.h"
> -- 
> 2.20.1.7.g153144c
> 
>