Received-SPF: pass (google.com: domain of linux-kernel+bounces-84513-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <12f0b643-e2e8-8a9a-b264-5c7c460f1a24@oracle.com>
Date: Tue, 27 Feb 2024 20:43:03 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 03/16] KVM: x86: Define more SEV+ page fault error
 bits/flags for #NPF
To: Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yan Zhao <yan.y.zhao@intel.com>,
        Isaku Yamahata <isaku.yamahata@intel.com>,
        Michael Roth <michael.roth@amd.com>,
        Yu Zhang <yu.c.zhang@linux.intel.com>,
        Chao Peng <chao.p.peng@linux.intel.com>, Fuad Tabba <tabba@google.com>,
        David Matlack <dmatlack@google.com>
References: <20240228024147.41573-1-seanjc@google.com>
 <20240228024147.41573-4-seanjc@google.com>
Content-Language: en-US
From: Dongli Zhang <dongli.zhang@oracle.com>
In-Reply-To: <20240228024147.41573-4-seanjc@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?QVl2Y1RERXNlNXVyMEl1UmRMVEprQUlCcm5tK1J3RUloTTJNM2V6OWtMSUVL?=
 =?utf-8?B?am41MnRyUW1Td2t1U2dBaktGbDZtakdOR3JKZ2hMLzBSeUd5aHUraHUvVFJV?=
 =?utf-8?B?cTlBaWxpbFdvckZOMlJXMGV3NnRrbjBaVEgvOGFpOFZ1V3Zjb0RMdVNpWVhl?=
 =?utf-8?B?UkNuNGJlcUpuWHFnanFocDJpbjNiNWlUY3JOaFRISU91eWhxWnhsNFdHMDFG?=
 =?utf-8?B?cnJVVUdseEJscjRlMGhsUzE0SXdUaGtGSDlIR0FKRk51eXl2VkNvS1FHSmZn?=
 =?utf-8?B?NzBNSkNoSU1BOWEzZFpTUWdPQVpEV3JIMjc5dWpFT2cyaVljMXMrR1Zyb1pi?=
 =?utf-8?B?ZXFqeDMyRjU4T0lDSXpFU1hsMUlpZHZzTmFwTHNCTzZ2V1NYbFhORmN5NVVp?=
 =?utf-8?B?aHBibmxBU1ZqTnNnbXR3VklGRnoyd2tQYkJUaStRZitqMVVXYlh3NFBIeVNp?=
 =?utf-8?B?VjVFR1dPOWNrQUl6RVMvV2o2TktWZEJOZUEveFM4U1R5V0hWcU0xUEF5a0Nu?=
 =?utf-8?B?ZXZuU3lySGh4b21JVDlUbE1BOGhOYTJlNUorNDI0SU5sZjloUmcwZ2dDTVNl?=
 =?utf-8?B?cmZ6aForNHZSOU1PcElaQXBvNVl3bVdqd2tlR0NuMzhmSnpDZUNoS1U5MHY5?=
 =?utf-8?B?b0NHeEUzMElNVHI0amxvWlF1UCtyMmtpMUdXR0gyZE9rSWt1OTgzbGl1ZHFt?=
 =?utf-8?B?dVpDc2FHM2hhVW1ybG1HNzkwSTVvd0prVThiZTBNRWdPUkVaRGJKWitQcDZZ?=
 =?utf-8?B?OUdKd3IwRUp1blUxZEFuS3lFNGd3Q21iMzJ5REwxa2h3cEtMbG50eUdmeDkv?=
 =?utf-8?B?eUhSaDNxWFgzZHFNUzZhQzNGLzR2TVBnMWlVL1dJM2VsS2N1ajVTUUpsUURr?=
 =?utf-8?B?bVVJZDhTV3g3ZDNMZWc4Wko1Nm92NTVDYUdtOEMzbGZQNldaeHpEVGF6aklQ?=
 =?utf-8?B?cHk0N2NnRWhWcU9sSmViZ0VMSEdTanBrSmY0SDRwNnBPcE1uZzdpTWhKYzVB?=
 =?utf-8?B?VnJIMktremlrdlhYK2VveXYyQTlrZ0oyWnEwdGI3V21taEJNZTMvUytNbHp6?=
 =?utf-8?B?SDFrcmV1R3ZNZWxXNFRvaWpWVzFucmJIa3JPM21CZjN4VlJTWmZRWmV0SWov?=
 =?utf-8?B?a3IyOVBQb2YwWXNlekF2eDdEWFlUZ21FaXBHM1pCS3ZEU05FeTVvVkVoWnFM?=
 =?utf-8?B?U0d3TE1IL0RSVkdKUWJ6S2hYMzFoTzE1OE5sTERlMWhKaVpMKzZXTThsQS92?=
 =?utf-8?B?QS9YSHViY0JCeUpqcmRCWGdhY2h5N0dIZnhyUEVPR0RJZzg5N21JbmYrbzRw?=
 =?utf-8?B?dHpQNUJ3WndXOHZsWi9qc1BBa0JGRFRZUkFpQVQ5RHJPWGhEUVBnZGViYXZ2?=
 =?utf-8?B?dlgxSGFxNm5YejR5eDQ2elZNLzJJcHNoamRTcFlYMzVhN0kwTGxNMWlneWR4?=
 =?utf-8?B?a2VRNlc0R2dOZXVFaVhPa1pYeFdJKzA5YzRoL0RyNjNRMVJGVktWb0JvMXR6?=
 =?utf-8?B?eWNrc0MxMU5VdzNtREtSWlF6WkVPelM4QnN1aHlUMnI3Mktoc1RlQW9FaVk4?=
 =?utf-8?B?cFN6YmI3SU9OTDhRdFhFTU9KVTdZTGhaSU0zMENXQytidElWVEhwUmRlYkZa?=
 =?utf-8?B?SUs5dGJPNGt5ZU04Nk9adVcrcllyRFA5U0FNcnRpYnRpZE1mall0aXFjaDBm?=
 =?utf-8?B?dVFEbkZjQVM5dEtTbExPNlhKL0x0QXNQYUVGUUlwNnUzbFFialhaVTFXTWNM?=
 =?utf-8?B?dTJ5dlIzdmdiaDZBRzRQc3N0MjFJdFZ5N0x0SklZUFdlblh0OEMzdjJTUTZs?=
 =?utf-8?B?SVJNaW5CbXZVRmNLVlpSZnl0eGl2MXkxNWE2VnZFc2lWZm1sMGxLT1NBM0hR?=
 =?utf-8?B?REJKVUdxZmRxV0xYd015ZG55R1FBTGlBNFZDUCtSNFJ3R2ZhbURNYjBuOFR5?=
 =?utf-8?B?QU9EOWlHenMyTjJnMVlQV0NUcjJ6OXZ1UkpKL1RTTStTQ1RTeWxxK2xidXR5?=
 =?utf-8?B?SEpTcVZTSnMza244MWV1MkJEc3R0bWJoenpjRTIzVGdvaC9Ec3lETWw5N29h?=
 =?utf-8?B?R0Z3V3AvTTBiTXU1ZU4wSUZ0N3JBUHE5OC9EZ1RvYXdEMlJZSU0xRnM2TG5T?=
 =?utf-8?Q?VTVjaAAzuTaViYiyBVVgNNjE4?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	yVVEL1Qh8wVzZ/4Y4Pih3WDQUZov7EMNkOTxiQm+roC1h0wySVXky7qFhgUzWfhbZ19sBBn4Q3bsyng2d2fM0w/O36hU1l6v4q8VIah5eZvpfaCyv8hCwNTj1Uqp6WyLCcckTuMEeHslM1Ru+BOSRu1nbRUiGZlSF57GVaURYGztT9jGST8oeR8kEcyNOoTunOL+VtiUYywY9ZcIBQo4ziZybPWIxkg0rCys0LGQQ6tYq+5+N1kq4+sSxabaxktdkf7mU5BtGtvBKdBlNF73UzX1SrznRKgIa/oNkLx47MFm4ccZbbAOCoVmdA3qrGd9tJTfC30ExEihpKFs2UL/+3zkLzP/8FKjEhYJVjSC30nq3niVmTt7Mp65iw0vazS5wDBA5wmVxUl/x1TOfUB6TTv5ZNiNzNU1edhfmnE1g4zUwBEvgC01t4uAJjvmBwSPOPANuoM1R2iQxjmj1lx5ZHYdG6mCtwQ/4It59ubL+PyVQpq8crgMlN1f+tIRS5HZ0RLTemxbwNQfjuC7I09YfGCjKR+X4Z9RnHF1Qm2BlTrBhUYGBSVroHNwiKU7jxdSxkcZkVK4xkBsVyMXWUv+jFhWT5lSyfdj9xCxeE0wQR8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b40e7a9-6dc2-4042-e7b0-08dc3817c33c
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 04:43:09.3730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kbmMGcPAYR0uQPHPfbgOpqlifjPyy8xH55rmGisvV0Qf0Cxo8OZpEx8z0hDXpjC4u0VKlx1l4NSQMA73dLKMHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4769
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-28_04,2024-02-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0
 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402280034
X-Proofpoint-ORIG-GUID: VOvepnwTbSXC2XPqeqIogtq7aOEpsAZU
X-Proofpoint-GUID: VOvepnwTbSXC2XPqeqIogtq7aOEpsAZU


On 2/27/24 18:41, Sean Christopherson wrote:
> Define more #NPF error code flags that are relevant to SEV+ (mostly SNP)
> guests, as specified by the APM:
> 
>  * Bit 34 (ENC):   Set to 1 if the guest’s effective C-bit was 1, 0 otherwise.
>  * Bit 35 (SIZEM): Set to 1 if the fault was caused by a size mismatch between
>                    PVALIDATE or RMPADJUST and the RMP, 0 otherwise.
>  * Bit 36 (VMPL):  Set to 1 if the fault was caused by a VMPL permission
>                    check failure, 0 otherwise.
>  * Bit 37 (SSS):   Set to VMPL permission mask SSS (bit 4) value if VmplSSS is
>                    enabled.

The above bits 34-37 do not match with the bits 31,34-36 in the patch.

Dongli Zhang

> 
> Note, the APM is *extremely* misleading, and strongly implies that the
> above flags can _only_ be set for #NPF exits from SNP guests.  That is a
> lie, as bit 34 (C-bit=1, i.e. was encrypted) can be set when running _any_
> flavor of SEV guest on SNP capable hardware.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  arch/x86/include/asm/kvm_host.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 88cc523bafa8..1e69743ef0fb 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -261,8 +261,12 @@ enum x86_intercept_stage;
>  #define PFERR_FETCH_MASK	BIT(4)
>  #define PFERR_PK_MASK		BIT(5)
>  #define PFERR_SGX_MASK		BIT(15)
> +#define PFERR_GUEST_RMP_MASK	BIT_ULL(31)
>  #define PFERR_GUEST_FINAL_MASK	BIT_ULL(32)
>  #define PFERR_GUEST_PAGE_MASK	BIT_ULL(33)
> +#define PFERR_GUEST_ENC_MASK	BIT_ULL(34)
> +#define PFERR_GUEST_SIZEM_MASK	BIT_ULL(35)
> +#define PFERR_GUEST_VMPL_MASK	BIT_ULL(36)
>  #define PFERR_IMPLICIT_ACCESS	BIT_ULL(48)
>  
>  #define PFERR_NESTED_GUEST_PAGE (PFERR_GUEST_PAGE_MASK |	\