Received-SPF: pass (google.com: domain of linux-kernel+bounces-84129-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <aa41ac4e-c29d-4025-b1c3-8cdc9830b5f7@infradead.org>
Date: Tue, 27 Feb 2024 14:31:03 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] virtiofs: drop __exit from virtio_fs_sysfs_exit()
Content-Language: en-US
To: Stefan Hajnoczi <stefanha@redhat.com>, Miklos Szeredi <miklos@szeredi.hu>
Cc: Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 Stephen Rothwell <sfr@canb.auug.org.au>,
 Linux Next Mailing List <linux-next@vger.kernel.org>,
 kernel test robot <lkp@intel.com>
References: <20240227155756.420944-1-stefanha@redhat.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240227155756.420944-1-stefanha@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/27/24 07:57, Stefan Hajnoczi wrote:
> virtio_fs_sysfs_exit() is called by:
> - static int __init virtio_fs_init(void)
> - static void __exit virtio_fs_exit(void)
> 
> Remove __exit from virtio_fs_sysfs_exit() since virtio_fs_init() is not
> an __exit function.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402270649.GYjNX0yw-lkp@intel.com/
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
>  fs/fuse/virtio_fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 62a44603740c..948b49c2460d 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -1588,7 +1588,7 @@ static int __init virtio_fs_sysfs_init(void)
>  	return 0;
>  }
>  
> -static void __exit virtio_fs_sysfs_exit(void)
> +static void virtio_fs_sysfs_exit(void)
>  {
>  	kset_unregister(virtio_fs_kset);
>  	virtio_fs_kset = NULL;

-- 
#Randy