Received-SPF: pass (google.com: domain of linux-kernel+bounces-84517-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Brett Creeley <brett.creeley@amd.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
	"yishaih@nvidia.com" <yishaih@nvidia.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "alex.williamson@redhat.com"
	<alex.williamson@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "shannon.nelson@amd.com" <shannon.nelson@amd.com>
Subject: RE: [PATCH v2 vfio 2/2] vfio/pds: Refactor/simplify reset logic
Thread-Topic: [PATCH v2 vfio 2/2] vfio/pds: Refactor/simplify reset logic
Thread-Index: AQHaad2mmn7QJGU1A0GQRc8NjAd5FbEfMPnA
Date: Wed, 28 Feb 2024 04:55:52 +0000
Message-ID: <BN9PR11MB5276CD4BF00814779A22CF1F8C582@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240228003205.47311-1-brett.creeley@amd.com>
 <20240228003205.47311-3-brett.creeley@amd.com>
In-Reply-To: <20240228003205.47311-3-brett.creeley@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sh9B2D54eZycLT7X8P+d67tkVORBPSxvaE3lDZLqhT/t05zH9XQGAiHSArXP?=
 =?us-ascii?Q?494d3hqr2zvSoKxzBSz5SLs4+NyTAsTnKvE/nKpp8Xdi2d8BmTSFo3DepXBJ?=
 =?us-ascii?Q?xnFXA70OD56yBIRU5iYx59lPcheGjtgccUdd1157wJA7P6vsgadGsABWsz6V?=
 =?us-ascii?Q?WY5kkx9zFV5UGInDY4R+aMSb7aU9o0fgxfsnalNXOuH7ZQbij6UWi/wzx4sE?=
 =?us-ascii?Q?md9SHUvkYZFv4k9TVtvpJQhVAxIpCsUB+hsuzfrhe3qiTLlRv+SaH0owjhdP?=
 =?us-ascii?Q?NEE+Ufvk02Qd/pPuc92ARImiYfAukvWejRoiUGM5euVc9RLHYcD9oIUiaPnJ?=
 =?us-ascii?Q?khkyFExVcId4OXoEcDzx7XVJZuN6hEIuDvDhl6apytZNMo4g7RRODsggBwmt?=
 =?us-ascii?Q?BmHE7ym0uVGXnuHrzrKbYnuog+GZQcgI0CmtvIPmqXp08M2Dwj39OXiyHUtj?=
 =?us-ascii?Q?sGrEZ3OUSf88yyWBWBujDlVASt/7TH33L6fqO2OLsUIhaUMrSeizRgOjkfki?=
 =?us-ascii?Q?dAJydH8FTXMgL6XqEWTbkHRZfHxI70uVskhh9uRjOl+9qaraeKkT5NRB0DzE?=
 =?us-ascii?Q?FhOe7T70evRsDVpUW4ZQNJSJf4T2A3zRWZo98Smwe6iwEI2x8FNHE6Zvj+BV?=
 =?us-ascii?Q?h42EsW0RdpVS0QBBkYlpYBulOJRsyGr80ofIK5sX8oW3P7WwtnCQAAaymyCx?=
 =?us-ascii?Q?uDNNZJTw2vMJvuNpuEVCSN7uHB6IUJULDHEbPsLgCXbhAaWnt2cDyDKa6Rhu?=
 =?us-ascii?Q?7AIY/UvRDDRkyngexuY+DfQpEjZ0wnFnDQgmeJgVUaZpsa0wjGTM0LzQWleS?=
 =?us-ascii?Q?YEnGDKhNlzxRhYDKrGeGtnspJkxv5rVvwpKQ0niudjedKh1THO79qzt+YtTt?=
 =?us-ascii?Q?ZtfaRZaw7MXKG86k8xiqGV8oJnBVhc3iNZgvwjDtJHD9+7AyKYPIGohrZ9QC?=
 =?us-ascii?Q?w8vGKHHVEK4p8Mmm4Eu2+ZAOScwlERL9h+kFNijYKtKUfy2geGvqp5pFxkyS?=
 =?us-ascii?Q?ABiM2OreNpgcUCQBJI5E60QRLRlvrDo9FLoH68s5BDzhqPjyU9UEGXhZuP3Q?=
 =?us-ascii?Q?e1D3b5WBnz1iOaU9vXm6Wrzj0yPGyVzSquK2sUuBKoT4E9DSpMhxS9x5Ek/X?=
 =?us-ascii?Q?VfmJ3XFX/eVXBVr9PAwWlpBI/GFZJ9EaM9zHlw4BoDAK/qY0FSqSEjssL+H9?=
 =?us-ascii?Q?7mTYKc0ZWf9ASOYWO7MKYMHvKxPniyyUL37LiDTEKzL0UBsp2OPZlqvu4M4+?=
 =?us-ascii?Q?eG0n/W6gdQUIA0bmRbD1ZgGMLKyQEVC/WW4pXcQUEVrpnESQWU2OlswPi7D6?=
 =?us-ascii?Q?obkFlW88sW0iUmaNW8yDet6Z7jW+lYqHxAVipAbHxqSD3ymuoapFpvf3nHWn?=
 =?us-ascii?Q?ipmUP3VwanlEMsl3qMRlv/4DKbM1mkMI/nWHdJSTu/zePfV4/RYNMbWaBtJd?=
 =?us-ascii?Q?RoYXJd28/smUz9miETH/b89wFOpl+T/BpY9+WBNcQ9NT7Pv7hnAnlmtlQiYY?=
 =?us-ascii?Q?gsV+qAH6yO+o3UQUMtpD5B/cpi+4Oe5KaSg6jMZsaM+UW2Mr+bLEPKN8Bsv8?=
 =?us-ascii?Q?bpnwcctD3hSIotng5hJcYqmNHFW7DlNnLVJpLCnH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2b2409e-57ca-44c8-b46f-08dc38198a63
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2024 04:55:52.6515
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Et5WquG9Fcqna+C82BLEXxn2QhujAFM3kZtl7Wec4h7FTDlQkFXJRo+AOe6FKvuh0JJu5M3ok+0sCR3R0RgmWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4781
X-OriginatorOrg: intel.com

> From: Brett Creeley <brett.creeley@amd.com>
> Sent: Wednesday, February 28, 2024 8:32 AM
>=20
> The current logic for handling resets is more complicated than it needs
> to be. The deferred_reset flag is used to indicate a reset is needed
> and the deferred_reset_state is the requested, post-reset, state. The
> source of the requested reset isn't immediately obvious. Improve
> readability by replacing deferred_reset_state with deferred_reset_type,
> which can be either PDS_VFIO_DEVICE_RESET (initiated/requested by the
> DSC) or PDS_VFIO_HOST_RESET (initiated/requested by the VMM).
>=20
> Signed-off-by: Brett Creeley <brett.creeley@amd.com>
> Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>