Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2346832rbb; Tue, 27 Feb 2024 21:07:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUI+9KnIKaADo6xgVciozr0519I+OB+NM570Bl7fXU/Qm1Xn7PClQCy56Ft/lh+Kx7R2iSjsTYid4nIWrs/4vQb+cW7WE6qPFzVWSKYRA== X-Google-Smtp-Source: AGHT+IG2e3CB1+9T1swHJgJ9jR27+8fBeSOBmYF1JLWjtCOKubxeeoixOF19v75evIlyRAUBxDxl X-Received: by 2002:a05:622a:18a6:b0:42e:b0ac:8e76 with SMTP id v38-20020a05622a18a600b0042eb0ac8e76mr153192qtc.58.1709096837200; Tue, 27 Feb 2024 21:07:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709096837; cv=pass; d=google.com; s=arc-20160816; b=iEFqCyheExe57aNH7y93lyL67UqaEm5BmPFQjR3JZwFejT4hbdQ1MKuVU1xSmGTRvC ZHqtW3VjvXcG1hK9A9yyansYk1p27A3iZD6Q8pej/sKT+1lbpEP/HRBS+uMUt9kNyn55 KsKnKLHCLFzUI1DroT1t3vM8LWzLOsrfrj7hmgpc9UW6/KdQzrRNp3Cut0KyX6+Plj+G ett1zaj0dtIZjLe5KioYDCZBEFmrMsBAa3QY7fya9YWHkC4EslbOFwbaOEqa48dLSXWw tPFdZ+KTuS52S0ij2IPUEwRTRnvybxRq9PDN8FUGwth10KvSaowjLozrWU/4T4IDtyad jE6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=R0hZi4IwldcafUQOYCQfscMvfB7SqlvXbZvfr+ma3bQ=; fh=nPIZAKVPjoC9ugaQV++LKFlIEAs/xAgd881j1IjmxTM=; b=zRvhSjlr4pMqf5PWzu2TAobknkH3SU1c0G1SVCnzianLILiehdy7OXi9rsO6XYfIwM kFsxcf7L9lbGZwgXm+3kVbJ6lCdFUjLgU1eI+8t5v47KKIfq6Sf3LwgE+QThwAAOHGlk ++3QscEnKYfN2zGJNof/8FuF5Q4SMFFNOZRNiiPWLiFEjgxd2sxqpCwfPd4vUsd3l0fo C7f9Q7E25dZnlCkm+3ldEaxv7arSCDcgKdLabtsC0p/zX1GBnNOBS2KntkshEzHZIS9w /w/JBDmNDBmdMdx2FdaCkSD7VOR9eeAZ1RP3cQaL4n4aUyOCICY1qLx/LAyna/UDo45R acFw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ZM93a2D/"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-84520-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84520-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id x6-20020ac85386000000b0042e6cf9adffsi8842737qtp.609.2024.02.27.21.07.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 21:07:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84520-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ZM93a2D/"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-84520-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84520-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F0AEF1C21745 for ; Wed, 28 Feb 2024 05:07:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5E2FA2030F; Wed, 28 Feb 2024 05:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZM93a2D/" Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BB2D3205 for ; Wed, 28 Feb 2024 05:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709096828; cv=none; b=R1z5z2bSnJWPPf9MGQH+KwWYGHhKUWRleBunhrwUyU/qtHFN/5NWCgl4iSnSl6Qz/flehFoOS0YZVnrmLwoKi6zp3VLkhw1z2Vy3FaKKaWXHFOklTGuON3ZQN6KqvwT5LgxLWslTHosWLO0yz9I893ljGd4B7lzg5bWP0JQPSfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709096828; c=relaxed/simple; bh=NDYMj29qtQkbokr4QHvEZT1PzlIAohTJuF1hqdMFy6E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P/uReyP8FVvFW8niACpvGtpTHTB7nI5vHDla89H0Zg/AJVw6h56YZMji7G7Jj5hyYyrju1zD1/5nlV/MDAkqc0Wa7wOH90uDtyVylv8JDLOItJt4FB1CyJbnQedmmjLZVjFMkxiZpbxKKiIjhctKdUj7wo6KQAqgSaAOD+ALrCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZM93a2D/; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-5c229dabbb6so2829438a12.0 for ; Tue, 27 Feb 2024 21:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709096826; x=1709701626; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R0hZi4IwldcafUQOYCQfscMvfB7SqlvXbZvfr+ma3bQ=; b=ZM93a2D/sBtqxcYD0tx2QmDp2LJOCQr3/zVp0/jrdPmRvGzo/2XDUGvUmt9SAL5tqq BPQreJ2/zRs2G6R2sBhAthyTt9JHCN4O0GAHTWQXtdNNueMUf0QfckiEhnrY5w1tWG72 0rnFWt2HKHDCLGdEn++VVaq7Vgl2whjy2vEmKASi+hW/BW0/4xvYtmCL9ix4jhlJImq1 4jVx6pIgMhiqMdAYG03zVMoPwvP7l56frQ7NnXeZgLQWrCkCI3zbSUq+B4EEF+hVfrYW H0Ge7pOpW6Nog0aNV5xa1C8qmbI223fGCoR5RAa2r57kRZR0lSH9OrVnXke8VSBMbDQ3 cihA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709096826; x=1709701626; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R0hZi4IwldcafUQOYCQfscMvfB7SqlvXbZvfr+ma3bQ=; b=pnF794IwFBW/+GtL0EyAZkYayIWGVH+pGks0v06n/Bhp3NtmaJLZpg6EFsZZTvij8Y /FXkrd1ILn7byz3K1BdDSC7dEJ3PQvl4wSDGMCV//4+mjwUD7oKyDsPGJWAYb9nP6KkI IRqoZkqb5YsoA6hBqzJ4UnC1yyQ7vI96WujSfv0MYUEEuAxJ6Wi1u0CX2alMIwBO0VKo pEfv78LqBfBhthace20y9GdqYI27/m2EjiRThuDU5fD1xLVo7Q8CEOfWWshOMwfzZvvW KWQ05aM06H9CMV+Ja3NwRsu1lQ8M0WQa0gLJMNGH7EuqfzPtJKiPTm9+aPkqA2Im1NwX HN2g== X-Forwarded-Encrypted: i=1; AJvYcCXmIU0pA/W2UKZfrG8ZXd7lIOowA99nYn5CBYpK/BVAmUGv0kfR83HvqOV3vVvjTiXxMfVvGWWQb5H5tnw8aTuF44YvcrMwVv4XJnUL X-Gm-Message-State: AOJu0YwNFx8pjJ/pKSj9KeuW0IG9d9UAD1kYed8NBWpjxszH4em39FmL miqLTBJnMgF4GYo9P6UrNhoDVPGq1ujt25aDbcM8ZobrhPQ7kElolQlo6EhuBNg= X-Received: by 2002:a17:90a:bd16:b0:299:275d:c346 with SMTP id y22-20020a17090abd1600b00299275dc346mr9882375pjr.5.1709096826514; Tue, 27 Feb 2024 21:07:06 -0800 (PST) Received: from localhost ([122.172.83.95]) by smtp.gmail.com with ESMTPSA id sk6-20020a17090b2dc600b0029abe1c3f26sm511598pjb.1.2024.02.27.21.07.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 21:07:06 -0800 (PST) Date: Wed, 28 Feb 2024 10:37:03 +0530 From: Viresh Kumar To: Sibi Sankar Cc: dietmar.eggemann@arm.com, marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, rafael@kernel.org, xuwei5@hisilicon.com, zhanjie9@hisilicon.com, sudeep.holla@arm.com, cristian.marussi@arm.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_rgottimu@quicinc.com, linux-arm-kernel@lists.infradead.org, asahi@lists.linux.dev, linux-pm@vger.kernel.org Subject: Re: [PATCH 0/2] Fix per-policy boost behavior Message-ID: <20240228050703.lixqywrtxravegc6@vireshk-i7> References: <20240227165309.620422-1-quic_sibis@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240227165309.620422-1-quic_sibis@quicinc.com> On 27-02-24, 22:23, Sibi Sankar wrote: > Fix per-policy boost behavior by incorporating per-policy boost flag > in the policy->max calculation and setting the correct per-policy > boost_enabled value on devices that use cpufreq_enable_boost_support(). I don't see the problem explained anywhere and the patches look incorrect too. The drivers aren't supposed to update the policy->boose_enabled value. -- viresh