Received-SPF: pass (google.com: domain of linux-kernel+bounces-84577-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <8ccab1ca-428b-4812-b46a-671e816dd34d@amd.com>
Date: Wed, 28 Feb 2024 07:51:36 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amdgpu: Fix assignment errors in
 'si_common_early_init' functions
Content-Language: en-US
To: Lu Yao <yaolu@kylinos.cn>, alexander.deucher@amd.com, Xinhui.Pan@amd.com,
 airlied@gmail.com, daniel@ffwll.ch
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <20240228014435.7234-1-yaolu@kylinos.cn>
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <20240228014435.7234-1-yaolu@kylinos.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aHVhRHN4YkRTaGpDZnpzbE4za0d4NDVaODZ4OEplTi9jRFRvRWdvTGhuMnpH?=
 =?utf-8?B?dHRKU2NJeGZmU2lSV2NaaDVDMDJJSWl4eWorUit5WU5CWCtjZVB5cC9GZ25X?=
 =?utf-8?B?TEVRWFFMN3llWk4yeUZ1VHVjUVdUMXIxSkprK0RvM1hxT05mNGUvaTFyYWJx?=
 =?utf-8?B?aDdHUGlxbEFtSzlNSVh0b29OYVBiUDVkNndYYmRnSCt5cUF0RTZMd0FqNk9E?=
 =?utf-8?B?UzREVHJhTjRvQWM0Q2VkR0Rjc2tqLzNOZnNLTURMTlZLVkZRVDYxTGs2NzhH?=
 =?utf-8?B?UTFzZWZyWFp3NWhtbkpSTVV2am4wVGI4Ui9RdHBadWFOUC84d2FqVmlhM2VJ?=
 =?utf-8?B?WEdOWFhXYnFGRHdTdFpMYlhaaEk1S3pCYm14b3BkWHVjTXVrb3gzUFdqNTYz?=
 =?utf-8?B?dVpMRkxkSUZsT2VGQlAxK2pZeFd2TUZQQ3RjN0FuSzJzZW1iMmxGQnJPZjZw?=
 =?utf-8?B?NWRmQ0Z2S0R0V3RDRzBxK0pUTzRTN1BQOWhOZGlXMmdtbmtaWlBQZE9HMEUy?=
 =?utf-8?B?bmdjU0VlY1BmRFVCTFdSdUJQd0UzYlVla3FtcXNyU1JmeE9DMTNaQndtaERZ?=
 =?utf-8?B?eEphbUJIMlYrem5hakxXUFlvckp3VkVqM053elgxYmxLdkY1bEFNdmJQSkE5?=
 =?utf-8?B?M01NZzQ4QzlrQllpRFJmc0RGWkFEdG93dlRYZjhtVTZOVXJwTmNpY2luaDJs?=
 =?utf-8?B?MElGVHRGTkdkOFNqVkVEV29sZEk3ekE5NmNqUkpid01wYUF4WlpLT3lSVE54?=
 =?utf-8?B?NXA2dlZOaE1NdTlVRHVyMmo4THFqdytLaVBJSjIzMzZ5dUEyNlJrUGRpTWtF?=
 =?utf-8?B?dVpTYkhzTmF0dE5EWEhiUzRJZlp5YlRxM2RSOXpaMldxdVdiM3dzd3B3cldo?=
 =?utf-8?B?bEZHaWw5VjZUT2VlWDFWeWE0dEw4dEl3WkNHTC9SWnBTelVLdjFoc2hqeXp5?=
 =?utf-8?B?dHJoQVMzTnFzZUdhSEUxc1U3WXBzVlNFNWpXNWQzcmtZKzBJL1hBbXNFR2sv?=
 =?utf-8?B?aTQvT3ZNci9wY3IrNWhTRFl1NkZOSmEvbmJ6d2RlSVRTSHdSdS9rM3o1RDE5?=
 =?utf-8?B?dTU0NFZRc2hGTW53R0hPdlRZMmtFaEZVWjJlcVVKWGo5K1pQWGppa3BVOTJn?=
 =?utf-8?B?SnRuWVRIV2NpRnBZTHRRY1RxSWs4LzN4REhOWHc4b0x1V2pZSW1YYWNSUVpy?=
 =?utf-8?B?MjZ3eWZIdW4xalB5cG9HMnZCeC94V3crVTAvckhtckhkWlhrMzlNZmwvM2My?=
 =?utf-8?B?WlViZUE3ZjVWODQxa2FzaU42dGFVQTNFN2o3MnpUcC9EbFJVU2FYNFJTZkJl?=
 =?utf-8?B?Z2FvYzhsblc5WTVnOWs3Rlg5Q3RCZzhyd3BQcEhzc2dQck1wNm1ibDl6dmZ5?=
 =?utf-8?B?OHZNTi9CWjk2UjRHeldhREpaNVk0QWx3Z1RGYXhEWTdPYThnTytDc0RUY1RK?=
 =?utf-8?B?Nnh2OWR2RS9FSDl0ZWlsNHUrMFE0UC9BVmRnWDl2RXZjTEMveHRLdHcxTEtU?=
 =?utf-8?B?MTRGYURQOHM1T2ovbVk0VkxyNSt1Z3Q2d3hJams2ZG1KKzJwQVJGemtDZVFL?=
 =?utf-8?B?WWJZTVlzZG1VWWdITERiM0ZUeFNxVnBzd3JudkYyT3B0cGxFbGswOGZOTHh1?=
 =?utf-8?B?WUU3eHh6a1RNbkJVZFVmZjdZTTFGd1hoTEVrTlQ0UGQrTU41dWpNaVBMTktK?=
 =?utf-8?B?VlR1Ujd2cFJuc0I4Y3F4RS94MjRrb2RZOTNObFd4VFYzZVh3NDk4WjE2RnB2?=
 =?utf-8?B?TWs3elpJZ1AvQWZTL2VJUTZkZmtvM3RHenN3djBuL3hSaW9hWkVrWXptL2Vm?=
 =?utf-8?B?QmVTYXNMQytva3hNVWFRVWRXZzdvOG5iZVkrMEJGenpkYm1uTXlkUUdKUGNM?=
 =?utf-8?B?V05WL1pxa2U2c1pXOHp6dGNwdHo2MVBaMVZXYWYwS2dpOE42WjlvTk10QlVG?=
 =?utf-8?B?UUFTVFZQUndMYk5WbFJYNkFuWG10SlZCS1FoMHlweU9HQ1JSWlVPNFdWejFo?=
 =?utf-8?B?YmNDN1JmbElHL1RqWTJqRVlsc0Zva2NranBsUFpDZWFHYmhIcUVlM1N5SGZ0?=
 =?utf-8?B?b0VMSTIzNnp0M00yY0Q5ZUdaNkZ4WVc3Tm1HZXpQc1VoM1h2UmVHNjZTVSs1?=
 =?utf-8?Q?yewyQC/qmeOgi63xajv6YJXkh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32d60516-ece0-4ddd-47f8-08dc3829b8c5
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 06:51:42.7374
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EAodHW57hui/ffXLxb+iC+4KBHf9ZakxWtYYfMaOW658tKMfPYX8EO8azlsXIl0P
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6028

Am 28.02.24 um 02:44 schrieb Lu Yao:
> uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer.

Yeah, but that is completely irrelevant here. We usually don't use the & 
for function pointers since that is unnecessary in C.

Regards,
Christian.

>
> Signed-off-by: Lu Yao <yaolu@kylinos.cn>
> ---
>   drivers/gpu/drm/amd/amdgpu/si.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
> index a757526153e5..455d49f7bd9c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/si.c
> +++ b/drivers/gpu/drm/amd/amdgpu/si.c
> @@ -2032,8 +2032,8 @@ static int si_common_early_init(void *handle)
>   	adev->pcie_wreg = &si_pcie_wreg;
>   	adev->pciep_rreg = &si_pciep_rreg;
>   	adev->pciep_wreg = &si_pciep_wreg;
> -	adev->uvd_ctx_rreg = si_uvd_ctx_rreg;
> -	adev->uvd_ctx_wreg = si_uvd_ctx_wreg;
> +	adev->uvd_ctx_rreg = &si_uvd_ctx_rreg;
> +	adev->uvd_ctx_wreg = &si_uvd_ctx_wreg;
>   	adev->didt_rreg = NULL;
>   	adev->didt_wreg = NULL;
>