Received-SPF: pass (google.com: domain of linux-kernel+bounces-84583-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-182-gaab6630818-fm-20240222.002-gaab66308
Precedence: bulk
MIME-Version: 1.0
Message-Id: <200055c2-30a2-4b3a-a102-abacda522c22@app.fastmail.com>
In-Reply-To: <ae7a35e9-16f6-4877-8075-a0fb9fe5bfff@t-8ch.de>
References: <20231104-pvpanic-shutdown-v1-1-5ee7c9b3e301@weissschuh.net>
 <2023110407-unselect-uptight-b96d@gregkh>
 <20240213053953-mutt-send-email-mst@kernel.org>
 <ae7a35e9-16f6-4877-8075-a0fb9fe5bfff@t-8ch.de>
Date: Wed, 28 Feb 2024 08:02:15 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, "Zhangjin Wu" <falcon@tinylab.org>,
 "Willy Tarreau" <w@1wt.eu>, "Yuan Tan" <tanyuan@tinylab.org>
Subject: Re: [PATCH RFC] misc/pvpanic: add support for normal shutdowns
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 28, 2024, at 07:48, Thomas Wei=C3=9Fschuh wrote:
> Hi Michael,
>
> On 2024-02-13 05:41:48-0500, Michael S. Tsirkin wrote:
>> On Sat, Nov 04, 2023 at 02:05:02PM +0100, Greg Kroah-Hartman wrote:
>> > > diff --git a/include/uapi/misc/pvpanic.h b/include/uapi/misc/pvpa=
nic.h
>> > > index 54b7485390d3..82fc618bfbcf 100644
>> > > --- a/include/uapi/misc/pvpanic.h
>> > > +++ b/include/uapi/misc/pvpanic.h
>> > > @@ -5,5 +5,6 @@
>> > > =20
>> > >  #define PVPANIC_PANICKED	(1 << 0)
>> > >  #define PVPANIC_CRASH_LOADED	(1 << 1)
>> > > +#define PVPANIC_SHUTDOWN	(1 << 2)
>> >=20
>> > Why are these in a uapi file?
>> >=20
>> > And if they need to be here, why not use the proper BIT() macro for=
 it?
>> >=20
>>=20
>> This is interface with hypervisor not userspace, but for PV historica=
lly
>> we do this since the compatibility implications are about the same,
>> hypervisors (e.g. QEMU) are mostly userspace and so it is convenient =
for
>> them to reuse the same machinery to export the headers.
>>=20
>> Let's stick to that, cleaner than duplicating everything I think.
>
> as Greg seems to be busy with other stuff I'd like to go ahead with
> submitting this again using the existing header file.

FWIW, I agree using the uapi header for APIs shared between
kernel and qemu is fine, and we don't really have any other
place for those, so please add

Acked-by: Arnd Bergmann <arnd@arndb.de>