Received-SPF: pass (google.com: domain of linux-kernel+bounces-84609-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <6c10e17a-b1f2-c587-fbdd-85d15256b507@oracle.com>
Date: Tue, 27 Feb 2024 23:30:32 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 04/16] KVM: x86/mmu: Pass full 64-bit error code when
 handling page faults
To: Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yan Zhao <yan.y.zhao@intel.com>,
        Isaku Yamahata <isaku.yamahata@intel.com>,
        Michael Roth <michael.roth@amd.com>,
        Yu Zhang <yu.c.zhang@linux.intel.com>,
        Chao Peng <chao.p.peng@linux.intel.com>, Fuad Tabba <tabba@google.com>,
        David Matlack <dmatlack@google.com>
References: <20240228024147.41573-1-seanjc@google.com>
 <20240228024147.41573-5-seanjc@google.com>
Content-Language: en-US
From: Dongli Zhang <dongli.zhang@oracle.com>
In-Reply-To: <20240228024147.41573-5-seanjc@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?VTMvNExESTNuaHNQUE1tM0tKV3VyMHB1M3NkcGNSendMMTd6TlYwdTk5ZHg4?=
 =?utf-8?B?VGJMVm16bllBSU1vaW03ZXhGdEE0T3cyakE4UFY4WkxScC93VWZlU3k0eWFw?=
 =?utf-8?B?cEVYQWJHMFQ5bk5sRElkaGpoVStRUzhGcHkwSE9JS3JhSkRmajZEWS83eVJC?=
 =?utf-8?B?Qkt6dVUzOWpCYkc5VElwemhIaVRMdW54ZWtBeWI1VmM1ZTBnNnFhRTRuY2l4?=
 =?utf-8?B?YXhGNE4wdmQ4ZXNhai92c0xZdm1sSjFmSC85L2l0a20xUVJtMHdZc0pmMVNX?=
 =?utf-8?B?aWF4bHd2U3B2aFg3VDRZaXc3RG9LVHBMd2F0Y3p6Sm00MXBkK0dZZnB2WnV4?=
 =?utf-8?B?R0dybzczZk1RYTRzMWNzL3B3WmhqRzdwL2JKY1ZtdUJSUzFCOWt0b1MzR1ky?=
 =?utf-8?B?bHB2ejFHeVg5K2I4d1hYYVpNcXRWUk93bm0zTFBjcGI5UUhrNVVYLzAzNWln?=
 =?utf-8?B?M1EvY2h4NGFhcFovM2JJY0xzYjhaZVA2UFdJcnVjc0lERVREUkRmbGJ4cmpP?=
 =?utf-8?B?NGR4NTczSHlJQVNvZGZCdmRYOHhSdWJHWW54cy84dkdsVGpUT3B3T2xEYjgr?=
 =?utf-8?B?NDN1dElxNzJXWTE1OWd6N0w5R2FyT29IY21ZYmp6ZEZQZmlFUlNjWngxdGhR?=
 =?utf-8?B?Z25CSEQzS1N6akttSzdncEtRRUlyekk3dTJVMXFqTnRYdm1oeCtBZFNvL0pz?=
 =?utf-8?B?dU9UdVFIVEgxZ21FSXU1bnRrQ3ZaWUR0bHdHNFBvU2NWOStmTTRFTzV4Y0I0?=
 =?utf-8?B?UjdYWDlRQ0xNaHRkaEozRHNOS1hKVXlWVkEyYk5yb2VQNE5xeWh6eExlYmNs?=
 =?utf-8?B?bGxLZnA0NE5xYjk3c2I4TTZPbkgwSVZjNFhSUjJnTVl3aEI4ZHJDa01WOUd3?=
 =?utf-8?B?UWU5dGVJRE9IN2tzekxlRFBBeFJHSnJoZDk3bE1ZMk5sSVgvSncwSVkzMWhj?=
 =?utf-8?B?aDI4eU9YeXVwRUQ0MXQxc1RwQkVJVUVYaWxvckpPYlVZTkNRQ0pHTDVVMml5?=
 =?utf-8?B?VnVaSW5TUTJLNzVaVGo3Wk9tRlJFRjI1UEpaOXVsOElpcWtrNDhVVmR4RnUz?=
 =?utf-8?B?MVFCZlZhdEE2RUEvcGo5U2ZBaFAxWjZvN2w5RVdSZWNwY3l3QS9vRlhGMzNr?=
 =?utf-8?B?N3VidkR5Wm10WFNScWlQN2tjNWZzRzNSV2U0d1gzUW9JRDZ5bytTTW11M1hN?=
 =?utf-8?B?VWppS1JvQjRnSGFacnVtZnRITkRTUnFsUlVNdHVWVjZWcjA4QVJtaXJDNEl2?=
 =?utf-8?B?MGdacUgrY2RBTDJxT1lwV3pFaWR6M1JwVHg0QTA5cGx1dnVCRlo1VytIdzgy?=
 =?utf-8?B?V3BnODlRZ3l2dGJaSkMyUVVTenhBYnhnQ3RMRVFzZlIyK0RMalBldDZRYkNn?=
 =?utf-8?B?OVV3UmNrS044YWwrWmRpN3doY0tacVBhMGZlWHhiTTJ5dElaOUhjNHcrWnRO?=
 =?utf-8?B?UWVaTTJEeHlnVHJKUW9nTjFPcHc1d05zNUFMT0MvYVNpMWUybnV4SnIvV3hN?=
 =?utf-8?B?MUd4ZXdLSHpzY0JKMXM1VTV0Wllrb1ZOQ1YxM1E1dWxZKzFpTyt5Rkg2Z3cv?=
 =?utf-8?B?Z0RZRnlNUmNnU25idDI4ZnhxWlBzMWM5ZktHMHFaRkdpR3dJbmdRQ2hRYXFN?=
 =?utf-8?B?SzJwL2tpeDZhbC9KVisyYy9SL243cGMzRFA1QzRmczkyUHhwYXFMa0U0azdR?=
 =?utf-8?B?K1Q5UW5GOUNWcGlrbHRVOFJIMFUxZWtLc1p3dkpYS2xUdXZJd1VibGNicDRx?=
 =?utf-8?B?Ky9jS2F6UGVxQVROeStWdzQzcFdJdjN1bXp5R080NUprZkxFSUNqa3BLMVky?=
 =?utf-8?B?Rm1aV1ExSG4xUlJGTTVXUHJtbGVpazRjdEJuQzEzR0p2OEozbWdWVlhwSmEv?=
 =?utf-8?B?QkVvMmRIeUc3SnkwK01mMitLTUdydzNUd0NtSEhwQW5QQ2FXN2xTdGJvdC9E?=
 =?utf-8?B?RThQNXRLRHZOU3hLTjEranBwZ1FTb0VRQ1d1dEczQ3Vvb0t2c3QwallBVmUx?=
 =?utf-8?B?UUhIYWxHWmN5Z3huRVkzYkpnNDIxczc0UnpOVnFGcDlXY2IvZWV1NVJrV0dU?=
 =?utf-8?B?NjI0ZFBDZnF5QTFaK083WWwyNjRRZW8wZU9iRkVmTHdFL3JLTWh5MmgvVHdq?=
 =?utf-8?Q?iFavyZO/v7ALpx6RpvvCgttff?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	DzvF1/ctutQcOqp2mpLMddFVaWKB02cC1QY9X1Ee7wn+N9e4v/l7wd9bpfJXswGJwEhYdDnFKiYajoO+kIzQ/aHrJV0pLkbULivs263l8R8tkd7iRG7Pvr8p5NhoICEcYxYnX1B7ksnqhm4mverk2qSztTkBaFR7jdEhf9jdTZge1NojUTylFkKyQxJwcAuTv7WnIC0yhVgq6X0qnndx8zRa3s8OA6vJYOZztPAyL3R+BHFbn2PyV/O+M7IKnpTxYgB/fEmK/58ReoMs08CiZiKRWLIXa48ciFitsOI9QuTnoX/zNyGWKE4xj/RbbWjyDr0tKAlZpc2EHVeUlLeXjAJaflOIVMYAD/6eF47LaPg/4Xs8e2TikPRBnqDineHL8niqJbd1llPpzOO1SQmT2l2MctCF+kHr5zjtwLXyLlBTT76IbeXN4mXlkpiGfHpK+ZPJ+lxVA3nqu8k5QTuEgFs/67KTu2PlkA+UT4SlLt7oMRrcL91rhN9qpzdhc1tdRc5omPkZ+qlOPcf3YbSWEup5n4UqMdE3px+j1FgU7XaOc6FbQNRSJxhfbhCe2CKAGI4/ofAMsNzbEUdhDl4n7a+t9rlhjsNdmg1hvRI9Wtc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e83e3152-bc59-42b3-70f0-08dc382f2bde
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 07:30:43.2440
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: grHgM4QaH9gICXRCaAL1Coj52K+Ta90BZXgr8G8KJlkjlbVGyZAhM2YlQEwN/tiSYRGLcVQEaZ58ma5b9jfazA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6755
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-28_04,2024-02-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0
 spamscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402280057
X-Proofpoint-GUID: lMIdfnMGhTitj34wovhOvkZPmyK9WWWu
X-Proofpoint-ORIG-GUID: lMIdfnMGhTitj34wovhOvkZPmyK9WWWu


On 2/27/24 18:41, Sean Christopherson wrote:
> From: Isaku Yamahata <isaku.yamahata@intel.com>
> 
> Plumb the full 64-bit error code throughout the page fault handling code
> so that KVM can use the upper 32 bits, e.g. SNP's PFERR_GUEST_ENC_MASK
> will be used to determine whether or not a fault is private vs. shared.
> 
> Note, passing the 64-bit error code to FNAME(walk_addr)() does NOT change
> the behavior of permission_fault() when invoked in the page fault path, as
> KVM explicitly clears PFERR_IMPLICIT_ACCESS in kvm_mmu_page_fault().

May this lead to a WARN_ON_ONCE?

5843 int noinline kvm_mmu_page_fault(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa,
u64 error_code,
5844                        void *insn, int insn_len)
5845 {
.. ...
5856          */
5857         if (WARN_ON_ONCE(error_code & PFERR_IMPLICIT_ACCESS))
5858                 error_code &= ~PFERR_IMPLICIT_ACCESS;

> 
> Continue passing '0' from the async #PF worker, as guest_memfd() and thus

:s/guest_memfd()/guest_memfd/ ?

Dongli Zhang


> private memory doesn't support async page faults.
> 
> Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
> [mdr: drop references/changes on rebase, update commit message]
> Signed-off-by: Michael Roth <michael.roth@amd.com>
> [sean: drop truncation in call to FNAME(walk_addr)(), rewrite changelog]
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  arch/x86/kvm/mmu/mmu.c          | 3 +--
>  arch/x86/kvm/mmu/mmu_internal.h | 4 ++--
>  arch/x86/kvm/mmu/mmutrace.h     | 2 +-
>  3 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index e2fd74e06ff8..408969ac1291 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -5860,8 +5860,7 @@ int noinline kvm_mmu_page_fault(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa, u64 err
>  	}
>  
>  	if (r == RET_PF_INVALID) {
> -		r = kvm_mmu_do_page_fault(vcpu, cr2_or_gpa,
> -					  lower_32_bits(error_code), false,
> +		r = kvm_mmu_do_page_fault(vcpu, cr2_or_gpa, error_code, false,
>  					  &emulation_type);
>  		if (KVM_BUG_ON(r == RET_PF_INVALID, vcpu->kvm))
>  			return -EIO;
> diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h
> index 0eea6c5a824d..1fab1f2359b5 100644
> --- a/arch/x86/kvm/mmu/mmu_internal.h
> +++ b/arch/x86/kvm/mmu/mmu_internal.h
> @@ -190,7 +190,7 @@ static inline bool is_nx_huge_page_enabled(struct kvm *kvm)
>  struct kvm_page_fault {
>  	/* arguments to kvm_mmu_do_page_fault.  */
>  	const gpa_t addr;
> -	const u32 error_code;
> +	const u64 error_code;
>  	const bool prefetch;
>  
>  	/* Derived from error_code.  */
> @@ -288,7 +288,7 @@ static inline void kvm_mmu_prepare_memory_fault_exit(struct kvm_vcpu *vcpu,
>  }
>  
>  static inline int kvm_mmu_do_page_fault(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa,
> -					u32 err, bool prefetch, int *emulation_type)
> +					u64 err, bool prefetch, int *emulation_type)
>  {
>  	struct kvm_page_fault fault = {
>  		.addr = cr2_or_gpa,
> diff --git a/arch/x86/kvm/mmu/mmutrace.h b/arch/x86/kvm/mmu/mmutrace.h
> index ae86820cef69..195d98bc8de8 100644
> --- a/arch/x86/kvm/mmu/mmutrace.h
> +++ b/arch/x86/kvm/mmu/mmutrace.h
> @@ -260,7 +260,7 @@ TRACE_EVENT(
>  	TP_STRUCT__entry(
>  		__field(int, vcpu_id)
>  		__field(gpa_t, cr2_or_gpa)
> -		__field(u32, error_code)
> +		__field(u64, error_code)
>  		__field(u64 *, sptep)
>  		__field(u64, old_spte)
>  		__field(u64, new_spte)