Received-SPF: pass (google.com: domain of linux-kernel+bounces-84636-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Peng Fan <peng.fan@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>, Abel Vesa <abelvesa@kernel.org>, Michael Turquette
	<mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring
	<robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha
 Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team
	<kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>
CC: "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] dt-bindindgs: clock: support NXP i.MX95 BLK CTL
 module
Thread-Topic: [PATCH v2 1/2] dt-bindindgs: clock: support NXP i.MX95 BLK CTL
 module
Thread-Index: AQHaagfdonzElS9QB0ar9CNUieP0DLEfYCWAgAABgsA=
Date: Wed, 28 Feb 2024 07:54:17 +0000
Message-ID:
 <DU0PR04MB9417459448EDB8A674827DD588582@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240228-imx95-blk-ctl-v2-0-ffb7eefb6dcd@nxp.com>
 <20240228-imx95-blk-ctl-v2-1-ffb7eefb6dcd@nxp.com>
 <1ad77c33-71de-4bc8-a53e-1e74a5096079@linaro.org>
In-Reply-To: <1ad77c33-71de-4bc8-a53e-1e74a5096079@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?UmFNsrDZzDxtHBRB5XVF6mMI6XRtIFMgtGg99NHkiIYJuFvj50+QkH3Dhflc?=
 =?us-ascii?Q?CtBl3we25BZD4fd6S4+D/gsWoF03WGSeij30ofZ14RwZtvd8gi5EUAhddMTO?=
 =?us-ascii?Q?8SdRRApi04bj+jYXNAvOY1+Ro4EvGhUjLiBbQzUWo/mdiaP9O2fV2GPSPcBu?=
 =?us-ascii?Q?0MWvxK8EVbZAWJI+BEMnRvWf1TGMw2Mvb55xtQ+wmHo0uq/FrxbMkJlzULlS?=
 =?us-ascii?Q?mOhTXuMpy75ivwfRUp6vqgvdiyLnCV1MVgvAq+dN7YxLmYvvG9BsFeVVNKe5?=
 =?us-ascii?Q?Jgu0KprEWnavp671oGtDHn36D7umwdjzuwlbZu5iVxMygzFVbvCPRSSjZX8o?=
 =?us-ascii?Q?CXU2pZXBMiluk2lJk7WRdmr5Y6tG0iB7xh090QozfS6CyYenQDRvVa0HqNEV?=
 =?us-ascii?Q?MG7gyWBptwOwusdT/Nz1Q6WdafOo7D1yrw2KDNhYrR8M9f0CCbPRA2bzPiW0?=
 =?us-ascii?Q?sNlQRE3Xzjmh6ONdOcRdNhHFkkFCVj4hZX7yfh3rcAmmuJ7I+qvIdB3X958L?=
 =?us-ascii?Q?G4e8Sfr6RFZApDPJUL0NkNPoP1o8E3RfEovMyFQuthoK9/FmqyOowUx32s8i?=
 =?us-ascii?Q?NPUpgjuinhB6gwZQdD9/99b1KLpN3JnDkCRKamS9wjseNe4eBe3wSZ13Q6rV?=
 =?us-ascii?Q?GVXpbJrylAgHGY/WyFzsfmCVbYjN6sa4GfFuBDiCkh7wGuVmC2gv8BHZGMg6?=
 =?us-ascii?Q?3+ZAxyHUDwhB9fwtHcuM6hM/8UNcTtaLabAXZxUAm/H8KIFYajbK0ptADCWM?=
 =?us-ascii?Q?pBRW0xFpeoN18tLDqV7AUyvAgP/PYrGuXXpTfMyDS7ntx01s2LETDl8dbO+Y?=
 =?us-ascii?Q?MjoRwZ0p+2rHZ2n8iaromdL8eLtBT07JeAgcwnaGooXBsYudGr4JPbBPZfQz?=
 =?us-ascii?Q?d6HqIhvjSxeFp2z1IvGbbd3IqAcaKYY1nbiXSXC05sDB5AD8JbzIXx20rO6c?=
 =?us-ascii?Q?r+HNzSm62KBNgEjEEaos3PN5DJFrPnk7jfnsc4CPLhvTx20FTA+v4RcciVCG?=
 =?us-ascii?Q?BmXQJiJEv0iSyehZVD+i3ccWuRrqKP0p1PNvaNOrjxpdALgmE2Gu4W/VlXZQ?=
 =?us-ascii?Q?uQBFvmwo3HZNPaQZY0JstQyQm/Lyol/jv2FWoHPSBXDME3CJUCvUQmeemJHi?=
 =?us-ascii?Q?Vn/CpG889DFZv26IdEBPKfbgpBEHxGmDGiFATa65VzDEX15Z8eIg9ssKI2Jr?=
 =?us-ascii?Q?n/ioTxFegvXJ1ys9cno3G+nPs+M99xWCRvXPfNjPjWqWIpO07Nyv3Wx+TMP3?=
 =?us-ascii?Q?aWapLTOHioMRZPsyn/cTmZBerQj1tgEveiAwY2QTFRbY0EGuShjTRrEmYLRk?=
 =?us-ascii?Q?F2C65OOfjCv3QLn4z8ejqJD+c6fmKr1wXrAJzLM4/vUZppfhpdufhF7+9Fqx?=
 =?us-ascii?Q?Z4TWxOpvWhklkgcnB5og0XsRn/nW1THcv7NSG0vI7qMpydztxAKqxV5D5vyf?=
 =?us-ascii?Q?5TaW8jMT0dX2WTHYGbslPGQUJNh8sWr521S4bu5wGH1p05xWhWtzYyeuIfhm?=
 =?us-ascii?Q?GX6zt2oJX9UG134qqDNn1cAR0h/y2oWmDmLOnsbeXbPgGCN01CFD/9VylaI0?=
 =?us-ascii?Q?8Bwl8KLamd/P1SdL1sU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 378e3b2f-ec97-44d0-cdc6-08dc383276ec
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2024 07:54:17.4155
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wIKRtsED47Ib18US8PE3k4unkNy6I7lHFZZ8EcWJgwp3h6MSc3lUdND9QasNhXhQkiJFmm0zjjBr/NK64PqdcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9885

> Subject: Re: [PATCH v2 1/2] dt-bindindgs: clock: support NXP i.MX95 BLK C=
TL
> module
>=20
> On 28/02/2024 06:43, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > i.MX95 includes BLK CTL module in several MIXes, such as VPU_CSR in
> > VPUMIX, BLK_CTRL_NETCMIX in NETCMIX, CAMERA_CSR in CAMERAMIX
> and etc.
> >
> > The BLK CTL module is used for various settings of a specific MIX,
> > such as clock, QoS and etc.
> >
> > This patch is to add some BLK CTL modules that has clock features.
>=20
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory yo=
ur
> patch is touching.
>=20
> There are some typos, so you miss my filters...

Ah.. ok, will check more. Please ignore V3.

>=20
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/clock/imx95-blk-ctl.yaml   | 61
> ++++++++++++++++++++++
> >  include/dt-bindings/clock/nxp,imx95-clock.h        | 32 ++++++++++++
> >  2 files changed, 93 insertions(+)
> >

[....]
>=20
> Filename like compatible. We talked about this.

ok, will use nxp,imx95-blk-ctl.yaml.
>=20
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdev=
i
> > +cetree.org%2Fmeta-
> schemas%2Fcore.yaml%23&data=3D05%7C02%7Cpeng.fan%40nx
> >
> +p.com%7Ca6ed8c5ca4a745204f0e08dc38313f37%7C686ea1d3bc2b4c6fa9
> 2cd99c5c
> >
> +301635%7C0%7C0%7C638447031362290549%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoiM
> >
> +C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7
> C%7C%7
> >
> +C&sdata=3DDWrWMkSOrl%2FfCdEf%2BcTFjunNM66q3hHkPFGCzk1%2FsHo%3
> D&reserved
> > +=3D0
> > +
> > +title: NXP i.MX95 Block Control
> > +
> > +maintainers:
> > +  - Peng Fan <peng.fan@nxp.com>
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - nxp,imx95-cameramix-csr
> > +          - nxp,imx95-display-master-csr
> > +          - nxp,imx95-dispmix-lvds-csr
> > +          - nxp,imx95-dispmix-csr
> > +          - nxp,imx95-netcmix-blk-ctrl
> > +          - nxp,imx95-vpumix-csr
> > +      - const: syscon
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  power-domains:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  '#clock-cells':
> > +    const: 1
> > +    description:
> > +      The clock consumer should specify the desired clock by having th=
e
> clock
> > +      ID in its "clocks" phandle cell. See
> > +      include/dt-bindings/clock/nxp,imx95-clock.h
> > +
> > +  mux-controller:
> > +    type: object
> > +    $ref: /schemas/mux/reg-mux.yaml
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - '#clock-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  # Clock Control Module node:
> > +  - |
> > +    #include <dt-bindings/clock/nxp,imx95-clock.h>
> > +
> > +    syscon@4c410000 {
> > +      compatible =3D "fsl,imx95-vpumix-csr", "syscon";
> > +      reg =3D <0x4c410000 0x10000>;
> > +      #clock-cells =3D <1>;
>=20
> Incomplete example. Add here mux controller and power domains.

ok. But since the power is managed by SCMI FW, and no
header such as nxp,imx95-power.h, so I will use the number,
such as <&scmi_devpd 0x5>.

Thanks,
Peng.
>=20
>=20
> Best regards,
> Krzysztof