Received-SPF: pass (google.com: domain of linux-kernel+bounces-84660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: "Wu, Wentong" <wentong.wu@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
CC: Hans de Goede <hdegoede@redhat.com>, "Winkler, Tomas"
	<tomas.winkler@intel.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] mei: vsc: Call wake_up() in the threaded IRQ
 handler
Thread-Topic: [PATCH v2 1/3] mei: vsc: Call wake_up() in the threaded IRQ
 handler
Thread-Index: AQHaY24BYYe2VBw7MEGkR20e9s7pwrEfdnRA
Date: Wed, 28 Feb 2024 08:19:04 +0000
Message-ID: <MW5PR11MB5787E314C6DDA3D37FC1992F8D582@MW5PR11MB5787.namprd11.prod.outlook.com>
References: <20240219195807.517742-1-sakari.ailus@linux.intel.com>
 <20240219195807.517742-2-sakari.ailus@linux.intel.com>
In-Reply-To: <20240219195807.517742-2-sakari.ailus@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ogUtpj8tc7/Eck7cjLwtFsOtZLZ9P2AGXNVqn5XiMdAEbFHjOE/8AM6BudT9?=
 =?us-ascii?Q?9YVWTSga5bPKnHlN0KTmGnhbCeDFL7HlOuDHoxeg85pBQ6dvjISw8wv11YOh?=
 =?us-ascii?Q?eK86IXOI3BFsJDBKg707p4UD0RI6uhco36kFsNjj5Jp8ljIo6A/z7wFml/kq?=
 =?us-ascii?Q?VIIBeSVb2uXIEfK4FvFR2+zXBlTQTWvmO33kAYx9fgliNR2nYws8UuzMDikI?=
 =?us-ascii?Q?xMUI8RG8n5ohfx9a/0qYBp+3aCihz6KKmH7tNiKBEcD6NdVve97FlmcSWWKO?=
 =?us-ascii?Q?bf8QuyjThlJlKYYe/IRRms2IBA87HDxDHiwVUgMh1oihMs7dX/QQPCpiYrqi?=
 =?us-ascii?Q?FzkO5sf+dkC2ve5UveByAJ9jpsyKqfiow6OU4Ilpd3Nfja9fdQhszrpnVP4X?=
 =?us-ascii?Q?L+fRahG/n3OzHzGT5xAGba1u8q+JYefEXdKTF/cTbMpa9MKn7pKUIhg6T7Fq?=
 =?us-ascii?Q?px9CY8H7D8ebFKoBJVcUGTo4FsKUd4FReocvT6dkT+O2ArTjvnoSZrd3UzJa?=
 =?us-ascii?Q?g17qXeNVp9zzH4ni2Rc1ICotvx6PDmxmE57jE8wPihqhdsd5u8SBjCUrqTS6?=
 =?us-ascii?Q?O4pgivcd3srVRfDkgyhpgtzUh8ksu+v+FayeLLfQcSsVH/ZYVDGCxO1I1fmt?=
 =?us-ascii?Q?dg7Jifs6BbGC1oPutBPuU245PzaXckHNulqV+JkbmC/Z7liXj9jEfimtPWyx?=
 =?us-ascii?Q?3fY4IdIlB3rFkZKXPs1YOjrtBQI+bnIGOD7s54HydLbfz+jXI0urcLjQevm7?=
 =?us-ascii?Q?wacXtLL3+F5rh72wLxrUylcZAO7nvOxcX651ACJaQD9rBZokyTCuxuPrVgHH?=
 =?us-ascii?Q?iOZXKLb/u0UEQ1MhctpdghPIqkc3dDT0A1X0X/MyOlyqjhLW90/HWPWlIjFi?=
 =?us-ascii?Q?Y4TCOYoG4HD3mzHGBjVQDtvkOTDU9hfznmNAArjiTLNUrL03E/TtL/ImTwE6?=
 =?us-ascii?Q?9lMqWKaDarptjjxNXU3tCcxXtWaYbZRV7U9zyBJJKNwE2B74M/0rflDyzjKu?=
 =?us-ascii?Q?3PTl2KtQSB2pSrCPiRgiRGl3lY+ONeyXjqfJvNHrO2jhKmEj3ezWaFLaKZ+D?=
 =?us-ascii?Q?iwlqzs5Di0yWumeqeOhAwKujxfyO+/i7R/J0LwBuGfmNTymy2fulZwFojwXy?=
 =?us-ascii?Q?6flChJSZwI8hg8fbYtenBjtXLxTxXZDHSAYbrUDieQrP3+5jdBdTKi/mzTyz?=
 =?us-ascii?Q?z1eidY2rASjv/Iz5S8ezvSwDx1zXDh3yHF0o2e6OdQcScaS5UHInxKXKo/bx?=
 =?us-ascii?Q?UWfi1/DyfDZJlnEvRHfvQ2KocK3BmGbgEkQv1Wn2+92xzOCzmAETNdLPh8ej?=
 =?us-ascii?Q?+F+FxQLk/8/HslGmobSNHqs9qyMuaxymi/m4EkLyF6VVdaC0Q3yB2tgM2N4W?=
 =?us-ascii?Q?5+NRA4+99hR3QBMuFhPOR0gRAUeqYXdyhUDlNGyOdiaZgb/ziaybVdlyIdlf?=
 =?us-ascii?Q?Dp7DbH5KpVMG1vVhBL5lPlxw25M0J6P0AZyjquj4IL/UTgTsmDPzonZb5J1J?=
 =?us-ascii?Q?QCOYTco0ovATPuO+OBEVX9zaKgZyNU0Ga2QVVhPZoENzqwRQh3YwriQCKfFF?=
 =?us-ascii?Q?OuRx+yU9z/hGaX0P3lsXIiNYQnSf8YppZR3DMEHK?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5787.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e22f91a6-0f9c-4d77-2cef-08dc3835ed10
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2024 08:19:04.1097
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +tnvmbkaOvXWfQs4e1SU3Ui/6ver/NYnG2MbTt5THvX+NZY1PhwPkLnjmhsLwzjk6tj3EjneXO7rB+juDLxkQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8765
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Sakari Ailus <sakari.ailus@linux.intel.com>
>
> The hard IRQ handler vsc_tp_irq() is called with a raw spinlock taken.
> wake_up() acquires a spinlock, a sleeping lock on PREEMPT_RT. This leads =
to
> sleeping in atomic context.
>=20
> Move the wake_up() call to the threaded IRQ handler vsc_tp_thread_isr()
> where it can be safely called.
>=20
> Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Tested-and-Reviewed-by: Wentong Wu <wentong.wu@intel.com>
> ---
>  drivers/misc/mei/vsc-tp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index
> 6f4a4be6ccb5..2b69ada9349e 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -416,8 +416,6 @@ static irqreturn_t vsc_tp_isr(int irq, void *data)
>=20
>  	atomic_inc(&tp->assert_cnt);
>=20
> -	wake_up(&tp->xfer_wait);
> -
>  	return IRQ_WAKE_THREAD;
>  }
>=20
> @@ -425,6 +423,8 @@ static irqreturn_t vsc_tp_thread_isr(int irq, void
> *data)  {
>  	struct vsc_tp *tp =3D data;
>=20
> +	wake_up(&tp->xfer_wait);
> +
>  	if (tp->event_notify)
>  		tp->event_notify(tp->event_notify_context);
>=20
> --
> 2.39.2