Received-SPF: pass (google.com: domain of linux-kernel+bounces-84711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <faf10b63-346a-4903-9671-1d685896d815@intel.com>
Date: Wed, 28 Feb 2024 09:56:43 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add an extra entry for the
 Chuwi Vi8 tablet The bios version can differ depending if it is a dual-boot
 variant of the tablet. Therefore another DMI match is required
To: =?UTF-8?Q?Alban_Boy=C3=A9?= <alban.boye@protonmail.com>,
	<pierre-louis.bossart@linux.intel.com>, <broonie@kernel.org>,
	<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240227222540.11223-1-alban.boye@protonmail.com>
Content-Language: en-US
From: Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20240227222540.11223-1-alban.boye@protonmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXBFY1JrWm45Z1pFM09iRThuNjFlaGZiWWNlMUxIc3h6WkMvTCtBY3QvT1kw?=
 =?utf-8?B?UGxYcUVteWN2eXdUS3pLZSt1YTMycm11eXF2QmV3eklVdXZocytscmc5UGJD?=
 =?utf-8?B?bXRKQUpYQjhsS0tHRURWNkZtclBrY25PajV6VlR3ZVQzc3E2Sm5ZbXUyR0Zz?=
 =?utf-8?B?YmFOYUY5WjZTVDdReXJtNXVtS2ZicWFaVGxqMmZCKzBhakx6VUMxYXkvME5q?=
 =?utf-8?B?U3FuUzdVcWRNTGpFcnVrTkMvTXBmN3M5Mjl4N3JsdTNYYlA1ZlQvVHZSUnMw?=
 =?utf-8?B?dXByemowcDA3cWZiaGdFcm1MdlEvNWViSUV4Vko1US9xMVRJVTg2UTA5N01s?=
 =?utf-8?B?TVROWHpVclA0bGVPMTgyK29tVDk1ZldjVklQd0hZc1pKZW4vMjJJaStPdXda?=
 =?utf-8?B?SkNRRm42cVBUTG9PQWsxWjFvUTltMGM2Z2ZPZm1hcnFFNGhHenNXekkzTEkv?=
 =?utf-8?B?V2RRMyt5R0x3eWFSREF5WmVSSmlOWkRGTFZVWHpIRXFRayszbHhkVERtNTE3?=
 =?utf-8?B?Ly9xdWhqZlZVV2tDcHVCOE9uckMyZFhDVzhnSElxVUU2MUhHU1hDS1NONkdZ?=
 =?utf-8?B?RXBJaTFlVXYwRTFqMjlDdWRCS1RadE5Ud2FrQjFnV0g1c0pCbEhkTEd3RWV2?=
 =?utf-8?B?czZPS3QvRWZWUTNja04rV0owUzh3eTB6VFRldTMxeDJuZWpkeFRUNUNjeE1F?=
 =?utf-8?B?NjRzZ0RpZFp6eXoycG5SYm5hSUhtU21aVzlWSmhVNXlpamtTQlNsVk1Gb1Qr?=
 =?utf-8?B?VjlXN0k4Vnp5TUlLQ0pWQ1FTVFNSaStzYmxBR0tnUnB2eG80cXlkUHEzVG1q?=
 =?utf-8?B?azMyWXdLdkpHWk1xYkU3QXpTeTNEQWowUzBlZFRQZGpqVTV6M1pWTzhMcklE?=
 =?utf-8?B?VG83a0JQUWQ5WVdRcHRaNmtlSG1TRU0zZEdMVXBZK0xuQXNTeHZDUWhKOEpt?=
 =?utf-8?B?TzBqVzY1U3htMWJjUFlFMDVTUmVkQTcrZlpKY3BOd3hJZEMyeVNlRU9xTDNj?=
 =?utf-8?B?OXJGZzVYcU8xYjNoU3BRL3h1Mk9MdCsrc1FTWjdFY2EyQTk4M0FIeGJhWmJC?=
 =?utf-8?B?dHg3SXRMWVd1V0dHOHRza3QzazFybW8wYzJQcTMrRHBDN0RKck0rWE5VZ1Jk?=
 =?utf-8?B?U1JsMWZmWnNGNm14VDlmVE9iRWZ3UkVlYzl6dHphVmdvMDRDUi9Nd2Q5YkZD?=
 =?utf-8?B?bm5mbzRLOVl4MEFXS2ovOTNsY3BVQXRSRTNlS245RTZDdVpXTHJYcG9mSjNN?=
 =?utf-8?B?M1h4RFhFWmhsR1oxSml5N0NxZm05Q3hkZ08xcnpteUs4MmdMeXRPT0hzQkIy?=
 =?utf-8?B?MTcyZzFQS0NzNDNHaGphTThzNTZCYmVFOXF4S1c0aUQvRkRaZFlHSmJ3T1Zv?=
 =?utf-8?B?M3ZhMkd3T3kySW5hRkEycGZmMWF2Sk9ibEVYRmUzak9yd0QxaVRvcWNUdHdu?=
 =?utf-8?B?ZUp2NWl2N3pxVUhwc0laa01HVVZVbVgxTTdZNHZDbytvRS80K1ZUQ1h0R0Jk?=
 =?utf-8?B?Z2dIa0JNb2lieHdKaHhFRjNJeUwwY2NPS21FNTlvdWl4VkdFNnBWdEo3OThO?=
 =?utf-8?B?R2thTmpZdUQ3NTBRaVNETmZBZDNqNE52YTBNVUhPVFJHb3VhaTh4ODQrT21N?=
 =?utf-8?B?OHhaMkltTHd2bEdNZnlQWHZyUk5RM1dCYi9QdzNvM0ZaNVZ5TXowQ29wblVz?=
 =?utf-8?B?Q2JUcXpRVVZUTHNxYmxyYzVCN3NzajhES2p0MWRmMC81QlZNbFczaFFWeGti?=
 =?utf-8?B?QW1kLzZEemhCWUZpbHA5YlpBV0RtTm41amE0alBwWERZMk9MeTl4TDdsN2FO?=
 =?utf-8?B?NGFXS3dOdm5CaFNBYTkyeEVNd2ROSDZoR0hBUmtXSUI2OFBGV3F5dUpmK3Nq?=
 =?utf-8?B?aTI5MnlNek9JZlRQS0dNQVJnUWg5c0dBZ2c1TStuNWppY00ySVp2SW9BTXdu?=
 =?utf-8?B?Z215R2pWbGVGRmNIRUVXMkloZ2l4Wm1DMjNGRFN3c3BPMjdnVVpvbyt5NERQ?=
 =?utf-8?B?d2F6Snh4T014amJacWpZYnFORkU3Mk1YRmhRd3E2eTZ2T0NHK2pCbU02K1B0?=
 =?utf-8?B?Q2VVSWdWZU91Y05saUxmVE5ZYUowNkllTStsaVdkL28xVSt6clduTjAxSzg0?=
 =?utf-8?B?R0ZuUFhSZ1ZSSitwSUJMRXpHWGJFbVZXSjZ5UDFIZFJYTko0cmdRMWkxTEdD?=
 =?utf-8?B?TUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 47d2ff64-a1de-4df3-2a9e-08dc383b320a
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6365.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 08:56:47.4415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AOc43ZvcwlFR8sCIs8KBPNSId3nfrFpHCj+TGKudjzTNM62juARLD6r8P3BaT21pqZ5W5nguwMKTX3lm5DCJ4sIIVjDYCpxnL3yQaXV077g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5057
X-OriginatorOrg: intel.com

On 2024-02-27 11:25 PM, Alban Boyé wrote:
> Signed-off-by: Alban Boyé <alban.boye@protonmail.com>

I believe commit title and message became one. Please split them up and 
resend your patch.

Whenever sending updates, increment the patch revision. What I'm reading 
right now is in fact "PATCH v2" given you've added Signed-off tag after 
Mark's review. The follow up should read: PATCH v3.

> ---
>   sound/soc/intel/boards/bytcr_rt5640.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 03be5e26ec4a..05f38d1f7d82 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -685,6 +685,18 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>   					BYT_RT5640_SSP0_AIF1 |
>   					BYT_RT5640_MCLK_EN),
>   	},
> +	{	/* Chuwi Vi8 dual-boot (CWI506) */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Insyde"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "i86"),
> +			/* The above are too generic, also match BIOS info */
> +			DMI_MATCH(DMI_BIOS_VERSION, "CHUWI2.D86JHBNR02"),
> +		},
> +		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
> +					BYT_RT5640_MONO_SPEAKER |
> +					BYT_RT5640_SSP0_AIF1 |
> +					BYT_RT5640_MCLK_EN),
> +	},
>   	{
>   		/* Chuwi Vi10 (CWI505) */
>   		.matches = {