Received-SPF: pass (google.com: domain of linux-kernel+bounces-84788-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d2a988e3-892d-4dd8-b75f-96d76c89ee6b@bytedance.com>
Date: Wed, 28 Feb 2024 17:45:01 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm/zsmalloc: move get_zspage_lockless into #ifdef
Content-Language: en-US
To: Arnd Bergmann <arnd@kernel.org>, Minchan Kim <minchan@kernel.org>,
 Sergey Senozhatsky <senozhatsky@chromium.org>,
 Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Nhat Pham <nphamcs@gmail.com>,
 Domenico Cerasuolo <cerasuolodomenico@gmail.com>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org
References: <20240228094036.2267912-1-arnd@kernel.org>
From: Chengming Zhou <zhouchengming@bytedance.com>
In-Reply-To: <20240228094036.2267912-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2024/2/28 17:40, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> It's only used from inside of an #ifdef section, causing a warning otherwise:
> 
> mm/zsmalloc.c:735:23: error: unused function 'get_zspage_lockless' [-Werror,-Wunused-function]
>   735 | static struct zspage *get_zspage_lockless(struct page *page)
>       |                       ^~~~~~~~~~~~~~~~~~~
> 
> Move it down into that block to avoid adding another #ifdef.
> 
> Fixes: 2258bdebb55e ("mm/zsmalloc: don't hold locks of all pages when free_zspage()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Hello Arnd,

Thanks for your fix! But this series has problem and should be removed by Andrew later[1][2].

[1] https://lore.kernel.org/all/20240228043534.GG11972@google.com/
[2] https://lore.kernel.org/all/20240228035403.GE11972@google.com/

Thanks!