Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758300AbYABWwp (ORCPT ); Wed, 2 Jan 2008 17:52:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754592AbYABWwh (ORCPT ); Wed, 2 Jan 2008 17:52:37 -0500 Received: from waste.org ([66.93.16.53]:39117 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754118AbYABWwg (ORCPT ); Wed, 2 Jan 2008 17:52:36 -0500 Subject: Re: [PATCH] procfs: provide slub's /proc/slabinfo From: Matt Mackall To: Linus Torvalds Cc: Pekka Enberg , Hugh Dickins , Ingo Molnar , Andi Kleen , Christoph Lameter , Peter Zijlstra , Linux Kernel Mailing List In-Reply-To: References: <84144f020801021109v78e06c6k10d26af0e330fc85@mail.gmail.com> Content-Type: text/plain Date: Wed, 02 Jan 2008 16:50:18 -0600 Message-Id: <1199314218.4497.109.camel@cinder.waste.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1345 Lines: 34 On Wed, 2008-01-02 at 11:35 -0800, Linus Torvalds wrote: > > On Wed, 2 Jan 2008, Pekka Enberg wrote: > > > > I already sent the remaining bits to Linus but this looks much > > cleaner. Thanks Hugh! > > > > Acked-by: Pekka Enberg > > Actually, I'd much rather just do this instead (on top of your patch) > > It just creates a new CONFIG_SLABINFO that automatically has the right > dependencies (ie depends on PROC being on, and either SLAB or SLUB), and > then both SLAB and SLUB just have the exact same interfaces. > > Which means that SLOB could also trivially implement the same thing, with > no new #ifdef'fery or other crud. Except SLOB's emulation of slabs is so thin, it doesn't have the relevant information. We have a very small struct kmem_cache, which I suppose could contain a counter. But we don't have anything like the kmalloc slabs, so you'd only be getting half the picture anyway. The output of slabtop would simply be misleading because there are no underlying "slabs" in the first place. -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/