Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2446742rbb; Wed, 28 Feb 2024 01:58:30 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUBXCfjlGuBOhY87rQMg9Dzo9KiWf97Dt5+FMNSwOzSPl8KtoONXkpG4I+whytKoQIsvrPcmO05Ag/oDszuoD37KzkVbLzbUdHPROCa5Q== X-Google-Smtp-Source: AGHT+IEEQYvU7eHz8G1UUp8V6N4JnlYuK2ZH7j1mICRGwPypg8dzRChJhsJ8M/s4pt02RslhQPQm X-Received: by 2002:a17:907:1115:b0:a3d:bb58:bb2e with SMTP id qu21-20020a170907111500b00a3dbb58bb2emr8567847ejb.36.1709114310562; Wed, 28 Feb 2024 01:58:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709114310; cv=pass; d=google.com; s=arc-20160816; b=Yg/Ac4bgT1LCVGyKe7dpw7uGE3OXaKN3zffL/RqyqFc0Yy3che2ELlQL7CK+HSLhQf /Ps78CWoBpyjxrivanytyhz7/9v+gX/rMxcw6d8amU+GHmr08NioEQ/7WzuPltITW1kj 3aQ4S/ycduHvuEzRvVs08v8PxzUTt+lfHrAL89NdKnjiV04YB7wIRjt8glVUb6OpTLme GUOzqTc9ORmLc/dB2pK93XK2eeCA16SNQGzXNKqrEy/uqyjrcSlGAIveIfCjmrs9L5sv VIwZCmTxbs9L93VEFb7emWaD/89FVmONheqSHp0AfBXIhz96n9Gtbs2XgDU40PvDfc8P JF3g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=W+3QsX0HHeSUD5lWMhESk/zPMXGbCqeoiUeL3QgQygQ=; fh=ucD0yDUQK4vkOjaD7gGMeT6G/Uk5SnXQjlHJp9K/X74=; b=b5odY6JQuJoYIl+nFOklpHUcjYeZ2x3GvX1j5Ce9nrHGgwKu9mjah1Jt1CcVMvcK31 rh1uzCP1QQrQPuHNfgjawtqUCnfZTPdw2SC2kQfa0H65SIJF0RACDPJrl+o/SjxIBwuL vWew7SK2C4bQV4qqEetKTvwBlmC4E6eiiNXZk8SqJY/vG4dK8yvjrk3pui86i2dAMdNS Q71wFmTT+5RwLxeVk1y0WQnDvV7yP9Sq+YRd+cz8zLflplZ1wAAghvKyJdwmADP1BKmP GN6EmMwbUbBngvRT7WMxAPSDnyA/+1r1OP7zeYztjpwIVUHiaXwBPqtyGpSa11v5gIfi 5WrA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=WvgoDo1t; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-84802-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84802-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v14-20020a1709061dce00b00a438b7a24e9si1524801ejh.707.2024.02.28.01.58.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 01:58:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84802-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=WvgoDo1t; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-84802-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84802-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4F74C1F22046 for ; Wed, 28 Feb 2024 09:58:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3FB4C37171; Wed, 28 Feb 2024 09:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="WvgoDo1t" Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CD96364A0; Wed, 28 Feb 2024 09:58:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709114286; cv=none; b=TdivwdPNqdg+10ER5qDNEP3VWwU+9Gj0u8ShmYKwbdJ2KA8EFqzGxTr8UIuILCiEechzKdsHS41Jb9aSyAsRRUckI8+kqMszIW0dgqTW7OkqwC1wa8kUzSIqESyMZip6CL2kA+G7Uo+oY5aHeO2eqdb9lceVnUKHfjQnp3tEAMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709114286; c=relaxed/simple; bh=VLnw7CFtD6tkLMRTwnOleArMwXHH7DdQHAUw3/q5log=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b5iqoZhiu0d83/Ji1rdyo19zii5jbstg6j3f3ejI8uwog5cd2n+BhGrcpNMqm5JBF/J4nptp31wr4sqGivSX6dSuzGHi//ZEJEvqkwO/exp9qLYR6wfwnccJviAWG7UFxJpcyi8VSGf5KSRTs4EmbFbautkioDHY/oWRB/sZg5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=WvgoDo1t; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 710CCFF809; Wed, 28 Feb 2024 09:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709114282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W+3QsX0HHeSUD5lWMhESk/zPMXGbCqeoiUeL3QgQygQ=; b=WvgoDo1t4zzKfbfna022CiqaJ/MT7QH2lgX24nyvkTfQukuLwPkAWCrRWi0H97DvTv8nA5 UJJy5h+Q3Zsq34fV4jh72TCEr/JHS/Nnxf0J47m3dXuLU2cxw+qnaE4kA2F7hInf0WHqKs NSzQxMQVhhifq8Uk1n7wr7rYbx+ZmFMtjwSEC0ZUeJzVyE61ezUetze8Ts8DVMRGD4oYxG L7SyY4WFL6pNYMjtDe1+255Q2468FU6Xx4mCNYBWshU5LFGBc5+g/zdqPhgcN/biu+F322 uhI1PyhBNzZEOjqUYwZPf4tVPjhYF5yTfvT+oSI7EIpNc0z9YIDVvatczth+mg== From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , Florian Fainelli , Heiner Kallweit , Jonathan Corbet Subject: [PATCH net-next v2 2/2] net: phylink: clean the pcs_get_state documentation Date: Wed, 28 Feb 2024 10:57:54 +0100 Message-ID: <20240228095755.1499577-3-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240228095755.1499577-1-maxime.chevallier@bootlin.com> References: <20240228095755.1499577-1-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Sasl: maxime.chevallier@bootlin.com commit 4d72c3bb60dd ("net: phylink: strip out pre-March 2020 legacy code") dropped the mac_pcs_get_state ops in phylink_mac_ops in favor of dedicated PCS operation pcs_get_state. However, the documentation for the pcs_get_state ops was incorrectly converted and now self-references. Drop the extra comment. Signed-off-by: Maxime Chevallier --- include/linux/phylink.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/phylink.h b/include/linux/phylink.h index 6ba411732a0d..9a57deefcb07 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -480,9 +480,6 @@ void pcs_disable(struct phylink_pcs *pcs); * negotiation completion state in @state->an_complete, and link up state * in @state->link. If possible, @state->lp_advertising should also be * populated. - * - * When present, this overrides pcs_get_state() in &struct - * phylink_pcs_ops. */ void pcs_get_state(struct phylink_pcs *pcs, struct phylink_link_state *state); -- 2.43.2