Received-SPF: pass (google.com: domain of linux-kernel+bounces-84803-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <501f7f57-99e6-4826-833c-b8414ebe8176@intel.com>
Date: Wed, 28 Feb 2024 10:58:56 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 1/2] net: phy: micrel: lan8814 led errata
Content-Language: en-US
To: Horatiu Vultur <horatiu.vultur@microchip.com>, <andrew@lunn.ch>,
	<hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<UNGLinuxDriver@microchip.com>
References: <20240228062813.1007138-1-horatiu.vultur@microchip.com>
 <20240228062813.1007138-2-horatiu.vultur@microchip.com>
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240228062813.1007138-2-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tk5tbWsyMXVhbGgxcWRwclMzYUY4S1lyWWFUNThuRHVCUEJlNFEwaWRGS2Q4?=
 =?utf-8?B?UU92Z1k2R0ZGTTljVGpOZEpJemZiYSttUVYxR0FvcmJSUUJEV1d3ZEVhVVBI?=
 =?utf-8?B?MVJtQktNSUVyV0NaNnIxYnVWc0UvcElvMnpCTFVOVDdyU2FybjBTUEE1N21m?=
 =?utf-8?B?YkVzQk82TUVtR2doSW1VU243bUJ6bW1xYXpJZ0lkaElhVkJYdFhpN2dFcVpk?=
 =?utf-8?B?V2ZacWZrei9Jd2o0N2k4ZnppK1VJNUVUdjRNdTJUQk92Tk5DdVNtekVhZXhu?=
 =?utf-8?B?WktoeUppdnk5K3dZemtUblQrN2t3a3M5M0JHeFZmdmZpY0w5UnhUMmRwS2g4?=
 =?utf-8?B?UFh4VVhGOGMrM1JVdnNYYzhQNUlBcTd4UnRISGdRUEhrU2FYbWtiQitxZnBY?=
 =?utf-8?B?RVhIYTcvL1B0YitUQmJrWVZoeVRqSkRZTDRUYzJxR05DRUxQcXA5Y1BUL1Rk?=
 =?utf-8?B?dWtuZSt6ZDVwQStMSzd5WnNuc3ZaNGYrL3dZZHZ4ZU9TVG9vc0cwUUZHTFBY?=
 =?utf-8?B?N0Q5czBDZ1RwVTgrZ0VHV1QyeWRoYUpDRk5jK0Ztb0p2QWlwcjQ3aWFRb2Zm?=
 =?utf-8?B?SHlORENyT0I2blZTanczalJselpNY1gxS3I1T1VQK21Zc0pkUGtoczNIazhQ?=
 =?utf-8?B?RCtFMmJhWDUwQ0N6WWZ6MjQwTlpSOXZDMVRPMFFOcTNkc0JBSG9hQmpVTHhu?=
 =?utf-8?B?OW9oUUNlUDBkWWFTeEhQblFTWU5EcitwRXJ1VzBYTUNCVWhmQjMrQW5ZZFhm?=
 =?utf-8?B?Z0dMbS9JYmYvZUduZEF1NTRudm1YQU5QMmx4SmFpYjRIY3FtWVdTeHR3dXdz?=
 =?utf-8?B?bmZBMjhzSXdPbThQbWZPTGhWV3ljSzEzeHg0dFZVcjFyZWxMRm9rVWN5QnNP?=
 =?utf-8?B?TC9BcWZqekpxUnZCVDU2aTZ3bmlNZGp1QUJGcVYzQ25qcHJRdDAxZVpwcW8w?=
 =?utf-8?B?U0wzdXlOaSt6Vys5eC9nSFI3eXVxL0hwZ0hITVNZQm5YaExXMjQveGhWZVZ2?=
 =?utf-8?B?eUVzNXJpTWdFV0JWaHpGUkhDQlFxdlcra2ZxMDZvbUg2UHdTV2NBa21qa0Yv?=
 =?utf-8?B?YzZvSkFFNWUyck1JZXYwd043dWRZTTQ3cjJaeTcrQmpXUDNlNm9pMUsvUldq?=
 =?utf-8?B?bUhrK0d6dENETk96RG5QZ2xWbm5sWlJDQSs4ejBTenRLL1lXeXk4dTYzTDhm?=
 =?utf-8?B?YTFVV3ZxK2VOdStCV2pKMm55bC9oa0JKY0R6eFFFMzdzdGJsV1dpRzB4dHU3?=
 =?utf-8?B?UkJub3IxZHlUa0xpbkdhMjF1OGxJMEhyWmxjR1F4QytRWkE0NTNreVNkb0Ix?=
 =?utf-8?B?bXdYUEV6MWdYcHFUSSs4UUU3WFlVeWFXVm4vSWRCMkV4akE1S3JLaEJDNjV3?=
 =?utf-8?B?S21ieEluZkdqMjdzU1J4WFkxbTd5M2FMa083VG1lTGxhTktDOUVwemFiNHZ5?=
 =?utf-8?B?MmN6cFZ6cEJiKzdDYWU0Snd5dWs5WTFmV0tnRHBlZWJMbDZCMk5CUWxqK05J?=
 =?utf-8?B?YytJd3Eya2ZkOUFETlVuZElYYnpGVEc2UTBGT2RHeXAvSFNiNmxSL3g2MUxz?=
 =?utf-8?B?TmN6R1N5WVVkVjRJWTJtRUVaZUE3ajZLNUNJbnA0UTBqNzdkamI1MjhKd1NM?=
 =?utf-8?B?ZVFlMjB2cEY0dG9PeVEzSWUyKy9WY2tla1NrSkxFb0FXVWxxZU1kOXkweEcw?=
 =?utf-8?B?N0dRMStqNGxqVUxvZW9PSHFNU3Z3T0tuU2JQUnNoSlBVRWMza3hkSG9BM0Iz?=
 =?utf-8?B?cTRvZkQ1K0hNVjQrTTRXM1FWSEdtSnJIQkp6M24xT1A5NnRrS3ZGc0UzamJB?=
 =?utf-8?B?ZGp2SmszSVF3N1RyWEdJczRnOWVuekh6bE5aVlAzTFR0ZUJ6OWpnTWYyaGlj?=
 =?utf-8?B?aWxpZkZvbHBXQUVrNEtrL1VqVFh2VFYxMmZLL1FGSG16YzZ4T3plTmJaOWdK?=
 =?utf-8?B?aGIxQkhFOEw2MUtqODdiTWpCcDdMOXBGR2xDR2dBcFhsN1BiU3lCNXUvemVZ?=
 =?utf-8?B?M0MwL0NIZ3NHcHo3OFYrNmlJS2pwRXhTRFBZUngwdGpLNFRGbEZoWjNzejZ3?=
 =?utf-8?B?SDRVQWJJcWlEL0Nxc1pZOFV1Vm0xdDc1RnpOekV1ZUQzSHVmQW82OUwzNDd6?=
 =?utf-8?B?NzF4U1J3dFBiKytHbUpBc2ZRTEJIWXNIVUFUR1p0MC9GSTBkZThkQmRJVHJF?=
 =?utf-8?B?c2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a1be0e9-9e7d-4a5e-b998-08dc3843e448
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 09:59:02.5812
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yvZbCaaWkOtakLd4dCGpBOfQPP1eMK2QWb04xlMtkapOYcGhexPQBVTMnvlw7gNN3vUznPjzCwhiBqlih6j3sn1pQWOX7gw0MuQTmvnzFf0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8145
X-OriginatorOrg: intel.com


On 28.02.2024 07:28, Horatiu Vultur wrote:
> Lan8814 phy led behavior is not correct. It was noticed that the led
> still remains ON when the cable is unplugged while there was traffic
> passing at that time.
> 
> The fix consists in clearing bit 10 of register 0x38, in this way the
> led behaviour is correct and gets OFF when there is no link.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  drivers/net/phy/micrel.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 9b69735819896..5a0cc89eaebdd 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -114,6 +114,9 @@
>  #define LAN8814_INTR_CTRL_REG_POLARITY		BIT(1)
>  #define LAN8814_INTR_CTRL_REG_INTR_ENABLE	BIT(0)
>  
> +#define LAN8814_EEE_STATE			0x38
> +#define LAN8814_EEE_STATE_MASK2P5P		BIT(10)
> +
>  /* Represents 1ppm adjustment in 2^32 format with
>   * each nsec contains 4 clock cycles.
>   * The value is calculated as following: (1/1000000)/((2^-32)/4)
> @@ -3288,6 +3291,19 @@ static int lan8814_release_coma_mode(struct phy_device *phydev)
>  	return 0;
>  }
>  
> +static void lan8814_errata_fixes(struct phy_device *phydev)

This name is too generic IMO.
Maybe: lan8814_clear_2psp_bit

> +{
> +	u16 val;
> +
> +	/* It was noticed that when traffic is passing through the PHY and the
> +	 * cable is removed then the LED was still one even though there is no
> +	 * link
> +	 */
> +	val = lanphy_read_page_reg(phydev, 2, LAN8814_EEE_STATE);
> +	val &= ~LAN8814_EEE_STATE_MASK2P5P;
> +	lanphy_write_page_reg(phydev, 2, LAN8814_EEE_STATE, val);
> +}
> +
>  static int lan8814_probe(struct phy_device *phydev)
>  {
>  	const struct kszphy_type *type = phydev->drv->driver_data;
> @@ -3323,6 +3339,7 @@ static int lan8814_probe(struct phy_device *phydev)
>  	}
>  
>  	lan8814_ptp_init(phydev);
> +	lan8814_errata_fixes(phydev);
>  
>  	return 0;
>  }