Received-SPF: pass (google.com: domain of linux-kernel+bounces-84806-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <62ee2e75-72d5-43bf-a37f-948692a0e551@intel.com>
Date: Wed, 28 Feb 2024 11:03:51 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 2/2] net: phy: micrel: lan8814 cable improvement
 errata
Content-Language: en-US
To: Horatiu Vultur <horatiu.vultur@microchip.com>, <andrew@lunn.ch>,
	<hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<UNGLinuxDriver@microchip.com>
References: <20240228062813.1007138-1-horatiu.vultur@microchip.com>
 <20240228062813.1007138-3-horatiu.vultur@microchip.com>
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240228062813.1007138-3-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3MvQlpRK2pQdVV6cTlEdVBSQnJ1UThqV3ZmWnFObk53SUthYjRZZWFNQXVF?=
 =?utf-8?B?ZDNXc3N5NFpZRVpObng1a2s2aUNNY2Fia3pDM29mbXpNM0NFVDl0bGlwUUVj?=
 =?utf-8?B?MVBjUlFiZTZXYWY1TzI5OFpydHN6a3ZMSG1FOFRxM0ZoSmpzQnphVUVhZ3dP?=
 =?utf-8?B?OFVlK1FEbSs3czA3cDRQV3pqMy9Va2FHUkFlT2pFNW9WZmF0Mm9ScExlQ2I5?=
 =?utf-8?B?a3ZYdHoweDk2Z0I2d1hjSnNabHZra1FMeFg2NDdKN3VvVjlKNXFTdXhUbzJi?=
 =?utf-8?B?OFFjWFZJMXVIbENKTXo1RGJpWGg0bWRacXFrWTRiMUl0anlxTTFDZ2JGREtU?=
 =?utf-8?B?TlhpdnpCNEcxUWRwUjdNeFVib3p0V0NpdzNqOENtSC9JK2dsaHorRHgwYjNo?=
 =?utf-8?B?dGJObnRTVHBUUE1tbnZNSmEvQmVNcWhtV1lmdHJmWDFWWXlILzBkQ3J1RmR3?=
 =?utf-8?B?cTlrMDNkaXJYU25obEthVXVocjAvdk1wZ2J1cHNUTE9GeERoYmY4TG1GMCt1?=
 =?utf-8?B?VE43VFk0cjNhOG84TWdQZElhU1pORFh0YThDU3o2WDF6K0RwaUFJWloyV1Iv?=
 =?utf-8?B?SkNYNmNyT29MSFJWb1d6SFcyZmduNlVDRFArNlZIQjNtSkptRTZtS3VFUUNv?=
 =?utf-8?B?cGFmRDFyUEVvTUxsSTlkMkVmQzdCdUs0TXRZSjYwNnpOY3N3Q29Bc0dFVC8z?=
 =?utf-8?B?aTdPZ1RpZmhabEpZTWhkZm9DSlNIcHV6bUtRMHdVU2JqM0thRGV5VHhKL284?=
 =?utf-8?B?K081VElmaFgrWFlaU1ZudXdURTllczNhcWpCcUo2dCtnT0tjUFFRc3hQakVG?=
 =?utf-8?B?UE0ySThoVG16b2xMUTF3NjVpbmducThQaDEyTmhuRmUrM0hSUEd4RVR1WmxM?=
 =?utf-8?B?WUZvVDhveFRTUkMrdXA1VmRLRXlqY2ZQZDBYeTI5cm9oK2IrMHJ4cEZGc1JR?=
 =?utf-8?B?WDZWVTFCYVowVVlFTVk1dmVtcmRmTGp2R2VpNDdWY3NzTG5mTHR1M2dqb0d1?=
 =?utf-8?B?WDZtZlF6NXJhVnFLMHdCZ2d5czNWM2ZXS1dxM0MvUHN6N2YrQXVtbUl0ZGJ4?=
 =?utf-8?B?UUlnVzRhMWNPSnljTWpTVlV0aXBaRVMwdXRCRFdwcm1ZQklyTVNKcVZqUktp?=
 =?utf-8?B?N0dKMC8xajZYN1JCNnAzZCtNWnc2K0xRTFN0N0dORDFLbENJWlRSOHc5NHJD?=
 =?utf-8?B?ZGJjTVBKL3RpYnRRODNuMUFTYnBydVg4bHMxZWtraFA2UDkxMnM5aW5WUExJ?=
 =?utf-8?B?ZXE2MFZoUkhMcHArejNOMHJKTUJZOHVoR1FGcUkyeXVvck1wdmdWRzQyZ1Jz?=
 =?utf-8?B?MHFjcDdhMVZYZjRjSlVseDIwc3ZOSjhCZG9neTlpRWE0NHlIcnZHS1JWZG4z?=
 =?utf-8?B?UTVJTXA5SGkvN2lhMWUwZC9vVTVRbnlPYXJ4cjN6WG55OWxZNHROT0liZnBj?=
 =?utf-8?B?eDlDNUNGTHJhUE9QaEpsdXN4VFBXc3dMQkR0Tk1SYjgvNGxKek5oeFU4UTNE?=
 =?utf-8?B?OXlpZ0N2SDRwVDhwWmQ3N0xpSTEzTzd0bzZDaTRTZ0hna2NRUEpPTnJzYy95?=
 =?utf-8?B?a1hKZ1M3UkZ5RjhVdXBDVmwvRm9SWTdWZXVSdExFWVY2QTI3L0NRT2FMZERJ?=
 =?utf-8?B?M3NkeUFHa1g5dDVLTWc5SmhUaFFEWmdaVkd0cWtYVUlOM0x0Q0dGWGxuL3dq?=
 =?utf-8?B?VE40UTh4OW1IRDUrMytqZldjd2tFR0ZYLzA2eFdzaFRqZFN6Tk5haGJ1d29v?=
 =?utf-8?B?cDVjdUhwc09LT1dyUUNSYkNhMElheTFCZGVXbHlPSXlwOUFpTGpmcHRQekEy?=
 =?utf-8?B?dk5DRkFaam9iaXg3OU1mb0tmc28rNEYzOEQrRXR5L1Z1TEZsN1lhTktKZ0h3?=
 =?utf-8?B?VmZBdTk4KzNwMVA4SllnQ0UwLzkxZWdoQXlIQi9XY2tVUklBVEVNZit0ejhu?=
 =?utf-8?B?b0lWQUdHc1IxQStZT2syQlk0ZEZnUkQ3VlYwNFRsYVRMQ1Q1bFpZRkFDc1NK?=
 =?utf-8?B?N1drNWJ0dUtSdm9LTFF2NC9IcnBYaTdLd1djSWEzRy9BT21lbjlINkNzTUUy?=
 =?utf-8?B?WU5Ibnd2dmdKdGJxa0VXUkNYTUNLVzAxQkkzSFVyKzJ6cEN6cy9uSzB6d3l2?=
 =?utf-8?B?ZG1sM2QvSnBpYUZxbGlPOWpweGxGVHk0NE50WFYyWmFDUFpzSGFvb25lT0kx?=
 =?utf-8?B?V3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 911ed57c-d8e5-425c-9053-08dc384493e5
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 10:03:57.2282
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d+TRkaGk6XaeODM6KycbLa18FlIQ+rNoxnCofUHfeqR3dubQj03I8MFZNi38pmRA7c7kKWH6fwhMb0Dzs0l8YRAcW37MWY6lWT/az+IR7T0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7098
X-OriginatorOrg: intel.com


On 28.02.2024 07:28, Horatiu Vultur wrote:
> When the length of the cable is more than 100m and the lan8814 is
> configured to run in 1000Base-T Slave then the register of the device
> needs to be optimized.
> 
> Workaround this by setting the measure time to a value of 0xb. This
> value can be set regardless of the configuration.
> 
> This issue is described in 'LAN8814 Silicon Errata and Data Sheet
> Clarification' and according to that, this will not be corrected in a
> future silicon revision.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  drivers/net/phy/micrel.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 5a0cc89eaebdd..1e3b0436e161e 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -117,6 +117,10 @@
>  #define LAN8814_EEE_STATE			0x38
>  #define LAN8814_EEE_STATE_MASK2P5P		BIT(10)
>  
> +#define LAN8814_PD_CONTROLS			0x9d
> +#define LAN8814_PD_CONTROLS_PD_MEAS_TIME_MASK_	GENMASK(3, 0)
> +#define LAN8814_PD_CONTROLS_PD_MEAS_TIME_VAL_	0xb
> +
>  /* Represents 1ppm adjustment in 2^32 format with
>   * each nsec contains 4 clock cycles.
>   * The value is calculated as following: (1/1000000)/((2^-32)/4)
> @@ -3302,6 +3306,12 @@ static void lan8814_errata_fixes(struct phy_device *phydev)
>  	val = lanphy_read_page_reg(phydev, 2, LAN8814_EEE_STATE);
>  	val &= ~LAN8814_EEE_STATE_MASK2P5P;
>  	lanphy_write_page_reg(phydev, 2, LAN8814_EEE_STATE, val);
> +
> +	/* Improve cable reach beyond 100m */
> +	val = lanphy_read_page_reg(phydev, 1, LAN8814_PD_CONTROLS);
> +	val &= ~LAN8814_PD_CONTROLS_PD_MEAS_TIME_MASK_;
> +	val |= LAN8814_PD_CONTROLS_PD_MEAS_TIME_VAL_;
> +	lanphy_write_page_reg(phydev, 1, LAN8814_PD_CONTROLS, val);

Ok, now I see that the second fix is also in lan8814_errata_fixes.
I'd suggest to split both fixes to separate functions and name them
in more descriptive way.

>  }
>  
>  static int lan8814_probe(struct phy_device *phydev)