Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2462123rbb; Wed, 28 Feb 2024 02:33:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVyS8FH2IQ5yV+7goBEdg3Fr4yh1wQCEoSaUo/e6lMiZadA+lFfGJCBSI6iXR/Nzggb0OaGpACEZJLJxLSrpiZYjY7wnksCJ0ypAKTNMA== X-Google-Smtp-Source: AGHT+IFuzkHO+YexxH8RIvyA0wzoH//OVzNXmHBMjM7tO4atCQ90mSyyJxK4R0Q3oAgzKqmnJq90 X-Received: by 2002:a05:620a:4e2:b0:787:5582:2a4b with SMTP id b2-20020a05620a04e200b0078755822a4bmr4449411qkh.45.1709116413012; Wed, 28 Feb 2024 02:33:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709116412; cv=pass; d=google.com; s=arc-20160816; b=Uj27/unYYvWaRsuob954sZm42UrDnSWcHM+PGoy/wu4tfA6dL5+h0Wa5+s9lTduarS nG+0JFmpSWx+kywlmLYQequwDt9iZOBUDpm7zbk79++rtLV73V4Gzjrsvk22s6eLypXP tz4u/aUAUCyq/IlJZ3AaMZ/9DeYRWFXM8U51H926fLC4/BSDWUFc+uy1hcFdVjLfbiOh sdMeVUprohOPgHNiD60B4kMjr6ynwJv6l4m6dfmAsQL+i4fdByPpgFG8lf9ocISlYu4e RGUCWThjH8dGvXlxDRODkiSHeW0jOBAWtOzR2/DnLSIbLVvfmhqZ5+Ghdayb8ee0Xsjl jUYA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=9vRuDeubLHBjhVoVB4Akpy5PHWszldPz0jlTfUDlpHE=; fh=qlBRX9syPKDz7ftzsJbjzMA4t6Sw+QfdpPiC1XuapLc=; b=OHrovjWwOM2Vp/BQLVoeqTWu1w2Edye/qFOGAekgCN0vSlcPtBTwqDhY2FpMu039lk p8ZfZlvXFTXlY3VT1XOXi7qJ5TR1vzTyj/ruwL2KODLXUXU18XYjAtRO/50+jJ3H0g1n Nu2GKWPKyBho6pwFU6qrJwcZNcEIeaBKl0FceLWasrZP224Intt9rwP/yNwA1aCgtRni VeqaRwktbNCRPkkeRGG4jhnso4bReQTGJLI/do5JkDVsA6wDsMFnNAmLGAJvaKldFS9i WoOCrp3rkaFiHQeNJtnn7STvK2L519OWAjgiKB25bQ3XwNbM376KbYM+5Hf7oacAVEDu XOFA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-84834-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84834-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s16-20020a05620a16b000b0078403334a55si9562335qkj.133.2024.02.28.02.33.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 02:33:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84834-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-84834-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84834-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BF8071C20A16 for ; Wed, 28 Feb 2024 10:33:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0DEEA7E573; Wed, 28 Feb 2024 10:33:24 +0000 (UTC) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DDA07E10A; Wed, 28 Feb 2024 10:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709116403; cv=none; b=pQRpQrnEm97SMACVk3nwd26/068d99/402Dc1y8UETkIpglPHz7BeUfJS11rp+dLIDZ/w2UmTACBCEWsqqtnK6SxgQlFmqDvZ30caVkdc8JnlJphDhz4lBe3+sf33W+YM7CF5BDO5tBYoJSeZ3S4LAjKpWLvSexLG3kMsUYW1ok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709116403; c=relaxed/simple; bh=k/fwf9gHyqqMuGvw0n7UDHhezIdjtSpBNDTqMDufBDE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cRhTK678ymqQlgYaa2Bl++LnkF/tqyjCbucYVsKeHpoNrjcUADUPVH6YB9HIEJMG7QQLHSq+z+axuRVpAN3QF4B4TrTKQs417oaATmwHGg2FEQaFu+3HmPBG7/fJSVtBdIccXNFOpkVwf4eXEPRPaQWs4WETPhKMKD786yYjMeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5661b7b1f51so3751282a12.2; Wed, 28 Feb 2024 02:33:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709116400; x=1709721200; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9vRuDeubLHBjhVoVB4Akpy5PHWszldPz0jlTfUDlpHE=; b=u4kjJnJHswbkFQS840WVoXHY37kHHvImjFooOavpPf3eZZWPb0gy0CI3eyg0wMHl30 p3uSYEmVkTYarVKS1eyAevFjOLwfrYvTpDgyTIcBlUo/pTXGJ0ST8ZM0LhKs/hDCoMZ7 HMs+yj0C8T3ZSHSKi+guR7FGx6r4UNPyLq3RYt2h/CGRK31T9hU+LqTXZnUbUca27qyq 9h+/oELiWWO3oVAKX57BQH/KLmE6n5D/+IqBy4NFNb1ypnedxhHCFvlxOxZN8Cdr3pQk gerRivcVgv9qJQ+6lGG/M88QvlHUQAyESgKJUm9PNLKPEw1B+Va4ueJC+8GIGYNmnb0M YC0g== X-Forwarded-Encrypted: i=1; AJvYcCX6jtFPEO80zfLJmBEbx+IHmaBYGHNr43dBauzOcoBjcQV+M4dKXwCoUw73JLPY7Cv/1NzKmR9nBtunFqvKzHZocpsQ4FiCsbyY5HFhWyiYbFOWlRnNFGcTMVHukDrzBtsSFqCpT8qLkko+Fw== X-Gm-Message-State: AOJu0Yx/XapU/CNIGglpHKeeD11tGreHms9lNiBlV6617LIDFB7sVrLx qeYUXg3a470bSRA0x31N6tWzcGYvsbN94gbJC2QpCB797Og9BIRd X-Received: by 2002:a17:906:3cd:b0:a43:68b:6a3a with SMTP id c13-20020a17090603cd00b00a43068b6a3amr6605027eja.65.1709116400430; Wed, 28 Feb 2024 02:33:20 -0800 (PST) Received: from gmail.com (fwdproxy-lla-006.fbsv.net. [2a03:2880:30ff:6::face:b00c]) by smtp.gmail.com with ESMTPSA id ef3-20020a17090697c300b00a4396ea6628sm1683967ejb.210.2024.02.28.02.33.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 02:33:19 -0800 (PST) Date: Wed, 28 Feb 2024 02:33:17 -0800 From: Breno Leitao To: Lizhi Xu Cc: syzbot+7a3d75905ea1a830dbe5@syzkaller.appspotmail.com, asmadeus@codewreck.org, ericvh@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux_oss@crudebyte.com, lucho@ionkov.net, syzkaller-bugs@googlegroups.com, v9fs@lists.linux.dev Subject: Re: [PATCH next] fs/9p: fix uaf in in v9fs_stat2inode_dotl Message-ID: References: <00000000000055ecb906105ed669@google.com> <20240202121531.2550018-1-lizhi.xu@windriver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240202121531.2550018-1-lizhi.xu@windriver.com> On Fri, Feb 02, 2024 at 08:15:31PM +0800, Lizhi Xu wrote: > The incorrect logical order of accessing the st object code in v9fs_fid_iget_dotl > is causing this uaf. > > Fixes: 724a08450f74 ("fs/9p: simplify iget to remove unnecessary paths") > Reported-and-tested-by: syzbot+7a3d75905ea1a830dbe5@syzkaller.appspotmail.com > Signed-off-by: Lizhi Xu Tested-by: Breno Leitao