Received-SPF: pass (google.com: domain of linux-kernel+bounces-84843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Andrew Lunn <andrew@lunn.ch>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Sunil Kovvuri Goutham
	<sgoutham@marvell.com>
Subject: RE: [EXT] Re: [net-next PatchV3] octeontx2-pf: Add support to read
 eeprom information
Thread-Topic: [EXT] Re: [net-next PatchV3] octeontx2-pf: Add support to read
 eeprom information
Thread-Index: AQHaaZROIGbxXr4C5kqkRYmpzf+/FLEfgzHw
Date: Wed, 28 Feb 2024 10:45:02 +0000
Message-ID: 
 <PH0PR18MB4474F9F96EDDC1FD22E1B5F9DE582@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240227084722.27110-1-hkelam@marvell.com>
 <28d5c5b8-bd8f-458a-a62e-bb233add4a2b@lunn.ch>
In-Reply-To: <28d5c5b8-bd8f-458a-a62e-bb233add4a2b@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?jad2P8dnb1q3Z2B2BiQjfCb+B26fo8qDbH3eQn/TVZ04kxFx7ICTZcfJqkMa?=
 =?us-ascii?Q?pD9jhSA/+eVjsQ2c3GLJAoW5if98ICEbCgQYEhtqYmDqOnDMA3d6AACjwfsS?=
 =?us-ascii?Q?G2xfbXM2H//KLnNfG4+0aSthwF+nqQW/mZiCN+vf+wbnNy6Zn0TvZeELtn6q?=
 =?us-ascii?Q?XGVHU/IU9lxCO8N3Npx3nm7a2pQEQiXHP9wh76WslNyRHsu5sUexFbd3K/Ro?=
 =?us-ascii?Q?ByKjxN1RXr2m6q0QN0njmItlyd9e3cIYCadESQ09SIKPyGJUru3TenlNw/uW?=
 =?us-ascii?Q?a+GkUVW6s8eMXK7OKVn8YF8lRoXYXvDg7iU2gjTQkQ7FjFgFjCDC15xJflKE?=
 =?us-ascii?Q?fixDmFVSYa7xcZ0w0kUCVV4qLpVyOD2kjVG+i+xVL3h0AVg0i+hJfJY5jax2?=
 =?us-ascii?Q?gKuVKexiW8huX9uz3WS2/sWsDEHPDUn9lnlmfameYCa4HcvOtdjtcPMnk+8w?=
 =?us-ascii?Q?ONVlYRQUTF1dZuOJTX8PUb6c23vE0fU+offADAkc/xIU0VQbZUP4obCJJIZP?=
 =?us-ascii?Q?pDkYoyJlJGn0jSVhfbYpkPUbX3A1ft3TgHVPcb8BfYXTm+wwqV5ieVPc8Q8N?=
 =?us-ascii?Q?RCqKesFuoyHoWiTZ9gjFGJx+Sx39vc2kkxa2lvOTx31zEoB5xk5mMT0t417n?=
 =?us-ascii?Q?Z7La1M67+jRxHTrjtAatpR7KHEQPWqqdFEQaMxsziy6Mh0TY9p5lSMKkzF4c?=
 =?us-ascii?Q?5NiB6o8Hvfeub/W0Px+2gM6zVG4FwNG7utmk8GrOyo2QmUkZLhjvetrZ24G+?=
 =?us-ascii?Q?bl7LtdNfiDpP68eSGYGI1zjkBTHPxG+NSR9UDdRSf2z6auEudFA59v8+49sY?=
 =?us-ascii?Q?U/hXmlnl+NtTTp2Jwz9+bB5BpDMiAUnREAxOeQjWqiY+6BQxk3tzUPmPSun+?=
 =?us-ascii?Q?ZRDQsIcvPu9MMtX0iKZwUBE7g/ZFgw9yawKJE0126Wh5s8oPLLcSKXQluhCn?=
 =?us-ascii?Q?IK/ez8UcS+bdrh2Ez0oa73rvzaqmxYvqoY6djJUhEsLnWkqLF3PAdUf3QKAi?=
 =?us-ascii?Q?Y0yGpN80I7aqTYqfV1AsAG0zLUlfLBdP/6ZW/ol83HkvWKPjA3R7cMTqIJkP?=
 =?us-ascii?Q?+7PyqA1xc76Vdxrc9inSQRiKud2Zcrtc/ctim23z8sCN+8OE0xkrm5x4Vv/L?=
 =?us-ascii?Q?Y7k2LPItuSU9nkHkY9gJbhsMhQwl7LMvYLz3DwkJFl3yGhxWivnyTChfGTf9?=
 =?us-ascii?Q?IqOgePIzVOZTExdV+BL9L0KRAKgv9HilhWCloXHL4UhdM5wJpu1G50WQ2R4Q?=
 =?us-ascii?Q?a9jPhYhi/nDhgnh+oXxiWGOBo7PrL5AP5AQWXfVq4rn3I73kg+8rrwFD8V0c?=
 =?us-ascii?Q?oFoOds5ceNlIiUCy/BkMeNFi7npGQiPZXXxbaPYUL1EGPYNaNQ3qkRm4/B4q?=
 =?us-ascii?Q?3aMNrxgSACMzK5fuVTb4ARTvm5VTo/E/QF0IWrOBFhn1tNlg0Qup4g57ajDQ?=
 =?us-ascii?Q?OckskuhXCS4v0JL1AO9QD4RP5qcUwmQ7LyJlOavJngM3N0VcgVvsH6R1W5pD?=
 =?us-ascii?Q?bDgfUVonr7bPHoI158d+OosXxTu7I/SDwxZcEp/67zAVa5HhaQ2HLwZRKD1q?=
 =?us-ascii?Q?kWO29hzUZKoNIWvVlxk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 212ab055-67ac-4de1-7ac7-08dc384a516d
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2024 10:45:02.4539
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wqMl+405nkazHHAg5WXUZtJxMJR4wM24Y7kR4Rlhlwosl131+cAi/8dNBsso7QJVYh0F8EnKgewZr/6vb640OQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR18MB5901
X-Proofpoint-ORIG-GUID: u6tV6IBAha8Ad8OXvXhebANDg_7NpNp9
X-Proofpoint-GUID: u6tV6IBAha8Ad8OXvXhebANDg_7NpNp9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-28_04,2024-02-27_01,2023-05-22_02


> On Tue, Feb 27, 2024 at 02:17:22PM +0530, Hariprasad Kelam wrote:
> > Add support to read/decode EEPROM module information using ethtool.
> > Usage: ethtool -m <interface>
> >
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
> > ---
> > V3 * remove redundant checks as stack is already doing it.
>=20
> So still only access to the first 256 bytes, using the old internal API.
>=20
Firmware and Kernel shares the data over a shared memory region.=20

  Firmware   <-- Shared memory -->   Kernel

As per our design, firmware updates the shared memory region by reading eep=
rom data from the MAC.=20
Upon receiving ethtool request to read eeprom data, Kernel maps this shared=
 memory and copies the eeprom data to the user.

Currently firmware supports updating only the first page of eeprom. Due to =
this we are limited to support the first page.

, using the old internal API.

While copying the data, the current patch does considers the offset/length =
fields.
         ethtool -m ethx offset x length x

Could please point us what are we missing here?

Thanks,
Hariprasad k


> Disappointing.
>=20
> And the Signed-of-by: appear to be in the wrong order.
>=20
>     Andrew