Received-SPF: pass (google.com: domain of linux-kernel+bounces-84939-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Hao Ge <gehao618@163.com>
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] mm/vmstat: Add order's information for extfrag_index and unusable_index
Date: Wed, 28 Feb 2024 19:43:49 +0800
Message-Id: <8805D07B-9F33-42DE-985B-83E0E5C056AC@163.com>
References: <20240228113332.358801-1-gehao@kylinos.cn>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org
In-Reply-To: <20240228113332.358801-1-gehao@kylinos.cn>
To: Hao Ge <gehao@kylinos.cn>

Please ignore this patch because I forgot to use checkpatch.pl to check for f=
ormatting issues. I will fix it and resend a new one,Sorry to bother you.

> On Feb 28, 2024, at 19:33, Hao Ge <gehao@kylinos.cn> wrote:
>=20
> =EF=BB=BFCurrent cat /sys/kernel/debug/extfrag/extfrag_index and
> /sys/kernel/debug/extfrag/unusable_index is not friendly to userspace.
>=20
> We should add order's information so that users can clearly understand
> the situation of each order at a glance like pagetypeinfo.
>=20
> befor:
> cat /sys/kernel/debug/extfrag/extfrag_index:
> Node 0, zone    DMA32 -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ...
> Node 0, zone   Normal -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ...
>=20
> cat /sys/kernel/debug/extfrag/unusable_index:
> Node 0, zone    DMA32 0.000 0.000 0.000 0.000 0.001 0.003 0.007 ...
> Node 0, zone   Normal 0.000 0.053 0.106 0.159 0.205 0.244 0.265 ...
>=20
> after:
> cat /sys/kernel/debug/extfrag/extfrag_index:
> Extfrag index at order:      0      1      2      3      4      5 ...
> Node 0, zone        DMA -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ...
> Node 0, zone     Normal -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ...
>=20
> cat /sys/kernel/debug/extfrag/unusable_index:
> Unusable index at order:     0     1     2     3     4     5 ...
> Node 0, zone         DMA 0.000 0.030 0.059 0.085 0.096 0.102 ...
> Node 0, zone      Normal 0.000 0.225 0.427 0.569 0.776 0.827 ...
>=20
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
> ---
> mm/vmstat.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>=20
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index db79935e4a54..f604d91e904c 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -2178,7 +2178,7 @@ static void unusable_show_print(struct seq_file *m,
>    int index;
>    struct contig_page_info info;
>=20
> -    seq_printf(m, "Node %d, zone %8s ",
> +    seq_printf(m, "Node %d, zone %11s ",
>                pgdat->node_id,
>                zone->name);
>    for (order =3D 0; order < NR_PAGE_ORDERS; ++order) {
> @@ -2201,12 +2201,19 @@ static void unusable_show_print(struct seq_file *m=
,
>  */
> static int unusable_show(struct seq_file *m, void *arg)
> {
> +    int order;
>    pg_data_t *pgdat =3D (pg_data_t *)arg;
>=20
>    /* check memoryless node */
>    if (!node_state(pgdat->node_id, N_MEMORY))
>        return 0;
>=20
> +    /* Print header */
> +        seq_printf(m, "%s ", "Unusable index at order:");
> +        for (order =3D 0; order < NR_PAGE_ORDERS; ++order)
> +                seq_printf(m, "%5d ", order);
> +        seq_putc(m, '\n');
> +
>    walk_zones_in_node(m, pgdat, true, false, unusable_show_print);
>=20
>    return 0;
> @@ -2230,7 +2237,7 @@ static void extfrag_show_print(struct seq_file *m,
>    /* Alloc on stack as interrupts are disabled for zone walk */
>    struct contig_page_info info;
>=20
> -    seq_printf(m, "Node %d, zone %8s ",
> +    seq_printf(m, "Node %d, zone %10s ",
>                pgdat->node_id,
>                zone->name);
>    for (order =3D 0; order < NR_PAGE_ORDERS; ++order) {
> @@ -2247,8 +2254,15 @@ static void extfrag_show_print(struct seq_file *m,
>  */
> static int extfrag_show(struct seq_file *m, void *arg)
> {
> +    int order;
>    pg_data_t *pgdat =3D (pg_data_t *)arg;
>=20
> +    /* Print header */
> +    seq_printf(m, "%s ", "Extfrag index at order:");
> +    for (order =3D 0; order < NR_PAGE_ORDERS; ++order)
> +        seq_printf(m, "%6d ", order);
> +    seq_putc(m, '\n');
> +
>    walk_zones_in_node(m, pgdat, true, false, extfrag_show_print);
>=20
>    return 0;
> --=20
> 2.25.1