Received-SPF: pass (google.com: domain of linux-kernel+bounces-85020-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a07db8f8-39f8-44ad-b466-10ac02f3da13@oracle.com>
Date: Wed, 28 Feb 2024 12:31:42 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] firmware_loader: Use init_utsname()->release
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: russ.weight@linux.dev, gregkh@linuxfoundation.org, rafael@kernel.org,
        linux-kernel@vger.kernel.org, masahiroy@kernel.org
References: <20240222145819.96646-1-john.g.garry@oracle.com>
 <Zddt-U-6SdxkxqmD@bombadil.infradead.org>
 <51483aaf-d64a-4eee-b256-ab126483ad6c@oracle.com>
 <Zdy9gKO5Q6K4IE8J@bombadil.infradead.org>
 <ZdzGF9bxLn3Slbgi@bombadil.infradead.org>
 <cb0c185c-54f8-4b43-856f-685cc5ed3fc4@oracle.com>
 <Zd3cz7yYezir-P7e@bombadil.infradead.org>
 <e88b76c5-1b13-4ad7-a97d-c34722cfde19@oracle.com>
 <Zd3oke0pAL2G05Rj@bombadil.infradead.org>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <Zd3oke0pAL2G05Rj@bombadil.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?OU9wVHNGVGoxSnd3T0pzSEhIb3plNVBldUhycWRYN3NrNGpoanBIVDFuSklG?=
 =?utf-8?B?SGwwY0ZJYU1XLzRQSDZIdjd2bjJYTzlXZndyYW9SdzRjb0NBYXNsUHBXRzZr?=
 =?utf-8?B?UnRPcW84d3ZhTW5CT3BCWllha1dQUkFzVXMvbGQxUWtKcEowTi83MFk5Nnd5?=
 =?utf-8?B?cVVPVlVwVVNOS3BiRG90bGs1dllhVGZDakZLN0ZQZjdpOHhoYy91c3VCV3ls?=
 =?utf-8?B?dURKZjVGbjgrZUk4OHdvSVpBWEdoVForNWFCblB1VjhpUHlYY0FlVDBZRjBw?=
 =?utf-8?B?NUxNVFJIVnVaRnNvSzZQVDdYOW9YU2ptRm5FS0Mwb0NXbmtoaFRpNDFqRjhh?=
 =?utf-8?B?Yyt0NTBwa0VKUFBEMUdaVEE4bXFNUzdBb0N0emM4QTNKczlRMCt5RW9HY0JU?=
 =?utf-8?B?ZkJZSEJ0YUtXWVFuZG9kd3hqbVdDMDV1VHg0UFdZaVlON1BBWlBQNUxTbUEr?=
 =?utf-8?B?QjYrWmFXdTBzR0k1dVBGWEpoREJSNWoxQkFyZHQ2RjhaT2MwK0REZnBlQWpR?=
 =?utf-8?B?UTQ0SlYvS2lqSFRvM2trcjhwcjZ2VVYzd0RpbFFPTzE1eU1GK2QyZ3lTbkR0?=
 =?utf-8?B?TE1Fb3hWTnJHa3dxZk5sQ2tuN1NxNk1ScXNxTWtaOFpzeHRoRnl3QmV2dm1R?=
 =?utf-8?B?QzA0T3RhelYrdzBPeVNiT3JiaHBIemFwZkNUT1N3T0ExOFA4UDUxZ3VLQmFq?=
 =?utf-8?B?NnkxRnozY1Uxa3pGdnpiVVdad0VFL1hEZWdtdlNMdTR0aTdCQW5GQTZVRFZ1?=
 =?utf-8?B?bU9sbm0weHIyWUpLck9GNERaSGNrYlo3aFI2d3RydTRUYjJxaThZSXZmRTZa?=
 =?utf-8?B?c0g3RldGR2VsREJDZUU4NEJ5eVgvaDhJa1hSNlpwRXdDM1FqZ2pYNzdwdzZ6?=
 =?utf-8?B?OHJVRDZyN3dnVVQyN1ZZNHZCWmo1cU5KZTZZRHVia1JubUd0V1RpY1RhcUlU?=
 =?utf-8?B?MENpNStxUXpWS2ZkZzIzOVV6T3BGaFZLNXM3S2xJNUY5ME85MFluNzBseTZl?=
 =?utf-8?B?amRzL2RFTkhLUDNaTXVYMGJuV0krWG83S0tZYVNnY211bkpSOVkva3Y5a2t4?=
 =?utf-8?B?dHlLdUtZMVJTQzBpN0dVSktON0tBMm5FdU1tNmZaYmhSYVNzMEo2bWNWemR4?=
 =?utf-8?B?bm16N0ZNSFZPNk5MSUlUdEluL0FLYUMwZXhSRzRNREM0U1RhTlhVWWNmUjBy?=
 =?utf-8?B?VStIUThuQm5wWDhJaUphdnErTDF3L0Y5elMzZVp0YnY4SGRieGN0eUcwWjFJ?=
 =?utf-8?B?UC9RYWFKbkZ5S2NuUDZHMVhtQWpFdUpScWhTSmg0SlBNNSsrMUwySU80VElx?=
 =?utf-8?B?RitXcWNnU0ZyTXBjbG9FaFprSmd6bVBiRk9jb2NqR1l5TGZDOG41QVVXNGlZ?=
 =?utf-8?B?Z2lVdzZmZUswODh4WmFvVDZkUGN4dDZnZjgzRW1WcTErZjdBKzZZaCtkRnpn?=
 =?utf-8?B?Uk1PaEdZN3NoOG5STE9jeFJNQlJKQkVUVnVoY2REQXVURGdqOTVKS2hXMkZH?=
 =?utf-8?B?RXNZY0ZOVHQ4V3pKTXZWZXMreXRMazllY2JPUkV5cDg5NzloekVCQW9Tcmll?=
 =?utf-8?B?a0g2NlQzZkdidXhLUlRPc1pKK1c3QXd3K05ZbXhwNm5kK2FsSWF1SmZOQ1d0?=
 =?utf-8?B?dVZHckZBQTdKbkRxc2s4SWo2WEUrY20xU1ppejlqd0lyRnAzYlNQY25nU0tV?=
 =?utf-8?B?c3N2cUdQTmlvSmpTd0ZobzJEeHNBVU5pTExHeXhwdWh0bnNoRmhCdTBNK1pR?=
 =?utf-8?B?VmZpTE1lNW4xek1CVmJPRjVsam1DQUE2OVFlRDJFNGVwSHpqZHlZOW5GUG8z?=
 =?utf-8?B?WTkxTFh0ZjZvWEVZQ0J3dS95dGdZQ3BkZEhmdjdLbFdMOEQrK2JGYVVmTHlq?=
 =?utf-8?B?WE9IeXZ1Z2dtYkdlYzRkbC9ZZzFCQ0E3RmJsM3ptZTJoNDRTbGJvSDJPWDRq?=
 =?utf-8?B?TXJLbUxhU3YrcFcwUkJYU25CdFNqYjJ4K1lxYlhjZjAxRm1halNzN2U3OFpD?=
 =?utf-8?B?T1hXOEQwbzFCcDZIdE1SaXYrYzNJUHhkK1U5YW1CMmdqbXVaQy9HV1Vqb2FB?=
 =?utf-8?B?dGlLVTNqdnMvL3JaVitRTkNaRjY3ZXVZUXRXOEQ3ZUsydXZmTElGWCtaNldl?=
 =?utf-8?Q?o5SwGSWrE2sBJ9GeKdA+s/Nqu?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	EZvg3cSq4yhdMtE3793b4sEv3ncklKnfq5tp6Jh6iz9CumdUIZ38AaXJmDAv2/L9Z6U1wLsZgIxi45Fls/zhR+3QiCGLw9WvSfil/dIw1N7KpYD/ZqIz9zvHN6z4aAUoEQyP+sUaf3etlONzoeyc4x9HTvgt7OwtV/YmY5NDeKAGOhaAKbz+LATuwPhM8Oma0M31k/JNxmOeQyaHIHhpb9cQ+lbwSO/ykWFstf+DnpU33gJTFRVeZz8ETAE6FNQVw/4FCFoFwMfTjjWoIltmZUJ/vM5vx/fi5FWC8szjHvUTQrd4WuLbx89GT/F7/AtOlshfJDdEdCxLqjf4gO6eXsGKrhAprLUaN7YhdhJxL5aPUe9bqml0hXV0hOEQA9V9AIqlyEGkI/ZlZ95P43x/8Q0+mpqcL1EB78Wse84FoiUe/qemq++TOVBTQublY/3kLd3q5wBB/6VlwUBAltWmucN7uAeOfpZt07pl6KlYmYP717+URIvAhSrqrWOz/IasqeNNc4I52liE2wAcHqMsq/1CBe4NR2PocjS9yxvvUF7dKXUchW6fP9kUK2nqQBZcJzmq76+y+hWgGNOr1WV3SSvlkrJZ7yk0Prkx1+O3aAs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 874cad47-7ac6-4768-0841-08dc38593a24
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 12:31:46.0503
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qGFUDP4xGFmFqeYNABEbbiUgpAPKrrioGOOhOMk/674L0hJpy5TQ6Fa43yXFJTnyuLMNCiF5zZHGLM5Vwd81eA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4443
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-28_05,2024-02-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0
 mlxlogscore=999 malwarescore=0 phishscore=0 mlxscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402280099
X-Proofpoint-GUID: KrA18q3OYdgl0d1nb32DzZs2MTMZlCz8
X-Proofpoint-ORIG-GUID: KrA18q3OYdgl0d1nb32DzZs2MTMZlCz8

On 27/02/2024 13:50, Luis Chamberlain wrote:
> On Tue, Feb 27, 2024 at 01:02:26PM +0000, John Garry wrote:
>> On 27/02/2024 12:59, Luis Chamberlain wrote:
>>> What kernel are you seeing this issue on?
>> I was testing v6.8-rc5 last week
> I cannot reproduce a hung task there either on that kernel.
> 
> I see this:
> 
> sysfs: cannot create duplicate filename '/devices/virtual/misc/test_firmware/nope-test-firmware.bin'
> 
> But these are expected as the selftests tries silly things to ensure
> they are not allowed.
> 
> If you can reproduce it there, it would be appreciated if you look underneath
> the hood a bit, or share anything glaring and obvious which may help
> reproduce this.

Update: commenting-out /lib/udev/rules.d/50-firmware.rules seems to make 
the test reliably pass for v6.8-rc5, but not with my patch on top - I 
still get a hang there. I'll investigate that hang with my patch.

Thanks,
John