Received-SPF: pass (google.com: domain of linux-kernel+bounces-85033-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 28 Feb 2024 12:48:01 +0000
From: Simon Horman <horms@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Russ Weight <russ.weight@linux.dev>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Mark Brown <broonie@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
	Dent Project <dentproject@linuxfoundation.org>
Subject: Re: [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework
 within PSE framework
Message-ID: <20240228124801.GC292522@kernel.org>
References: <20240227-feature_poe-v5-0-28f0aa48246d@bootlin.com>
 <20240227-feature_poe-v5-13-28f0aa48246d@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240227-feature_poe-v5-13-28f0aa48246d@bootlin.com>

On Tue, Feb 27, 2024 at 03:42:55PM +0100, Kory Maincent wrote:

..

> diff --git a/include/linux/pse-pd/pse.h b/include/linux/pse-pd/pse.h
> index 522115cc6cef..a3e297cc2150 100644
> --- a/include/linux/pse-pd/pse.h
> +++ b/include/linux/pse-pd/pse.h
> @@ -55,10 +55,10 @@ struct pse_controller_ops {
>  	int (*ethtool_get_status)(struct pse_controller_dev *pcdev,
>  		unsigned long id, struct netlink_ext_ack *extack,
>  		struct pse_control_status *status);
> -	int (*ethtool_set_config)(struct pse_controller_dev *pcdev,
> -		unsigned long id, struct netlink_ext_ack *extack,
> -		const struct pse_control_config *config);
>  	int (*setup_pi_matrix)(struct pse_controller_dev *pcdev);
> +	int (*pi_is_enabled)(struct pse_controller_dev *pcdev, int id);
> +	int (*pi_enable)(struct pse_controller_dev *pcdev, int id);
> +	int (*pi_disable)(struct pse_controller_dev *pcdev, int id);

Hi Kory,

Please update the Kernel doc for struct pse_controller_ops to reflect the
added and removed fields.

>  };
>  
>  struct module;
> @@ -90,10 +90,14 @@ struct pse_pi_pairset {
>   *
>   * @pairset: table of the PSE PI pinout alternative for the two pairset
>   * @np: device node pointer of the PSE PI node
> + * @rdev: regulator represented by the PSE PI
> + * @enabled: PI enabled state
>   */
>  struct pse_pi {
>  	struct pse_pi_pairset pairset[2];
>  	struct device_node *np;
> +	struct regulator_dev *rdev;
> +	bool enabled;
>  };
>  
>  /**
> @@ -107,6 +111,8 @@ struct pse_pi {
>   * @of_pse_n_cells: number of cells in PSE line specifiers
>   * @nr_lines: number of PSE controls in this controller device
>   * @lock: Mutex for serialization access to the PSE controller
> + * @lock_owner: current owner of the mutex
> + * @ref_cnt: mutex's reference count

These newly documented fields don't seem to exist in struct
pse_controller_dev. Perhaps this is an left over from earlier development?

>   * @types: types of the PSE controller
>   * @pi: table of PSE PIs described in this controller device
>   * @of_legacy: flag set if the pse_pis devicetree node is not used
> @@ -132,7 +138,8 @@ struct device;
>  int devm_pse_controller_register(struct device *dev,
>  				 struct pse_controller_dev *pcdev);
>  
> -struct pse_control *of_pse_control_get(struct device_node *node);
> +struct pse_control *of_pse_control_get(struct device *dev,
> +				       struct device_node *node);
>  void pse_control_put(struct pse_control *psec);
>  
>  int pse_ethtool_get_status(struct pse_control *psec,
> @@ -147,7 +154,8 @@ bool pse_has_c33(struct pse_control *psec);
>  
>  #else
>  
> -static inline struct pse_control *of_pse_control_get(struct device_node *node)
> +static inline struct pse_control *of_pse_control_get(struct device *dev,
> +						     struct device_node *node)
>  {
>  	return ERR_PTR(-ENOENT);
>  }
> 
> -- 
> 2.25.1
> 
>