Received-SPF: pass (google.com: domain of linux-kernel+bounces-85036-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <00f32f45-a423-2c6a-e53b-c132ed1cde50@amd.com>
Date: Wed, 28 Feb 2024 18:19:59 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
From: Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v4 1/4] perf/core: Rework forwarding of {task|cpu}-clock
 events
To: Pengfei Xu <pengfei.xu@intel.com>
Cc: peterz@infradead.org, namhyung@kernel.org, eranian@google.com,
 acme@kernel.org, mark.rutland@arm.com, jolsa@kernel.org, irogers@google.com,
 bp@alien8.de, kan.liang@linux.intel.com, adrian.hunter@intel.com,
 maddy@linux.ibm.com, x86@kernel.org, linux-perf-users@vger.kernel.org,
 linux-kernel@vger.kernel.org, sandipan.das@amd.com, ananth.narayan@amd.com,
 santosh.shukla@amd.com, lkp@intel.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230504110003.2548-1-ravi.bangoria@amd.com>
 <20230504110003.2548-2-ravi.bangoria@amd.com>
 <ZdRluZx3fy0xx78D@xpf.sh.intel.com>
 <9eeb2273-9690-8f71-4f3f-595310d53600@amd.com>
Content-Language: en-US
In-Reply-To: <9eeb2273-9690-8f71-4f3f-595310d53600@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WDhIU09CaTFIU1FaVzhJQVVZbC9qRDZsWVQwMWV2Mm9tVXhEbkNaRVdxa3dX?=
 =?utf-8?B?dXlwREVCTndaZ1pWL3V0YzBQSjFmS29HM2dCRlA3RTUxOUltbTM0UEt5eTM5?=
 =?utf-8?B?eklBc2ZiQ1VEeDNqRWxiM3dDaCtTUlJFYUNERmJQa29OTCtkN1A1eWhkall6?=
 =?utf-8?B?ZkhNN0pYU09obnNVdzRnQXlFb1l2ZmtBT1lINmxWdjR1aTNDbEFvRVV3SkE0?=
 =?utf-8?B?TkZSYXpuWUJCSkliWkVwSjBxNzRjaUpVK3pQQlg2NHdtK0RCT3luaUc2eGsy?=
 =?utf-8?B?OUhQQ2lnODE0UmMzVlRFeTNxbmFMQ2JNR2VPT2plU0xabVFrdllPRm9SVzFU?=
 =?utf-8?B?SkswUXZ3ZE1LTWE5eVFyKzl4WndvaDFkTmJRYkg3RXRNSnBiRy82bXBJN1I1?=
 =?utf-8?B?V0o2Uk5ncjZEeWM5UHZ4WnRSWHNZRWcveVdwV1huMWF1UUc2ekRxd1l0bmxI?=
 =?utf-8?B?MzJHYWNWdlpnOTMxbVBvWm5MaXkyTGhYU3MzZG9IazRjYThUK2gxU3A3dzNu?=
 =?utf-8?B?elB0QjNxY0RKM3F4UjhHZytFNmZSOUkrdGJaVGhTRUNvNklJeTZ3MUduU09x?=
 =?utf-8?B?bWhpWDhjdlBwL0VpUG51YlN3Y2l4RXVzQXBOODIrdnM1YWlXZ0hsdW1IcTNO?=
 =?utf-8?B?dFprRVJJbnJPcE9jbnU0Myt1b21SZmQ0T2l2cWM0dHRhd2NXbVNZOVRiWmRy?=
 =?utf-8?B?eGNDZGxOY0dIdHNJY2NveEZ5SFF3SXVSbUxKNmIvOUd5NUdOMXR0ekVlbWU5?=
 =?utf-8?B?MEJnYWVocFVaeFVKbjlIeXNrY2I3NTJaam5hdUFmT0s3bXZoTXVhZmNsUlB3?=
 =?utf-8?B?N0pzUGhPdDRCMXVMQnhFMVZPc1gyV3g5ODFyTHNWMDJQMlpxblF0VXgxbG83?=
 =?utf-8?B?NWxkS1lCL1pEWTNYS1VOQU9TLzE5SU5sN2VlWmQvZnBmNFZDZWtxZUIrRk5S?=
 =?utf-8?B?RU5uVzl1RDRHMG84Q2hReEhvblFwV3EzNHkrWS92RXowNkxRTHhuNno5M2JR?=
 =?utf-8?B?VlovZHpPd1EzcEJhMXhKeHpFNFJCaGw4Slk1aTlIajE4WHpFeFRPUXUrWlUw?=
 =?utf-8?B?bTNmWm1FMkNDdUFWSW82SGUzR2NtQmE2cHdSaHh0TjJLa200QlFYMEdCdWp6?=
 =?utf-8?B?NFFnSGJTNFpNSkJuM0xpU2pacVNsTlo3Wm44M3lTVzVodUJxSEpBNHRwOU1w?=
 =?utf-8?B?bW9IMm1HbFR5Q0tBa29TeTVoc1c1Si9zVUNqK3lWeEFpOGV3dTVkSVN1QTZo?=
 =?utf-8?B?M1c1SWdRandGV1A4QUJlQXY0WnJKTS82dVhOVzBQZVR2bEpUckxtSXFFUFFH?=
 =?utf-8?B?UDNIOVlWUENBenJiRVY0eVdNRVltRVYyVFlNVHlDZlZSY0psbUhqTGJiNnlj?=
 =?utf-8?B?S2JSdUYyTkhuTk92SHA4YTV2OE1NZmhHZXNYYUdCVjhGcWRkaXFTUDF3ZkhW?=
 =?utf-8?B?SkpxSFVEdlp3dkxOaFZaV3pSdFNBMkU2dWdzNndxWkVyVW5NRk1BRDV0cHlF?=
 =?utf-8?B?YmVtdE1xQ0d3TUc5YUhud0svaUllMkhRSUlOR216RUM5V3ZOa0pYNjlVUTRm?=
 =?utf-8?B?czI0OXVPMTlqSHg0cnB6cU5DTW0vK2ZldmlmTWxSbWdNeHNpQk9wb1JQcWJC?=
 =?utf-8?B?UG53dHhsT0tiOHg3dTFPQ2tWcS9KVUt1Nmk4Uk9UbXVwdHdseDQ1M3l6NHgw?=
 =?utf-8?B?UmhrdjVKYmh4b0ZVRzk3QVp4NllERGIycmUveWFib0FUazlTNlZET1NrOFpI?=
 =?utf-8?B?MHNvbkRCeWU1dG5uOC83eWVHWmVSdVZIdkRXY2xDaElRY1FnelJBR2pGVk1I?=
 =?utf-8?B?YXJ4Zk10VkZQMjE5UFc1ckNBV0RhMkRscnlyOExsWWpMMlVaVWl4Q2hBY25N?=
 =?utf-8?B?RkZEUEwraHRZTStsYzJDbkNnbEdmZEtacUlBQ1hYWE1zdFBtRTkxbHlyRDlC?=
 =?utf-8?B?elpQQXZOUFlVMWRGY3FIM2w5QXdaczBRdHJ0ckcyek50Rkd5b0ZWRkpFS3pS?=
 =?utf-8?B?eFA0RjQ0aDFzZjR1MUs1VlYrQ21Kb09DSDVodkRpZlE5VDRsdVVuWEtwQTdI?=
 =?utf-8?B?WmQwQTBvUExkc1JhK3ZLY3Q2ZkxUSHdpZkdYZjFKSU1MOW9ualgvRmVNUzZY?=
 =?utf-8?Q?xo/tPuQhehpYuapQV7XzTE/dE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6a68340-24a2-432a-46ec-08dc385bcdd3
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 12:50:12.9862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Iy1euVKdCi6TKF5DW9WPXLLzf1ZcnAuGSasmU2Wa7hzsiCIAXkk/L5Sij8rVW5ZcW67Eqf3YL6Gj7CXJw9y8Bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7355

>>> Currently, PERF_TYPE_SOFTWARE is treated specially since task-clock and
>>> cpu-clock events are interfaced through it but internally gets forwarded
>>> to their own pmus.
>>>
>>> Rework this by overwriting event->attr.type in perf_swevent_init() which
>>> will cause perf_init_event() to retry with updated type and event will
>>> automatically get forwarded to right pmu. With the change, SW pmu no
>>> longer needs to be treated specially and can be included in 'pmu_idr'
>>> list.
>>>
>>> Suggested-by: Peter Zijlstra <peterz@infradead.org>
>>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>>> ---
>>>  include/linux/perf_event.h | 10 +++++
>>>  kernel/events/core.c       | 77 ++++++++++++++++++++------------------
>>>  2 files changed, 51 insertions(+), 36 deletions(-)
>>
>> Greeting!
>> There is task hung in perf_tp_event_init in v6.8-rc4 in guest.
> 
> Thanks for the bug report. I'm able to reproduce it. Will try to spend
> more time to rootcause it.

Although the bisect has lead to 0d6d062ca27e as culprit commit, a minor
change (shown below) in the test program can create the same task hang
issue even with 0d6d062ca27e reverted.

-   *(uint32_t*)0x200000c0 = 6;   /* Use cpu-clock pmu type when 0d6d062ca27e is present */
+   *(uint32_t*)0x200000c0 = 1;   /* Use software pmu type when 0d6d062ca27e is absent */

So, 0d6d062ca27e is not the culprit commit.

Additionally,

o I've seen task hang or soft-lockups on a single cpu KVM guest while
  running your test as root and also as normal user with
  perf_event_paranoid=-1. But the same experiment on host, no lockups,
  only task hang. So I feel the bug report is false positive and there
  is no real issue (since the experiment requires special privilege).

o 0d6d062ca27e has inadvertently started allowing cpu-clock and task-
  clock events creation via their own pmu->type in perf_event_open(),
  instead of earlier design where the only interface was through sw
  pmu. Is it harmful? Probably not. But worth to be documented:

----><----

From c7ae1c57e2a23a05eb982524d37bc8542c9c9a34 Mon Sep 17 00:00:00 2001
From: Ravi Bangoria <ravi.bangoria@amd.com>
Date: Wed, 28 Feb 2024 17:29:04 +0530
Subject: [PATCH] perf/core: Document {cpu|task}-clock event open behavior

The standard interface to invoke task-clock and cpu-clock pmu is through
software pmu (see perf_swevent_init()), since these pmus are not exposed
to the user via sysfs and thus user doesn't know their pmu->type. However,
current code allows user to open an event if user has passed correct type
in the perf event attribute. This is not easily apparent from the code and
thus worth to be documented.

Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
---
 kernel/events/core.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index f0f0f71213a1..4072bccab3ba 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -11178,6 +11178,13 @@ static void cpu_clock_event_read(struct perf_event *event)
 
 static int cpu_clock_event_init(struct perf_event *event)
 {
+	/*
+	 * The standard interface to invoke task-clock pmu is through software
+	 * pmu(see perf_swevent_init()), since task-clock pmu is not exposed to
+	 * the user via sysfs and thus user doesn't know perf_task_clock.type.
+	 * However, allow user to open an event if user has passed correct type
+	 * in the attribute.
+	 */
 	if (event->attr.type != perf_cpu_clock.type)
 		return -ENOENT;
 
@@ -11260,6 +11267,13 @@ static void task_clock_event_read(struct perf_event *event)
 
 static int task_clock_event_init(struct perf_event *event)
 {
+	/*
+	 * The standard interface to invoke task-clock pmu is through software
+	 * pmu(see perf_swevent_init()), since task-clock pmu is not exposed to
+	 * the user via sysfs and thus user doesn't know perf_task_clock.type.
+	 * However, allow user to open an event if user has passed correct type
+	 * in the attribute.
+	 */
 	if (event->attr.type != perf_task_clock.type)
 		return -ENOENT;
 
-- 
2.34.1