Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2532928rbb; Wed, 28 Feb 2024 05:04:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVsc+9Qp/+GBFYVGtpK0RcV2TdRBW9TQj/OSJh9HEsCm3hHux05nnvODAnt9gcD7sCx1wDhe92RA5Kf27ZwGwKuNwIMIacV7vgKX1K5oA== X-Google-Smtp-Source: AGHT+IGcV9Pdg/3nP6U99QNZM7E4XkPu5ppT6DxMuEspNfPZMAnQagjyIULjwsJsksf4swcKfAFM X-Received: by 2002:a17:90a:2d8b:b0:29a:a436:4dda with SMTP id p11-20020a17090a2d8b00b0029aa4364ddamr9827089pjd.0.1709125498973; Wed, 28 Feb 2024 05:04:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709125498; cv=pass; d=google.com; s=arc-20160816; b=TelA+6lPLrk3tkdNV2z07ZCmYYzHj1ZsbGyBDpTCSqArgR6jmlMbgJUF2jfgiyQe0L KaM6nRu2kqMoCS7pXpPfZFyaT0A3F0NSm+vcEFmd/FvuE3NjjF1bUG5hxMLIiSJPF7UN WpxO1f/vteO/izEce6yvVO/mMCIG7iWVfKyn+inzhpC3KuKEMW4wuu7dVmI4AwkC7UH6 yUp6gEzCJe6L8sVfnKVqkiJbcW9jLRVqBiCq7vdmFSiGaHRZkQpwiSHXX8SEa9+1GrYg 3NC4lLRBeH+m0WZkAUXZEaYeGS9tklPD4LXDB8OhZFfAEZES3aclazfRjiYBdEzi4Qpl 2lCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=jAVkysIrddkYfA1tLe0rVWGFMQxH9A+gv88vB1iCZTo=; fh=5lFYbExy09ckOQY5ohcdr3h7OiIXOcB/yDhe+ZZUjko=; b=wf0ODqw/rtr3eXsyOwmZf2WofqGvH486ZKy3wr9GQAKaOqWVAtuxnGAuYC95DCIozD juaKs3x+5XKjyhYIoBIJR0o5SMGLCbL36vtv1tEDu4dtoUkW846OdAQ5anVqN7PX8T2i 9Pg5H9TiG4sFQumJT60B3Wk//EwPEU6MC3rdBdUD5PHET/1ptobYtrVaEkPu7MaKoV15 YmO0RzuDUMYWcCQaVgbQXlqYX8RHZSnXKtbe8Bl4NMm0HKn/QcnckforQgEfEFOwQreN bx/bUpWihLqcZpYIcEiwCHvNPie73qLO0KHYTs6xQ1DJTafQ60LBDs59ElNVeB4OweNj Ggog==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X5jbiB9w; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-85057-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85057-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id fv8-20020a17090b0e8800b00299423e76b0si1306678pjb.75.2024.02.28.05.04.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 05:04:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85057-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X5jbiB9w; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-85057-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85057-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id AD001289560 for ; Wed, 28 Feb 2024 13:04:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7DED614A4D6; Wed, 28 Feb 2024 13:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X5jbiB9w" Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A20C3BBEE for ; Wed, 28 Feb 2024 13:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709125467; cv=none; b=C/FdODGdPMUr4vRMAAmzjQZ0IooMyeXu4z3xUnlgzXDxnpfR5jHYhHg8ubTSFAloB7hT9UG3Ywk2zl+MAAvX3q8FFo5kS7MMx1MpeXhnBA7ngdYZEndoqBdkO6E7S1PmwlVQR4NSAmbkCrZpdon5f7vmraIyK7cREqQAg/C+O8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709125467; c=relaxed/simple; bh=E8Q8BUTHPfJyeoU9Q6QdXQerQaQjnZ/2HuOscrhXz2w=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=gE98QsSzScbO68rOCvPEzfPudoGaUCrNjZAQEBbvF/HQ5WRQ/IQ6dGnEG+J1pDvuQpOF2NlZWbGAnxrsDnaG9jIT/1Pdf06LwKv9PTDXXRZ+pcR2qU4NOivxq1ug+TjS+hgYE/WKt0sycy+qXN15u9ig7r1iDgfeq7FahBZGTf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=X5jbiB9w; arc=none smtp.client-ip=209.85.219.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-dc236729a2bso5089410276.0 for ; Wed, 28 Feb 2024 05:04:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709125465; x=1709730265; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jAVkysIrddkYfA1tLe0rVWGFMQxH9A+gv88vB1iCZTo=; b=X5jbiB9wGoTpduk3FeUv1VZkPef+oGG/mEw4fNENnr7kFNQeMU/6JyPQLeR9GHr5jq x/u5j+zayDVBlfZsrK+paFkGUuMFpRZBxNbU67Ofwg7+1/ta1hilnGhCz5Kw0SzlzkPu mS9R+CW9OK7iJCcqhex1cBhyLVG4o/8MB7v107RExifcnlKpUlsRFk1khuiEbkvgmqCA eQEdiBxkpyVqtutG9tmGm8Ha0kwAOMX+/SiGh2UUSPSNSI1b/YyZI/DDOa/BLf/KCic4 +fatOeL4RChqvkY8QmwWaPOsEEM4cMRj6TWzOIL+AXQrxO4F7YmkhsHN842hseMKGHmX NDjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709125465; x=1709730265; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jAVkysIrddkYfA1tLe0rVWGFMQxH9A+gv88vB1iCZTo=; b=fhFqSWF5MdafhhuUIf0wPDl4UbBSsnRvUzPXtBsOgncYkhSN+H64BJF0fjCaNv41vb EbM6IJ7R91eAIPNqnbrOGL27jfjTvopZ9vxfC5dy4Epb8t40E7q9S3GL03+LVv2pZSG9 pyPrrFXIfMDDh502G4hmAt57gUhQT3qMVmyIF24136r73oGRnKW9A7iJhIuM5p4XOCgf 6LOw67cQdk1zJwDi0OQRPlRa9ABvZGtuigbS70jERVp9MaW33ePgTTvJeEWWjXyu87VB jmpuz1JM2uS+z8DjdB55y881LaMyALAc4fKDbTzbRKB6GHA8CKq9SMPFTHjbh+DHfJSk V7YA== X-Forwarded-Encrypted: i=1; AJvYcCULLxx8tL+sl1lYxwBHllFUNSe8A4fTGWTi6UOUuD3Gyflr3Bx9FFCh0SlpThfLV/+QkTaNO2S8XJN/mq6XD5DvgHE4O4KtJo4qrhp1 X-Gm-Message-State: AOJu0Yzy+HQek1AQlzhspSzxGCV3Z+CLTVIv+Aodc2m3iWgKlsjYL4Fn E7zDMiaAch7veoJ8CQspabNAqnfsK2fVel/BF6uKMeoEVx61TwZUB2mTeD0GvJn3DDaIJW926ze VhzOc1h37jotiqk2J+joKkv9OvZv2gkMqY4aXlSAingxrRFPk X-Received: by 2002:a25:4c89:0:b0:dc7:4951:5f8 with SMTP id z131-20020a254c89000000b00dc7495105f8mr2636701yba.22.1709125465317; Wed, 28 Feb 2024 05:04:25 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240221-fix-sh-mmcif-v2-0-5e521eb25ae4@linaro.org> In-Reply-To: <20240221-fix-sh-mmcif-v2-0-5e521eb25ae4@linaro.org> From: Ulf Hansson Date: Wed, 28 Feb 2024 14:03:49 +0100 Message-ID: Subject: Re: [PATCH v2 0/2] Try to fix the sg_mitet bugs in SH MMCIF To: Linus Walleij Cc: Geert Uytterhoeven , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" On Wed, 21 Feb 2024 at 22:23, Linus Walleij wrote: > > This adresses some bugs found after the introduction of the > memory iterator sg_miter to the sh mmcif driver. > > This was first just one patch for fixing the atomic bug, but > now also a second patch is needed to fix a semantic issue. > > Signed-off-by: Linus Walleij > --- > Changes in v2: > - Collect Geerts test tag on patch 1 > - Add a second patch fixing the problem with advancing to > the next sglist entry before reading/writing the first block and > after reading/writing each block in a multiblock operation. > - Link to v1: https://lore.kernel.org/r/20240220-fix-sh-mmcif-v1-1-b9d08a787c1f@linaro.org > > --- > Linus Walleij (2): > mmc: sh_mmcif: sg_miter does not need to be atomic > mmc: sh_mmcif: Advance sg_miter before reading blocks > > drivers/mmc/host/sh_mmcif.c | 46 +++++++++++++++++++++++++++++---------------- > 1 file changed, 30 insertions(+), 16 deletions(-) > --- Applied for next and by amending the commit message header as pointed out by Geert, thanks! Kind regards Uffe