Received-SPF: pass (google.com: domain of linux-kernel+bounces-85089-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 28 Feb 2024 21:27:24 +0800
From: Baoquan He <bhe@redhat.com>
To: Hari Bathini <hbathini@linux.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Kexec-ml <kexec@lists.infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Sourabh Jain <sourabhjain@linux.ibm.com>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH linux-next v2 0/3] powerpc/kexec: split CONFIG_CRASH_DUMP
 out from CONFIG_KEXEC_CORE
Message-ID: <Zd80vHHS2Jrobvtq@MiWiFi-R3L-srv>
References: <20240226103010.589537-1-hbathini@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240226103010.589537-1-hbathini@linux.ibm.com>

On 02/26/24 at 04:00pm, Hari Bathini wrote:
> This patch series is a follow-up to [1] based on discussions at [2]
> about additional work needed to get it working on powerpc.
> 
> The first patch in the series makes struct crash_mem available with or
> without CONFIG_CRASH_DUMP enabled. The next patch moves kdump specific
> code for kexec_file_load syscall under CONFIG_CRASH_DUMP and the last
> patch splits other kdump specific code under CONFIG_CRASH_DUMP and
> removes dependency with CONFIG_CRASH_DUMP for CONFIG_KEXEC_CORE.
> 
> [1] https://lore.kernel.org/all/20240124051254.67105-1-bhe@redhat.com/
> [2] https://lore.kernel.org/all/9101bb07-70f1-476c-bec9-ec67e9899744@linux.ibm.com/
> 
> Changes in v2:
> * Fixed a compile error for POWERNV build reported by Sourabh.
> 
> Hari Bathini (3):
>   kexec/kdump: make struct crash_mem available without CONFIG_CRASH_DUMP
>   powerpc/kexec: split CONFIG_KEXEC_FILE and CONFIG_CRASH_DUMP
>   powerpc/kdump: Split KEXEC_CORE and CRASH_DUMP dependency

I have acked patch 1. And patch 2 and 3 looks good to me, leave these
two to powerpc experts to have a careful reviewing. Thanks for these
great work.


> 
>  arch/powerpc/Kconfig                 |   9 +-
>  arch/powerpc/include/asm/kexec.h     |  98 +++++-----
>  arch/powerpc/kernel/prom.c           |   2 +-
>  arch/powerpc/kernel/setup-common.c   |   2 +-
>  arch/powerpc/kernel/smp.c            |   4 +-
>  arch/powerpc/kexec/Makefile          |   3 +-
>  arch/powerpc/kexec/core.c            |   4 +
>  arch/powerpc/kexec/elf_64.c          |   4 +-
>  arch/powerpc/kexec/file_load_64.c    | 269 ++++++++++++++-------------
>  arch/powerpc/platforms/powernv/smp.c |   2 +-
>  include/linux/crash_core.h           |  12 +-
>  11 files changed, 209 insertions(+), 200 deletions(-)
> 
> -- 
> 2.43.2
>