Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2586559rbb; Wed, 28 Feb 2024 06:34:13 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW/BPoDpmnDMMQbwE1TLiRfmVcciLIkh+BrPWtTKfWlFDoGcxnG5A2J1CpJPMB87g8JsNfPHovu3xPvlHp/2rdF4APcAa31zrsSKgFJ6A== X-Google-Smtp-Source: AGHT+IEeQH0XIaYn+cuEKSJ36YZOlZDmnmRcfTk2zO0RnGzuoFPiw7M1jjBcqQ6xq6YMVkPyo6z3 X-Received: by 2002:a05:620a:b15:b0:787:d1b8:3c93 with SMTP id t21-20020a05620a0b1500b00787d1b83c93mr4614738qkg.39.1709130853170; Wed, 28 Feb 2024 06:34:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709130853; cv=pass; d=google.com; s=arc-20160816; b=XqDDkCZpnkoZYp0oRVxtMSVTpdp867BdqObjRfxhNIUOetuA8DaxcsuuEgsFyD2P9q nMTQF9srq2roJvvbUkd0S1lWTw8iNw1W8Q/JqZWFl50PeoF/ViK2qrxfPPkRYrKZZcLh WKS3YeAPrIBkEbhOJhwGLg+sPJCpt8SLySKFbB59GBh7l1MO9e8GRdT2gHa4v1AhtZZS bbuXl44css9bLy1mZR+fytnqmUydKZH1MM7P/i/fm+zkYW4LyaWWDI65QjfCJ0Q9ccgp qCFIhXa8z2oxDzDbBMLoUT/uWgtbYm4ojwNSdpYddtwgUBr901+ZvFwCPRHrKE1tVkE1 QN8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=d1mEAXP7DKCDBfN5opvb9wO0zP1+uFHMr3oFHAqQ9eY=; fh=56n3XC7nK36TXsMsvLSL+lOgw7sWcEakaPad0o7ByG4=; b=KTEWyUV6DkDQh+8zUcepRzjYsCA+gIgSKCnHHHGP289kfh7Db4fvVRIbGl3C0SWyi2 Ot31P7PdgVHKIwjlhUbRPVd+8lmxOmP+96pDbSXHnQoxHlAuIFkvCOfDuNu8aUSK+FF6 tPBHg7eN9iBV3/N68PBhkeyt3bquec0zxAE/nxB0hsj8ZayqxcnWKkZ78qmqwkbXlZCC hVrgWC9PtCda8XFlw9S/WNYoQCIogslm9se91Pc96ynoxr2wd3hh7/dHGO4S7fQgHQhf ftXbROcbvVkLSfzxYM/40eyRLMtOItTGe+upoVv4Cmec/iZLHie5AZwKKi2eXzEU5zxA lT+w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tykAATqm; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-85189-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85189-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id bk3-20020a05620a1a0300b00787ac6c856bsi11249416qkb.362.2024.02.28.06.34.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 06:34:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85189-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tykAATqm; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-85189-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85189-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E5DBD1C2258A for ; Wed, 28 Feb 2024 14:34:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2916D15A4A6; Wed, 28 Feb 2024 14:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tykAATqm" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 411A914EFCD; Wed, 28 Feb 2024 14:34:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709130845; cv=none; b=sXkfcAl8s5OG0UqKVurf4mpMru7w8ssqOZWuo/Aut5TroQuN4fB55DbUsUvUFbbm9BsWM5EBozoq9NhSVq1KybAco+AHPur22qJ7aH6q0Gq74Xgri70N4pFnNePqEtxStA6GQGH/IimYbV3A/JYO+o3bjXFo8zaFufWJbZ58w/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709130845; c=relaxed/simple; bh=srM0SpEWHS7SZXQGlLSr6ylprr3w8Mmldv4L7MWNCZs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hJK5QJIZyPtZKKaRPAp5GOeHzWm5DIFv/tdl8Az6sJdcPh1BuAenM7NPHivRAknDtYLHPWOegs7EeHFPlv1h7n8PFrOSQm5ULOWV6uHRRnuRxqtogwgy+FT2vsHWzZppS8Ab4SAhkfjWapuBjjiZsXdWKj1JACg8pijAXK/h/t8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tykAATqm; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C81EC433C7; Wed, 28 Feb 2024 14:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709130844; bh=srM0SpEWHS7SZXQGlLSr6ylprr3w8Mmldv4L7MWNCZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tykAATqmIQt3vy30l4Tr3k28GTDF8BasUcuxCtMy2Xn/7V10FyR/YDYOyufXrO5Pj hMfSTVqxj3/YCaaEB13GtYgsCVeDf7CIO9fF+3K1Qfv17g7mBS5Z1MVzB5J8QgWBWc 3eXk88PbnlY7/UHmk791qRDQuYWBiu+Mao7BaoPrDUqKukuVsBrXTd6jEAnnGawmbx AzNpnNNIBPm5bjQ4a3OMS8qpyC9rk2mn0o+P2gUW8qyQ95z3vnjQyKEDrb25a3yO4F j6x9X3k/Tdg92KAmESE8PT7vQe+Etl8lfq+8Y0KJVdkvrEdi7b/ovv10Zd6bYuQFsz f9zYZIimnJwRg== Date: Wed, 28 Feb 2024 14:34:00 +0000 From: Simon Horman To: Breno Leitao Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dsahern@kernel.org, Jiri Pirko , Daniel Borkmann , Lorenzo Bianconi , Coco Li Subject: Re: [PATCH net-next 1/2] net: get stats64 if device if driver is configured Message-ID: <20240228143400.GG292522@kernel.org> References: <20240228113125.3473685-1-leitao@debian.org> <20240228113125.3473685-2-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240228113125.3473685-2-leitao@debian.org> On Wed, Feb 28, 2024 at 03:31:21AM -0800, Breno Leitao wrote: > If the network driver is relying in the net core to do stats allocation, > then we want to dev_get_tstats64() instead of netdev_stats_to_stats64(), > since there are per-cpu stats that needs to be taken in consideration. > > This will also simplify the drivers in regard to statistics. Once the > driver sets NETDEV_PCPU_STAT_TSTATS, it doesn't not need to allocate the > stacks, neither it needs to set `.ndo_get_stats64 = dev_get_tstats64` > for the generic stats collection function anymore. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman