Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2586764rbb; Wed, 28 Feb 2024 06:34:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW3K8RSBqUVGU9ySHVQ3hWOwaBzaXONYFCWSuwG/SPfsmU6olffCmLz2yCfjFxQY6EYUuBwfSxMFDkZv6CFJLE2dUIC2Jq5qy4jheempA== X-Google-Smtp-Source: AGHT+IGJzvX7mXdl6ZerIqspRw+V+fQ4YYVRkopgPSJ3k+KL67wwX6W9nNdTcNqHMIMb47JvrzDG X-Received: by 2002:a05:6870:3513:b0:21f:c785:b76a with SMTP id k19-20020a056870351300b0021fc785b76amr13505727oah.7.1709130868653; Wed, 28 Feb 2024 06:34:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709130868; cv=pass; d=google.com; s=arc-20160816; b=Iix1WO1p5dh+qtRSUfrPwLPKP9sjV+FyV3NwBlY3YC7pXzs7+cegkhSmOWUgmtxPQ7 r0TJu/RhHeHY6dLyddSM6FE8aC029IUfGONsSPWSaLdxl9i/6CDmGauEUoAJqRVBGRVC Gx5U3nAHDDZEbUT2qcijgRle6J6zXzVHDM7Zyy3giaPmxbX1FI/jbSTHkfQww+3wsopl 6MblAD4iExXy0ogaAGwmtYXwm+g0ZH0V5dFcoeFnqc4nWBIe4QohQfSEMkURVmoZ5Bez numiKpUBXpE0J3rIXinsMUQX81FQJMtG4Zy6EF2MyKPHI97oRa34G8c7xCNvH6tNSSQk UY4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NLhJH4QxEV41u0wAXTrEnq9ZjuVQvuiUXtFvUc2RmFA=; fh=p0B6/syn9glYka1eva8aBnrWoVvWXj0NW4+Nam4mGXE=; b=QrYGnlXuA/lVpKR9pw0RroizG2vJzQP3Xap+EO528hKSJjWGccag+G10YmLnXHRH2r BKDSA1ngY2V+SsBYe0jYhUXi0hoHfY/2FPofCFtkkbszJEm6Re5GAH4Ha+aZ5U+trt/8 QAyGlkPUHlB0HAz9QE6h3Q3bBWXhbXMvKu1RpjDZsNGrWoFg9n7NeYwZxAKgCi/V4UcJ 5OiWZ8pWU0Fx9xczWxQBnjnJgzsn7/3Ruu2ujSo4/5AaghoxR4OpOaBEYK7syvZtK6ko QNVh8/CGEkEA2tUW0nDgq+SPGM+Ke0b6s2OAB0wsRfF50u+7qTljiG0ydx2AJ/Ggnie/ xMHw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O+du1MYx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-85190-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85190-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id cb26-20020a05622a1f9a00b0042eb2aed0easi711190qtb.542.2024.02.28.06.34.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 06:34:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85190-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O+du1MYx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-85190-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85190-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3BDDA1C23134 for ; Wed, 28 Feb 2024 14:34:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 288D315A4AF; Wed, 28 Feb 2024 14:34:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O+du1MYx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4567312E1DD; Wed, 28 Feb 2024 14:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709130860; cv=none; b=ptB9jsW1gfOkUyTFTJEFPO79doofijR4ckUO5+t4AswpqgufKtn+ZkkaQFbDsJ+qGVlRoTlWSQvTI8zDGpWAUcbPWpVFEaAaxunLxuQ//EWWS5lBcZ5R9vzQ2bHrz80VuBf8G3zA8YlAlt6dMYHMjl6ZyptF6/Y99gimzyQ3l+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709130860; c=relaxed/simple; bh=SohApJ8J7//9aXWrTz6SAXiRplz8+1lqaQMKmo/qSTE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IgYWYjLCEonbDeSkqtPAiH3jI4Z6EG5+gOABm3c12kSvMnJ7rGbYWTu898ZA0mdiiTFbHvZStYk0WrdC5nlathDj5xaCEB3ywRXAe40LL7d4XbZ2RxLC24hpNMIJ1UvcPUOoAY9OXpKonpCY2fKFj8hivhweo+n6ZUUOwg8hX6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O+du1MYx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1766AC433F1; Wed, 28 Feb 2024 14:34:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709130859; bh=SohApJ8J7//9aXWrTz6SAXiRplz8+1lqaQMKmo/qSTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O+du1MYxHQMnDNJs/xhw9UfuaPmjKnuSo+wJy0m5sp1aLu9KdfLge/BMZwJtECfdZ fwaZD3vuCLwOW2WGCQFfvJzqFPfG/vZDaJVmS+xQPggxiLiOy4cZWWYx1MpBPb3LfW 9kFNWrMEOOdfGOPiX8I6w1uVuA2P0g/+XF/USGiRp4dR3ERIs9FzlFsWgjnIbQwwMc YcIpcCfI+ZZGxAF20ch4JjhAff8u+RjCmB1Td6BtckzuvENtQYt1q3Y+/N9te2QjcU IBf4ju4OWsW9mUDhA2r9oifgdcKpKw23J5bYc1K7NxaqilCaVk37g+/Utfm9ELupR9 miagPLEMIIfWA== Date: Wed, 28 Feb 2024 14:34:16 +0000 From: Simon Horman To: Breno Leitao Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, David Ahern , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: sit: Do not set .ndo_get_stats64 Message-ID: <20240228143416.GH292522@kernel.org> References: <20240228113125.3473685-1-leitao@debian.org> <20240228113125.3473685-3-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240228113125.3473685-3-leitao@debian.org> On Wed, Feb 28, 2024 at 03:31:22AM -0800, Breno Leitao wrote: > If the driver is using the network core allocation mechanism, by setting > NETDEV_PCPU_STAT_TSTATS, as this driver is, then, it doesn't need to set > the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Since > the network core calls it automatically, and .ndo_get_stats64 should > only be set if the driver needs special treatment. > > This simplifies the driver, since all the generic statistics is now > handled by core. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman