Received-SPF: pass (google.com: domain of linux-kernel+bounces-85204-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 28 Feb 2024 09:47:03 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Richard Chang <richardycc@google.com>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
 akpm@linux-foundation.org, liumartin@google.com, surenb@google.com,
 minchan@kernel.org, linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm: add alloc_contig_migrate_range allocation
 statistics
Message-ID: <20240228094703.0aeb5ae5@gandalf.local.home>
In-Reply-To: <20240228051127.2859472-1-richardycc@google.com>
References: <20240226120728.3f495fa7@gandalf.local.home>
	<20240228051127.2859472-1-richardycc@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 28 Feb 2024 05:11:17 +0000
Richard Chang <richardycc@google.com> wrote:

> alloc_contig_migrate_range has every information to be able to
> understand big contiguous allocation latency. For example, how many
> pages are migrated, how many times they were needed to unmap from
> page tables.
> 
> This patch adds the trace event to collect the allocation statistics.
> In the field, it was quite useful to understand CMA allocation
> latency.
> 
> Signed-off-by: Richard Chang <richardycc@google.com>
> ---
> * from v1 - https://lore.kernel.org/linux-mm/20240226100045.2083962-1-richardycc@google.com/
>   * Move the trace event int field to the end of the longs - rostedt
>   * Do the calculation only when tracing is enabled - rostedt
> 
>  include/trace/events/kmem.h | 38 +++++++++++++++++++++++++++++++++++++
>  mm/internal.h               |  3 ++-
>  mm/page_alloc.c             | 32 ++++++++++++++++++++++++++-----
>  mm/page_isolation.c         |  2 +-
>  4 files changed, 68 insertions(+), 7 deletions(-)
> 
> diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h
> index 58688768ef0f..6e62cc64cd92 100644
> --- a/include/trace/events/kmem.h
> +++ b/include/trace/events/kmem.h
> @@ -304,6 +304,44 @@ TRACE_EVENT(mm_page_alloc_extfrag,
>  		__entry->change_ownership)
>  );
>  
> +TRACE_EVENT(mm_alloc_contig_migrate_range_info,
> +
> +	TP_PROTO(unsigned long start,
> +		 unsigned long end,
> +		 unsigned long nr_migrated,
> +		 unsigned long nr_reclaimed,
> +		 unsigned long nr_mapped,
> +		 int migratetype),

Well, you didn't need to change the order of the parameters.

Anyway, from a tracing point of view:

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org.

-- Steve

> +
> +	TP_ARGS(start, end, nr_migrated, nr_reclaimed, nr_mapped, migratetype),
> +
> +	TP_STRUCT__entry(
> +		__field(unsigned long, start)
> +		__field(unsigned long, end)
> +		__field(unsigned long, nr_migrated)
> +		__field(unsigned long, nr_reclaimed)
> +		__field(unsigned long, nr_mapped)
> +		__field(int, migratetype)
> +	),
> +