Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2598148rbb; Wed, 28 Feb 2024 06:57:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWgq4efvHGxE81ozLcE6RLxL2g71938IMQZfgSsTRobw8sIwMgeq4DvndLK8mETXXGYtHB9ZT3Ez+mtgCSRYAnvqqTUwbGomHXtmqgSug== X-Google-Smtp-Source: AGHT+IGm8B9tlkzVTPy27qMTcnPh64xeHbximS9AMhWB9I83uF03A/Bw/d0d4VvF6CBkdwoST5jN X-Received: by 2002:a05:6402:3456:b0:564:7007:e14c with SMTP id l22-20020a056402345600b005647007e14cmr9040457edc.22.1709132227452; Wed, 28 Feb 2024 06:57:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709132227; cv=pass; d=google.com; s=arc-20160816; b=H9b1FLi1chbfpp8DfkksMOsvOWnqB869tNqSutcfnwjA8kRLM+cj728FwBHWs+Y7Ng zjgjre5lMqM57tBzI1dVST2G8F+hq1D0KEwLRl0fJGUHm4df74YM8jlVOFAzXCi/T2Cm GHV+da1hnATi0l2Nyq1YlglhXdYKwRlnsDNeWsK6IML6aAyH+OaA4ef4nJsnhQRcgJA2 dj6wU6C+zL5YzonGpJ5FVT5BSxoQHytfrETWkyctiyJSTFi5tFQN5ueTsAtOzgQR/EqR st2DPcF9kBm2doCi/MJaVHm4Hujio9heREMGHr3+exIn88koYDT8eMAnJxReAMHbubFj xnWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=mj0JnoSewVwlVSZlHt4DT/SaUpGZF5EhEmAbDbXm/cA=; fh=rg7l09K/VwGwR9MzXw8BMozirXFGNTjLVcG80ROm8gA=; b=ei7sclhGMDXAdLf9RyugzjGAbFoL+gkox6cGAOA8hWetX8t/vXb6sgCD9fL5w8NrgU EE2UowSpVZMUko9tkUIXCURFjzV3ckEg8ufkJBe9xUuDgHbbxTXISH5raoZrxBR+Ymet 19Nn51k+3HFb6u+ohf8WgJbhSDHMPTTy6VghBXDRI4UHLyDVAr6+XP/64XUJkogl0+JV KTVyttWLG1pd6KS09DU34xbOIvcuwPzY4DJRBz+IAsKlaVWHwE19KMTGrf9MiiOsRUhv FyVTCe+JRf46yatmT3czobMjwGALUwz39RMQgD7Mq85eNMaRhu6IfpcoIs6KMMLQpL8S FlXQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-85225-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85225-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id e26-20020a50a69a000000b00564c1ac8428si1798488edc.273.2024.02.28.06.57.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 06:57:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85225-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-85225-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85225-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 18AA31F289C0 for ; Wed, 28 Feb 2024 14:56:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8747715B986; Wed, 28 Feb 2024 14:56:26 +0000 (UTC) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 617DF15B96D; Wed, 28 Feb 2024 14:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709132186; cv=none; b=jUxiwxV9TDRKTT1ZjgbsBckEzHX3WC+NKyk4uLYUGe9yXlmR6Hu38RhokeqsyPzwONjKof9NAaY/e7cCPif60/Ifomu+V6KhRMoNwjc1JPr25pTQIoM79FrbILg5v5ZiYcZiNjzP5HKvWnowFMVgHoFlGFwLhpl/6EUaaDwqMFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709132186; c=relaxed/simple; bh=tvMMFT7IKjYWtuCyDMSxTCVQ+1ldB6waLn5e3CF/u9Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UE+xQv8NM2qOnFizW9BiVLb1gugkw95JWspRsFNwI4bJ6CQRAo1bu5qe/4f4z6FJgqjNkjwzBZFjsgvqPoUJWvdTosQxRspoArVH2Xldgvs/5JdhW+stGw7YAD9ETHpiZ25VALpAtuFgyrOeKwP23YMxJdPFANSsrgzGGnrzSec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-412ae15b06fso13146495e9.1; Wed, 28 Feb 2024 06:56:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709132183; x=1709736983; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mj0JnoSewVwlVSZlHt4DT/SaUpGZF5EhEmAbDbXm/cA=; b=hTUk7Bkp8AaUhTFWN/q+Kuh+G6wjM/P/Ct0Y9KYtzgOT92afszZDRL55JMBdVKPNqk JBMmPsGxk8WSjSuOPdepfKIfEGB3DDClVdcUgvmCqzkyADUnZ0VYIV3TmtM1sZkecFAp zxFWAMOItljSV0+MPrZloZIIpw1p412kz0i9uzw2OpOKVF185N95z9S/K1LdrfFEUSC/ tCfBlBj+mkS/n4856mcwGsbozPwyj1UGwyF28SBVfoelIh2aGFpo57nx9JGymz8GLzWJ wEUCb9BB8tN2R6oWxs03CtHrpdV9BYqDcTEcTeZAX8tiFCnuXEAkvPnpYMNzyeUknw0G bw8A== X-Forwarded-Encrypted: i=1; AJvYcCWIA0aNMjlzzKE/k0IvSvkgX/WVQ/NkERN9bvEiNQN7joLBZugAStOiN/cvMweubfkrlZuY6d+9s7b+LVWXJJXf6E9Q5gf77fTHIrFjPisWEAH1nN8NDJA8kVcZxE5uILer75sy X-Gm-Message-State: AOJu0YzRTeNy/5afz3NhP1rWEnnIZpT5W4MOxRUASksZ1u7OHcgHwD1J s34sxFDQkTnElxO+FWfGe0dL+i2WUTQcyp5gu5k5n5aNB6+hroWim3L5rpzs X-Received: by 2002:a05:600c:a05:b0:412:8fde:ac46 with SMTP id z5-20020a05600c0a0500b004128fdeac46mr10838502wmp.21.1709132182442; Wed, 28 Feb 2024 06:56:22 -0800 (PST) Received: from gmail.com (fwdproxy-lla-119.fbsv.net. [2a03:2880:30ff:77::face:b00c]) by smtp.gmail.com with ESMTPSA id u6-20020a05600c00c600b0041253d0acd6sm2305404wmm.47.2024.02.28.06.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 06:56:21 -0800 (PST) Date: Wed, 28 Feb 2024 06:56:19 -0800 From: Breno Leitao To: Arnd Bergmann Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arnd Bergmann , Roger Quadros , Siddharth Vadapalli , Grygorii Strashko , Dan Carpenter , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw-qos: fix non-bql configs Message-ID: References: <20240228140413.1862310-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240228140413.1862310-1-arnd@kernel.org> On Wed, Feb 28, 2024 at 03:03:10PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > It is now possible to disable BQL, but that causes cpsw to break: > > drivers/net/ethernet/ti/am65-cpsw-nuss.c:297:28: error: no member named 'dql' in 'struct netdev_queue' > 297 | dql_avail(&netif_txq->dql), > > Add an #ifdef check for CONFIG_BQL around this usage. I confirmed that all other cases where queue->dql is accessed, it is inside a #ifdef CONFIG_BQL block, so, seems appropriate doing the same here. > Fixes: ea7f3cfaa588 ("net: bql: allow the config to be disabled") > Signed-off-by: Arnd Bergmann Reviwed-by: Breno Leitao