Received-SPF: pass (google.com: domain of linux-kernel+bounces-85249-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 28 Feb 2024 07:18:32 -0800
From: Luis Chamberlain <mcgrof@kernel.org>
To: John Garry <john.g.garry@oracle.com>
Cc: russ.weight@linux.dev, gregkh@linuxfoundation.org, rafael@kernel.org,
	linux-kernel@vger.kernel.org, masahiroy@kernel.org
Subject: Re: [PATCH] firmware_loader: Use init_utsname()->release
Message-ID: <Zd9OyMTgtYcFSEq3@bombadil.infradead.org>
References: <20240222145819.96646-1-john.g.garry@oracle.com>
 <Zddt-U-6SdxkxqmD@bombadil.infradead.org>
 <51483aaf-d64a-4eee-b256-ab126483ad6c@oracle.com>
 <Zdy9gKO5Q6K4IE8J@bombadil.infradead.org>
 <ZdzGF9bxLn3Slbgi@bombadil.infradead.org>
 <cb0c185c-54f8-4b43-856f-685cc5ed3fc4@oracle.com>
 <Zd3cz7yYezir-P7e@bombadil.infradead.org>
 <e88b76c5-1b13-4ad7-a97d-c34722cfde19@oracle.com>
 <Zd3oke0pAL2G05Rj@bombadil.infradead.org>
 <a07db8f8-39f8-44ad-b466-10ac02f3da13@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a07db8f8-39f8-44ad-b466-10ac02f3da13@oracle.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>

On Wed, Feb 28, 2024 at 12:31:42PM +0000, John Garry wrote:
> On 27/02/2024 13:50, Luis Chamberlain wrote:
> > On Tue, Feb 27, 2024 at 01:02:26PM +0000, John Garry wrote:
> > > On 27/02/2024 12:59, Luis Chamberlain wrote:
> > > > What kernel are you seeing this issue on?
> > > I was testing v6.8-rc5 last week
> > I cannot reproduce a hung task there either on that kernel.
> > 
> > I see this:
> > 
> > sysfs: cannot create duplicate filename '/devices/virtual/misc/test_firmware/nope-test-firmware.bin'
> > 
> > But these are expected as the selftests tries silly things to ensure
> > they are not allowed.
> > 
> > If you can reproduce it there, it would be appreciated if you look underneath
> > the hood a bit, or share anything glaring and obvious which may help
> > reproduce this.
> 
> Update: commenting-out /lib/udev/rules.d/50-firmware.rules seems to make the
> test reliably pass for v6.8-rc5,

Great, note that if you had a hung task even with the udev rule that is
not expected and is indicative of a bug I cannot reproduce.

> but not with my patch on top - I still get
> a hang there. I'll investigate that hang with my patch.

So your hang is with the udev rule on vanilla v6.8-rc5 ? Because for the
life of me, I don't see it.

  Luis