Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2632932rbb; Wed, 28 Feb 2024 07:52:38 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWigPSzTHJ98BcjtFY71TkqW2tyBTmEwqKG95ZLYf6ErZN4rFGYej2NW1kUiz45Fo5kyYxip2SZnyjW3mciv6PLfe5pabM5/Tl/zIrtEA== X-Google-Smtp-Source: AGHT+IGgrO+T59PPCPf++Mh5nQM0hyZ/PM3YWX20t3hkzK6FqK0WaUj+qSIBBoOf7B5u9NQazvkE X-Received: by 2002:a17:902:cece:b0:1d7:2e86:fb2a with SMTP id d14-20020a170902cece00b001d72e86fb2amr14956994plg.65.1709135558481; Wed, 28 Feb 2024 07:52:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709135558; cv=pass; d=google.com; s=arc-20160816; b=BEr9piJgf4Y/Fy43N/fAw3dIY6pxES5OhiAEeo+myLjmiiyyi/bFgI7eK5nxEy7MAQ 8PNCNaetqnRrzSn+tdArBOzMqEAcb864iPiz1WGJ2oGgLmRXrNgvKg5GcdGh/UWtnJvc FpcHP92wHj+QRMx1Z5YbAB/qUiB+KvAJusUla09pHwroDnEEZ2EM8XhjkYfqom+PBRI2 plifb4w7qcoc34JwmtwiHAHqFzhEe3pEb+Xb3rM/BnPFlScCf3KYONeT9y5RhOPVNtmt tzI5Mx0z+DtFMn4C2xxdJczg99tdPZI9YnFL26Rgths4jDLo5WXGNAhfvyr0etPPLwq2 w17Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Rk0elCEWWD5C49R32A34nSbo10R7BJHy8/hk4WpYMPo=; fh=RG2x46LnYOoX304eOwnWpIsHHIbyKdjszDCwmRGbAqw=; b=l1DnUogn3Qf24pD2IVLfFi9qrHJikUMSWmm7t5kwTR0f5q6gNlW/LrQo8NiKh08cnk PZPDPbLFQLci3h1QMNkzFn0zAGAWzd8mzLg5xQBH1kV6kqkKqxir2UzH5yUlQNHspdLa ZlUA9aEpzadoKNGNoDbzcpFKO9+8COGgM8Hs2UntDoVlW/mmm0SINk6Tj/krAqDrDsDY X5RzYwESlraBTUyEqtvcLDYMA1c4j7zJG/EAnnMwmJXBbyksTGE1OJ2xMretkYHPfT+S HQNbDjTQkD0uKUjsl0O5S8i6aO+oEc871TJun1CsFOu9b/RziXzkQiY76qO04/xpFPBX 3gbg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PVxFofiZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-85259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85259-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id i14-20020a17090332ce00b001dccb048434si1352472plr.65.2024.02.28.07.52.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 07:52:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PVxFofiZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-85259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85259-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 30E6BB23DCC for ; Wed, 28 Feb 2024 15:26:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 36B4E15CD44; Wed, 28 Feb 2024 15:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PVxFofiZ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E21C612FC; Wed, 28 Feb 2024 15:25:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709133957; cv=none; b=Yv2emJ1GNr6vHeIE556e0WIm1UMyz3txoaM5AeoZKr2yaXyjVdBo7S/GRTH0OxnMkUQKYx4AykLNsrD+ZnnbFVMNTHKy1gOAa7tJgKFjg6QByzBuys5jzpQBXKiVPqXTf8nJuwYT8yTZOlQ1wpg6DkXj4UsIX1lI/8ZslcJdlKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709133957; c=relaxed/simple; bh=zRhL6sA95yD5HfEybdKfbjQx6fTtohacYCQNOXDFAKI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k1ATUx6zRjREY3HvSo/Kon/nTOeMBDEkL0e8BKe7TZIfQG0YLwCMBCS9RMbGIR/qSpBYldbJMZjF03rb6+a9AOTK3Gg8BDfAZoyGphlevQA8apwPNJ4AmJPgvxqPYztVW2Lq31WmtQe8FmIOtI8c8aZVQB05A+Q1OzxHORxbt5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PVxFofiZ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 774A9C433C7; Wed, 28 Feb 2024 15:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709133956; bh=zRhL6sA95yD5HfEybdKfbjQx6fTtohacYCQNOXDFAKI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PVxFofiZQhAAlusqbPKfLm+8kUCeKQH8L+YN4JiakSg/Y1tGk4WxBRClGRfSjC7yF 3n74IYopcNXHL+OzlB8+oRGczB5/9vtbSCVrHssIxiGnVm5WwQX7Oqtgnrc8k5F/L1 q8kB4LlRNzzwp/BfVzgIzv0N+NYn3tnZiW7/Ql3lsfz2dDsrgZocRDCMySEVoQvvcP jlYiT3cMoQrHofdSPms3BbZjUNVyDvglcGYU5ckvMEpn/ch/7FxdRPP4kyrll3IEPB rGICnDD2k/MuI+ZFhczwPN2aMalyADk33gUyTZlH+wqMfea7o1Fepu61XlkDD4n8Mt 0W03SwNydpIAg== Date: Wed, 28 Feb 2024 07:25:55 -0800 From: Jakub Kicinski To: Arnd Bergmann Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Breno Leitao , Arnd Bergmann , Roger Quadros , Siddharth Vadapalli , Grygorii Strashko , Dan Carpenter , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw-qos: fix non-bql configs Message-ID: <20240228072555.428e0312@kernel.org> In-Reply-To: <20240228140413.1862310-1-arnd@kernel.org> References: <20240228140413.1862310-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 28 Feb 2024 15:03:10 +0100 Arnd Bergmann wrote: > +#ifdef CONFIG_BQL > dql_avail(&netif_txq->dql), > +#else > + 0, > +#endif Same exact code exists in qdisc_avail_bulklimit() How about we add static inline in netdevice.h wrapping this, like we do for other BQL related functionality? (taking in txq as the argument)