Received-SPF: pass (google.com: domain of linux-kernel+bounces-85347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 28 Feb 2024 08:16:23 -0800
In-Reply-To: <12f0b643-e2e8-8a9a-b264-5c7c460f1a24@oracle.com>
Precedence: bulk
Mime-Version: 1.0
References: <20240228024147.41573-1-seanjc@google.com> <20240228024147.41573-4-seanjc@google.com>
 <12f0b643-e2e8-8a9a-b264-5c7c460f1a24@oracle.com>
Message-ID: <Zd9cV8bnFuJbXx5Y@google.com>
Subject: Re: [PATCH 03/16] KVM: x86: Define more SEV+ page fault error
 bits/flags for #NPF
From: Sean Christopherson <seanjc@google.com>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Yan Zhao <yan.y.zhao@intel.com>, Isaku Yamahata <isaku.yamahata@intel.com>, 
	Michael Roth <michael.roth@amd.com>, Yu Zhang <yu.c.zhang@linux.intel.com>, 
	Chao Peng <chao.p.peng@linux.intel.com>, Fuad Tabba <tabba@google.com>, 
	David Matlack <dmatlack@google.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 27, 2024, Dongli Zhang wrote:
>=20
>=20
> On 2/27/24 18:41, Sean Christopherson wrote:
> > Define more #NPF error code flags that are relevant to SEV+ (mostly SNP=
)
> > guests, as specified by the APM:
> >=20
> >  * Bit 34 (ENC):   Set to 1 if the guest=E2=80=99s effective C-bit was =
1, 0 otherwise.
> >  * Bit 35 (SIZEM): Set to 1 if the fault was caused by a size mismatch =
between
> >                    PVALIDATE or RMPADJUST and the RMP, 0 otherwise.
> >  * Bit 36 (VMPL):  Set to 1 if the fault was caused by a VMPL permissio=
n
> >                    check failure, 0 otherwise.
> >  * Bit 37 (SSS):   Set to VMPL permission mask SSS (bit 4) value if Vmp=
lSSS is
> >                    enabled.
>=20
> The above bits 34-37 do not match with the bits 31,34-36 in the patch.

Doh, good catch.  I copy+pasted this from the APM, but the RMP bit is defin=
ed
slightly earlier in the APM, and I missed SSS.  I'll fixup the changelog to=
 talk
about RMO, and I think I'll add SSS in v2; at the very least, having the #d=
efine
will make it clear which bits are used.

Thanks!