Received-SPF: pass (google.com: domain of linux-kernel+bounces-85372-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <0786d006-9ccf-4ba2-8a1f-452711797a81@oracle.com>
Date: Wed, 28 Feb 2024 16:26:38 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: libsas: Fix disk not being scanned in after being
 removed
To: yangxingui <yangxingui@huawei.com>, yanaijie@huawei.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        damien.lemoal@opensource.wdc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, prime.zeng@hisilicon.com,
        chenxiang66@hisilicon.com, kangfenglong@huawei.com
References: <20240221073159.29408-1-yangxingui@huawei.com>
 <d765d2c5-3451-4519-a5e1-9e8f28dcd6b3@oracle.com>
 <693dec74-1750-191e-cbc3-37f993d165ac@huawei.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <693dec74-1750-191e-cbc3-37f993d165ac@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dWlRTldjbmE0cEdFSGQwK1ByUTNnUnlsU25MOGF0YlRoUWJVTnorSGl6a1pQ?=
 =?utf-8?B?cU1wbDQ5T1lrZitkVEpmY1kwM3BhMzdzTDM5QUsyQlFYd3MvREt5VENFQnVK?=
 =?utf-8?B?Y1FuYlZXSlBiMXFjWDAycmVXWjNRMUhLOTNPTkVaTkIySDBpUU1jU1NueUZH?=
 =?utf-8?B?bk40MFY2aFAwemJnMXp4a3FzTE5IZTkvZ1ZiM3IvQTZWejg5RWdsbDZCN0tK?=
 =?utf-8?B?WEJTbnFVdjlYMHEycmpUU3NWck1pb0JFTmpkZnFYMU1RcWxEeGh0L0lCZDly?=
 =?utf-8?B?azhEWG9INUNPbFlVbEdGa2J2TTgvUnd1dCs0WTRSQjhuUzBTWUZ1RENvSTZr?=
 =?utf-8?B?UWVTZk55UzQ2ck5MaVpiay9EVWE1UWtYeTZUWVIyZmlyem82MVRFREoySUcy?=
 =?utf-8?B?ZkhlYUpsUU10ZkVBY1lsNTN3MlBleHVrNG5RQjlmelA4T2xqcXBFbmRuRGdC?=
 =?utf-8?B?aUh2T29Ja3NLd0xBSGU2NHo1RkRxbmorbElZd3EwbzcvbXlhT3BsTERnV0FC?=
 =?utf-8?B?dnluUTZTR1k2c21pWHF4TW0zUkZsVk85dWRxYVEvVzZqMGRJY1JMR0JESWp4?=
 =?utf-8?B?R2ZLNFFxSWxhVHVad2cwenRkRkltaFlETzZSdjFLQ0lrcjBPWTFiQkp6Q1Z5?=
 =?utf-8?B?c1hLSm5pUlpvODBkOFYzRFBwdElBaEsvb3lEbjFpSHUzdnBmaGhWa1RlY0tP?=
 =?utf-8?B?aTA4ZU1NSktPa25zSDlHdWRlbkRnVmhIcFhnRm0xRjVPV2c4c0k3RWhsZEx5?=
 =?utf-8?B?NEpLVFUvZkFMMGRPUTdZYlJCK3dJN2o3dS80ZGxpQUJlaXA0cDZrQTF2TTEz?=
 =?utf-8?B?TVJLUXZJUmxDK1Y0d1VPeUpaOVRhY2xNTjYwMUdSVFZ0MmNhQ29oZ2FoYldD?=
 =?utf-8?B?SGIzWS9FTlJoVlozaXFyZUhPNWU4amQ3THhGbVJrWm4wdGhjeVpoczRrbmJR?=
 =?utf-8?B?eW5zbzFQQlduMUJNaGlka2xQdjZvVFFrZjhXTTF4TnBOd3htbnA2alFPc1V6?=
 =?utf-8?B?L2EySXoyRVFVd2FHTDVhRGI1dC92SG9Jbi9QZ1dXVGJYVHlQQWxtRlNyOXF4?=
 =?utf-8?B?WkhIWTNSYm5DeHYyeVBHRTdnMXdwdTlRZ1drVU54MTg4NTlDWUJ2RGttTitK?=
 =?utf-8?B?TEJoNktERTlINDlka0gxRUtvZEZFYjg4WGVLcTh5QkVVY01id3NpV0ZGcEwv?=
 =?utf-8?B?SlZ3RUlXOWxOcHJsWUZvRlBsYXE4OEhWK01sOXVqd1h1c1FHajFvR3l6TzRP?=
 =?utf-8?B?d2JGWjI1eEFjSUJTTk0wOFZpZFlBYlhVQlVSOWNhcExjeHZZa0l6OFRHZ210?=
 =?utf-8?B?clRXd3lkN0NLQm5Pc0Vwb29jY0cweitaa01aL0F5L0lLRFJqeCtBVzJnOWNx?=
 =?utf-8?B?U2N3VzNpYUJabjZxNCtIWWtUY1ZOUUpJWWI3QU5hcy9JNDJIMU1ST2dwOG1l?=
 =?utf-8?B?bzhoaStNckRlRDFBbnpuK2NDU2E1YUFBU0dMUTZTK1UrWTVZekFNUEVOOERi?=
 =?utf-8?B?cVNTZDA0SFBVUW94L1Z4eHQ2WVY0bWluMDd3MUdzcUFGTmZiQ2hPRzcrVll2?=
 =?utf-8?B?dXJXeXlocnJRMzVWRUxxRmRPdS83TG9uRGFzcXVlNGFCbTFDMTZQdGdsNVF3?=
 =?utf-8?B?alFScVNUSVZWclJsdHhpY3IwVjZPVngvU3FiNUpoc2N3N3hDUFc2ak9LZUJG?=
 =?utf-8?B?UkZmWjBYMzNmc240WjVhcXFGdFRvcVd6eEhETElWbEpSR08xdVMvNTI4M1cw?=
 =?utf-8?B?MHB5dno5VnpKN3M1T05sQVhRTmE2cUdIak1sc0JhZlBSRmwxOGl4alUxdVRi?=
 =?utf-8?B?RGswRW5DWTBpUnVUZFgzZjZYTVcvSWhUWkFMMGxMLzNza0lockpzRlRTUGJm?=
 =?utf-8?B?RXI2RXNEeGJEYjBBNzlZdFZybkdsZVY1VG0wRTRZcnJqRWpJNmpqWWZBSE8r?=
 =?utf-8?B?bUlXbGE0SnhQL0pjZzR6Mk9jZ3Z5aDA3anpYTzEzbEppbEVBOCs4ZUdoQmwx?=
 =?utf-8?B?bXpPUlZEQ3M4YTQ2S21VdGloSnFhR2k2a0pQZXFHeC91cjFaVGo4RmFkUmRQ?=
 =?utf-8?B?NWJGdGMwQVhMWVZ5U0NSOG82d1dIZHFiemMxRGVFUDlWTUhNOGM5SnRsdzRn?=
 =?utf-8?Q?OgCAc2PbrTA7pPp5REStv/Phb?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	+OxcIdc2Q7djjr6g3Hm7V7QlB1C9Ov5DZC3w106L5rRx3E8t2L1huGXEDKIW3waWgGeBOZ8I/p6stRTWq6d9ZomkWhOoF6AQE1h5S282SVb0O+jwE1jlNDechnN9RkMvamjA2vWUi/9alkulmO8t/KJBkbP/VkXVXKFqG3Xfp9RoVQboFsoRVjgP6arciyoP7wzIt7OiwwJ79D9Vg0smWhJSshaYbqLr+yfgQHVEp+7p7jG4SFp81OTsdHDz5XlpccDpiG3hoVoPYoMLH7N58P81C07Gl5w6/83JhmaChM7WqpxJOf+WvUX4VqIN4cZet1iocYjtHIEuPoSPFsjit+EADltO8D56ttk9EvF9estuIdd99KjMzeu9WV5BPKB5x2O6QuLc5GFFVdnzoab35WjddT85QtFiGQe+99ma1iwCFW+4ugcVhsMTO5M+yDnvCxMaGGaWmAy8voERn/mT4pknl6Dbo5grqQZ69+vp7KlTltfKjmOGnxrCTvwqTAhEDVdDD2skl8UOBWrH6ikkgH+NOAPaqy4cr6WpYfC7KcliTHvEwVmd6rxRRAuer7O1ElYochtkGZ5UvEz+Pm762ZU9wtMVVVh46WTfWvGBJ6Q=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 488ba142-814e-4229-2db5-08dc387a0c6f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 16:26:42.7658
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FhJCT7TheivQG5OJrsQMBVocyqgZJqaPfBOnYa1y/lmcX0tiDJe4vnoyGZ/awE2lJOtsQ3aDzVpfrgn1WYImQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7239
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-28_08,2024-02-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0
 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402280128
X-Proofpoint-ORIG-GUID: ioRJiDoGpZXPAttj9-VpbrEOP_Dpm3od
X-Proofpoint-GUID: ioRJiDoGpZXPAttj9-VpbrEOP_Dpm3od

On 28/02/2024 13:13, yangxingui wrote:
> Hi John,
> 
> On 2024/2/22 20:41, John Garry wrote:
>> On 21/02/2024 07:31, Xingui Yang wrote:
>>> As of commit d8649fc1c5e4 ("scsi: libsas: Do discovery on empty PHY to
>>> update PHY info"), do discovery will send a new SMP_DISCOVER and update
>>> phy->phy_change_count. We found that if the disk is reconnected and phy
>>> change_count changes at this time, the disk scanning process will not be
>>> triggered.
>>>
>>> So update the PHY info with the last query results.
>>>
>>> Fixes: d8649fc1c5e4 ("scsi: libsas: Do discovery on empty PHY to 
>>> update PHY info")
>>> Signed-off-by: Xingui Yang <yangxingui@huawei.com>
>>> ---
>>>   drivers/scsi/libsas/sas_expander.c | 9 ++++-----
>>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/scsi/libsas/sas_expander.c 
>>> b/drivers/scsi/libsas/sas_expander.c
>>> index a2204674b680..9563f5589948 100644
>>> --- a/drivers/scsi/libsas/sas_expander.c
>>> +++ b/drivers/scsi/libsas/sas_expander.c
>>> @@ -1681,6 +1681,10 @@ int sas_get_phy_attached_dev(struct 
>>> domain_device *dev, int phy_id,
>>>           if (*type == 0)
>>>               memset(sas_addr, 0, SAS_ADDR_SIZE);
>>>       }
>>> +
>>> +    if ((SAS_ADDR(sas_addr) == 0) || (res == -ECOMM))
>>> +        sas_set_ex_phy(dev, phy_id, disc_resp);
>>> +
>>>       kfree(disc_resp);
>>>       return res;
>>>   }
>>> @@ -1972,11 +1976,6 @@ static int sas_rediscover_dev(struct 
>>> domain_device *dev, int phy_id,
>>>       if ((SAS_ADDR(sas_addr) == 0) || (res == -ECOMM)) {
>>>           phy->phy_state = PHY_EMPTY;
>>>           sas_unregister_devs_sas_addr(dev, phy_id, last);
>>> -        /*
>>> -         * Even though the PHY is empty, for convenience we discover
>>> -         * the PHY to update the PHY info, like negotiated linkrate.
>>> -         */
>>> -        sas_ex_phy_discover(dev, phy_id);
>>
>> It would be nice to be able to call sas_set_ex_phy() here (instead of 
>> sas_get_phy_attached_dev()), but I assume that you can't do that as 
>> the disc_resp memory is not available.
>>
> By the way, I have updated a version and call sas_set_ex_phy() here, 
> please check it again.
> 

Then maybe the first patch is a better approach. Let me check it again. 
Sorry for the delay.

John