Received: by 2002:a05:7208:13ca:b0:7f:395a:35b6 with SMTP id r10csp10043rbe; Wed, 28 Feb 2024 09:02:46 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUBmvJYUGt8RJ2jub63OYdYsk3TJESB4X6ug2u7jIwR/SLJNXwZF35q7jw838hVSXRwcPQPCavrjyj/gpWQeY+5q8QeCgW+PfTdzVdDng== X-Google-Smtp-Source: AGHT+IFG8aOtTnFZgGQoLKYYPnmujACiCVS9+g9a/cvyGr22cSVnc8cIFtj+ibluO/wI5DyHSmfd X-Received: by 2002:a05:6a21:3482:b0:1a1:aad:5d5c with SMTP id yo2-20020a056a21348200b001a10aad5d5cmr5627075pzb.42.1709139765959; Wed, 28 Feb 2024 09:02:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709139765; cv=pass; d=google.com; s=arc-20160816; b=rLFoo2oqifalZj7v2izRTx7O1wEPlZr9JwMDIG/asgHGo3wTW1TyIw2tlxvnpU32uF psKF7Ne5AvoKJdMChTyaxMrx5SzU1qmR/YcWMmQyxfqJCwnCKFH//wT0HYE4Ij3PBUw6 577oIAfmPrSbiuYBKycYnj6gKTgUPZAsVnyA1uFVL+l0oK0IZm64r+WJAkmnqTH7W6QM lrFs66IC5P+DEEavrDF3nDBWCsljfw3auwNtxe7zIFxEMwkvWBF6Cxw9D0v7To2QzbkL G5nlkenbv5PT3y33mhL7q2Yw/6hXkiWVDU82pjKImQvgu1gmUn8hD5QjudiHb38karuv AiyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IMpRJRX95zgFjbDJJkVo3LiXZsjgsaeBXPMKkkKcq9s=; fh=kGSt7b1oZb0Ih5M6fHlHwFIZJpklIiBGQz+VvH0xYgg=; b=bBY1czzUctBPbN1D0Gb98ChcDW4G3WBKrqLGtXaZnQLH8aXQbgf57RM2TPU3RsVaJy fb0cPQIYJAi7yL2JHwcHpuEYV05MxCxzpOcH6RUwxQPab0Xy12ydPgdO+ZxvRmNjY/oJ 7ezw10fWhRoaDEoaUJh8M+8dwrodMuWBhbSX25bCMs9TtoXRapMsX2IOB9YE6aDZ8bnH ilVwPLOmtt/x1zx3/OxOgPoAZ1QbYsEJZprdNmKhvpRVf4rd+5LWj4+uXlR1zR3+kKKD 2Pn/dvd6egkLhvZJuIVvtl0XqGa+ViDSRuWPi+4rInhYlpbHDWzgLSxSbqsndiPOP7tG ZeEw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=HOWjpnD3; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-85092-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85092-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i20-20020a17090acf9400b0029af7be61a2si1181095pju.99.2024.02.28.09.02.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 09:02:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85092-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=HOWjpnD3; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-85092-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85092-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BBB2EB259AC for ; Wed, 28 Feb 2024 13:29:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C53DD14D420; Wed, 28 Feb 2024 13:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HOWjpnD3" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E26B1E493; Wed, 28 Feb 2024 13:28:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709126939; cv=none; b=kXb5sln6SoR0LVefME47NxZ65EBa7a7bQ+/vI2n+oIBMiQkjgU7LwZgH3G1lWwl/Lr1Af+Onx+95HmzS0YoQfC8jBa51cInXkDBQ48UURcup4NepCDkSsvhqx91Mu16Tuo0WuEnHNN25S/q59AULPNe8OV2+EwZuChl/hRWgWg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709126939; c=relaxed/simple; bh=JT52S9g7j/kEijySVLsE8fq6O3F0OsyWivHrbOm/DPM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AfN2HLERRYLzFJhXByVbTtNeYBrxnJhk+KWIBnlmitpfwbeksnOsOXNYM2mSAAW6yGwRIZhjY17X3V2tKhyfl1yUStvJ4YxInEMBM9r25NkPQ10uN3znkzGlJ6dWqYFs9ICfab5k/iRlYCT67Wv743jhm8fjMJ+ZYX0bEFesR6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=HOWjpnD3; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IMpRJRX95zgFjbDJJkVo3LiXZsjgsaeBXPMKkkKcq9s=; b=HOWjpnD3YrDgccps2LwDtdjK7U jsFvYTyniWQXf2XSHwVNo9AWHZqyk8q/pHMbqmTW263OFNeZuH5lJT3BeqNocdSZPdV7zJJFRrFy4 vQErZsPI0aCh8tOcgobDavwQduR8fCgqsdzOlzg9wK570CTysPhxIEQU3pZU1UuzSpTwYwRUh6Sjl fCAnA8sS6qNS+mKDg/g9AuzWWueyJkYUS2yQ8+RXE/JESltI89+wFri8TfDb/sTVnkyqeruNUwa01 jUJvBO6dQCuVpMNJ8/zHh4YHCQVoJJXKPINHzhoq06She7ib+9AL7ICukoVwsSN1ICDj1vSTcxVJ4 qVOHm10Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfJzU-00000009TRi-3nIU; Wed, 28 Feb 2024 13:28:56 +0000 Date: Wed, 28 Feb 2024 05:28:56 -0800 From: Christoph Hellwig To: Jiapeng Chong Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] bdev: make blockdev_mnt static Message-ID: References: <20240227081958.89092-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240227081958.89092-1-jiapeng.chong@linux.alibaba.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Feb 27, 2024 at 04:19:58PM +0800, Jiapeng Chong wrote: > The blockdev_mnt are not used outside the file bdev.c, so the modification > is defined as static. > > block/bdev.c:377:17: warning: symbol 'blockdev_mnt' was not declared. Should it be static? > The patch looks good: Reviewed-by: Christoph Hellwig > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8341 But I don't think kernel commit should close random bugzillas?