Received-SPF: pass (google.com: domain of linux-kernel+bounces-85406-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 28 Feb 2024 18:03:00 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Lukasz Majewski <lukma@denx.de>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Eric Dumazet <edumazet@google.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
	Tristram.Ha@microchip.com,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Paolo Abeni <pabeni@redhat.com>,
	Ravi Gunasekaran <r-gunasekaran@ti.com>,
	Simon Horman <horms@kernel.org>,
	Wojciech Drewek <wojciech.drewek@intel.com>,
	Nikita Zhandarovich <n.zhandarovich@fintech.ru>,
	Murali Karicheri <m-karicheri2@ti.com>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Ziyang Xuan <william.xuanziyang@huawei.com>,
	Kristian Overskeid <koverskeid@gmail.com>,
	Matthieu Baerts <matttbe@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] net: hsr: Provide RedBox support
Message-ID: <c3880444-3665-4a60-b6ec-f8ae8a9fbf8d@lunn.ch>
References: <20240228150735.3647892-1-lukma@denx.de>
 <20240228083115.01d4c93e@hermes.local>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240228083115.01d4c93e@hermes.local>

On Wed, Feb 28, 2024 at 08:31:15AM -0800, Stephen Hemminger wrote:
> On Wed, 28 Feb 2024 16:07:35 +0100
> Lukasz Majewski <lukma@denx.de> wrote:
> 
> >  
> > +/* hsr_proxy_node_table_show - Formats and prints proxy node_table entries */
> > +static int
> > +hsr_proxy_node_table_show(struct seq_file *sfp, void *data)
> > +{
> > +	struct hsr_priv *priv = (struct hsr_priv *)sfp->private;
> > +	struct hsr_node *node;
> > +
> > +	seq_printf(sfp, "Proxy Node Table entries for HSR device\n");
> > +	seq_puts(sfp, "MAC-Address-SAN,        time_in\n");
> > +	rcu_read_lock();
> > +	list_for_each_entry_rcu(node, &priv->proxy_node_db, mac_list) {
> > +		seq_printf(sfp, "%pM ", &node->macaddress_A[0]);
> > +		seq_printf(sfp, "%10lx\n", node->time_in[HSR_PT_INTERLINK]);
> > +	}
> > +	rcu_read_unlock();
> > +	return 0;
> > +}
> > +
> >  DEFINE_SHOW_ATTRIBUTE(hsr_node_table);
> > +DEFINE_SHOW_ATTRIBUTE(hsr_proxy_node_table);
> 
> NAK
> Do not abuse sysfs to be a debug proc style output.

This is actually debugfs, not sysfs.

However, i agree, we want information like this exported via netlink
as the primary interface to the end user. debugfs is not suitable for
that.

	 Andrew