Received: by 2002:a05:7208:13ca:b0:7f:395a:35b6 with SMTP id r10csp26423rbe; Wed, 28 Feb 2024 09:29:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXYCb9STYTQEHpzLjXrwaUtT35WhyYVK2VCEtIG/TzC9RZ3zEa4sL3lwydaHNPr7i4Ic13cK56HxV09Jyt8ZpYKkPmvaCRBtsMKx9fXaA== X-Google-Smtp-Source: AGHT+IFjg/GEkwpkXeGB7KrSILnH6j5mADOBW+o04q24itIhszCGVT0Ef6a43qmGwClEkhshowe6 X-Received: by 2002:a05:6870:cb86:b0:21f:f595:de72 with SMTP id ov6-20020a056870cb8600b0021ff595de72mr524830oab.0.1709141352523; Wed, 28 Feb 2024 09:29:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709141352; cv=pass; d=google.com; s=arc-20160816; b=lxnBjKCIunsYDpBGBUNN45xsA09oGpOS9wzrX2hZv7o8RrGXlKkAaVGPVBje/t0vPD srepp6PpNtl39OgMH6R8BqBENsuvOVtAEc8IkJR0lVKOn28W+pQhmMD7w7tdtrjc7cgg N9JTh2Z5dVIh2hIYjkILStw7U+/iIuGilxWtz0WrE1J3t4nLksem+pjx0Tbf34MECADs RUFIqjDd+/NPOwtgWfr4bcqDqKmyujwe3cj7/SHwpAE3IYeMXU3NqE3IVNfsjpZ7clqv PupAjt4kb9pziARarvzXDQbdu8ceOzl6o/zTdsDocD8SsTU/T5FZWe864WOoOV/1cSBI Q86w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=IwhCjyDr6lykCNeZ5Xu2eV2ksHG4q/hbAP4JpLNuQNU=; fh=Kp9OImQWwfjbovb5nMLVomSWlzYZv99iqduPfGz30L8=; b=q27NzlgShbDnlLJaI3VYpfT5jsOUPrmFOm66+HH1WE8EMLrbIDbEu7IYbEP/tcaGYW 02ejDnW43SPQ8h4zObPEpDPn7lkGSCfR7xLsKltvujOl15tYTbVAsTnUa2tKbGuWLQI4 KWGiX5E1hdx767HmY66GONtW5ZJv/DbEGyKM0wUB1ZsW4cuPdgB4tC1wYLz14IAKOjDq pqNZDvCrNZZFSmp5dPnOaf6so6cs8Xwh+josdF9o2Tl059RVdwu3m4QnNXd/A7gFYyDB iI+wZmLqX4PD6wW4novY1ForfhsGVIWab0JHu3m+XLPjWFHhQ4uY3LLNmFCQaylZzmRX XF1Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=h5GHPVkO; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-85439-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85439-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id pe5-20020a05620a850500b00787f2a0b86fsi1262893qkn.406.2024.02.28.09.29.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 09:29:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85439-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=h5GHPVkO; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-85439-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85439-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 474AC1C2394C for ; Wed, 28 Feb 2024 17:29:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE0C2159573; Wed, 28 Feb 2024 17:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="h5GHPVkO" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B8334CDE for ; Wed, 28 Feb 2024 17:29:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709141349; cv=none; b=cZ0JhD9MJAPszZ0ojyR9Ag08b20KnP80EHq0j121MzoVMv3qaQaYFmu03/hPEQiHi/4Ri4Vj0WMjz+syyy2Embo2bCcQZBTjJu+Pb90cIyBjlM8IthvWIEoOnyE8fxvBP+rzrfrmjMKxsbyuaSSbupi/Vlxzw8DjT9oJBDcJGQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709141349; c=relaxed/simple; bh=CDkOmty3Y9k/DPWDiSygmNFOvhxT7q2cYTOHtCPHBaE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bd7jcEIUVwtm5mLIS5JWjC2PYuJ5948BiS3BL0YQReU1R72CIs/Tb/uvdJDycE5u/kLFHMAec6tDFyVdU+kEo7OjbG2xe6QmTcnjD1Eh+lOodWW3qjrTyPfHT9z214LPa4Kl/xmRJn4pKeKHopdZFGdk3RLJTR01NKRkCQ13Fwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=h5GHPVkO; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709141347; x=1740677347; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=CDkOmty3Y9k/DPWDiSygmNFOvhxT7q2cYTOHtCPHBaE=; b=h5GHPVkO4FMIECresW2Idhg6gLll4mJS7ZXMo6VWxXIqpXzsFbky+SGP CfM8gV0RxVGq8Uw6pROwxXTbUmlgJTiA0Af7F4Admca+hAUkCx5iRNYBq YselHbcxT6SyagrC325bMVbuooc96dPgnpgMOyT7so5f3uFGT+XeN7dYg qQIgPztgZ/0fdg/eqBx9yBG2gdh0+1/bo5R2OXn0IkcuFzNtLSlWwA/yg hixP02fEkEp/ninQYWBqVh5kFoW7kgbly07Wg1oVdmKrPd4iS77Ycflfc j+m9qzfWt6eY4KjTIMVceEnkrnZbj+illuQ/L+UhU5Del+k+472qxZTdT w==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="3436984" X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="3436984" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 09:29:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="7929522" Received: from edloving-mobl1.amr.corp.intel.com (HELO [10.209.50.42]) ([10.209.50.42]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 09:29:06 -0800 Message-ID: Date: Wed, 28 Feb 2024 09:29:05 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC][PATCH 09/34] x86/cpu: Introduce address configuration structure Content-Language: en-US To: "Huang, Kai" , Dave Hansen , linux-kernel@vger.kernel.org Cc: kirill.shutemov@linux.intel.com, pbonzini@redhat.com, tglx@linutronix.de, x86@kernel.org, bp@alien8.de References: <20240222183926.517AFCD2@davehans-spike.ostc.intel.com> <20240222183938.662DD27C@davehans-spike.ostc.intel.com> <10808725-d98b-430b-8c47-4feef8685734@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <10808725-d98b-430b-8c47-4feef8685734@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/27/24 15:47, Huang, Kai wrote: > From the above description, ... > >> +struct x86_addr_config bsp_addr_config; >> + > > ... this can be __ro_after_init? > > Maybe I am missing something, but if it cannot be annotated with > __ro_after_init here, IMHO it would be helpful to call out in the > changelog. It can actually be full on __init .. eventually. It goes *AWAY* after boot. I'll add a note in the changelog why it can't be until later in the series.