Received: by 2002:a05:7208:13ca:b0:7f:395a:35b6 with SMTP id r10csp29117rbe; Wed, 28 Feb 2024 09:33:41 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVK+LZBGyvo+Y2DMt4FxE7XNwc3IEaZnitLJjfWMcHOVzQG4eaiEuf+3g4mQ1oaTnJJhxaNkkvmkHqoMbghhOJw7lDdF5aaJfKUXLc34w== X-Google-Smtp-Source: AGHT+IFYLBg8+W2tYHE9KRpu5Se1k/8hCBAOq2Mg+uk4bd7BjYCyyBW4mHOOFgwuc118bwB2Wqr0 X-Received: by 2002:a67:b44b:0:b0:470:54fa:b37b with SMTP id c11-20020a67b44b000000b0047054fab37bmr185610vsm.35.1709141621371; Wed, 28 Feb 2024 09:33:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709141621; cv=pass; d=google.com; s=arc-20160816; b=SYWkDvro/oJ634T2VGr3z2ic0hsbHGBJXtWtigKwRV9XOw1pdSO35ZWj7bAnGdtsd5 aFckSk9BCAooa3hb01SX8jw4n+f/jzgexNUGjfztRXzSPEbI1cQqoU8Q2TICHxWz7Ls8 9jhI+GSiann++azTauTCHoKAdW9b8MxwEi5DCTTkVKsI10jGKH98h05eUc9J9k2QqmuI a9QTIgzDiIll+HUGboXTLFDrSCc1VhMoufywjHJ8e22dmI9rsELGeAtB1c2xeJVp2muf L/WhYz6buFdQSFTO2F9/eOoYS57rPCMFhFV3f9ys9CtFSipGgAjdRSSVVP203dq4YAyd HuDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=2HW4iHXulikq+eKkJaUQdhY7eMUtbyCLYsAWn05R978=; fh=gwYNO/A0AOwsEorbTq6zwshvb0d8adoAH2/vAS1SJQI=; b=BJ4flOB0CItLDJJ27RVAOaEtdjHHasN2AwgyOaxYy1AmQA5Ws/Pi9wo3TevsX2/z1f nUDxpbcSCBDUlcATArCym5RWDvEvHkuzUUFoyzNNzqHVXyDzJFpYi8atwXVUuQrijyHR UwBGslkY+3XKSwLaJf2LTtyETOukbk3yKTiBRkhRDgDYe17shl7eD/n/u5swT8kMjloh 438XAJqvgd7Vb7NvnQK0sLAkI/huDm2Jf6D9kyk3pMjLLm4lqDWGsgNdQMWkZfBwKwDW /GXyqAyAxpg0wPpCJG88HwGOcCXtcyAVljmKMNGw1pT6hxq/w0E+R3ziW6uvaUTqxx/n 3Tag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BKDciDoM; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-85445-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85445-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j3-20020a67ef03000000b004726697d136si390784vsr.792.2024.02.28.09.33.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 09:33:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85445-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BKDciDoM; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-85445-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85445-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1E33C1C2147C for ; Wed, 28 Feb 2024 17:33:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A76CB1586DC; Wed, 28 Feb 2024 17:33:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BKDciDoM" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AD701E514 for ; Wed, 28 Feb 2024 17:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709141613; cv=none; b=sMgc9IofqsvZVkNMwGCOGXd/QBuiOzUgyPVaK3XdkEim5HGHNj6OcMesgcTFdtnaI0STvTDIe3HTTA0p7zhNUwXNyTUuz74l3SAyEUR1xgjDiep61qpapRjO314YN88G+3ASL7epo56N8CaBAFZIEvEUlY+lynTy34RR0cpVo6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709141613; c=relaxed/simple; bh=rqnPGPHelN/v2OFh//pjXKa7moKmEKkSgoJmULvhJWk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qj0urbNkSkE/1J5P2G3ZypHIINlG3+KLYyoEJ+XjUyeQfZNjw/zLCaNg02QgEQCiJG6OwIZK0ehdDcaeTrzjy228HF/eHWKo1epcbnu2NBleZGR8borTNucbEj4gRFvdxZKsZmJ4L5TJQ2YJSwn6+IxmbH9ekfnkiQ5gDxT0upw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BKDciDoM; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709141612; x=1740677612; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rqnPGPHelN/v2OFh//pjXKa7moKmEKkSgoJmULvhJWk=; b=BKDciDoMtsQ8tkqGq9r1prtNq5LUhHNt/V2M3BHQKcTG30+UFSrd5SxU AZb+l71kzmE65FG2MbSCWgrjfaDUpoEkEeYoa7c2GdjurvyJOc0jfy973 9gGqIyq28AsIDylvCNI20a6YYVh6uh3XJL6NsVSOy44eXG4ks6NnSP0Bf 6r4ukR0RKC0A5GXpYCgshbx+KAC6eIIuzo4yf7ZnZFo+7OpidohcXAHnO 7BcUSFYCCGxian7dEO0LcI9cf5KXkxyvl854b7v9e9I7du7XflzDuQnB7 ehkIa84HB2jKa4v8cC9Yw1iMZHfwFIYaczm8aobq7lFpRUBWIU6Yezbs6 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="14996076" X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="14996076" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 09:32:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="913956334" X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="913956334" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 09:32:40 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rfNnK-00000008Hg8-043c; Wed, 28 Feb 2024 19:32:38 +0200 Date: Wed, 28 Feb 2024 19:32:37 +0200 From: Andy Shevchenko To: Shahar Avidar Cc: gregkh@linuxfoundation.org, luca.ceresoli@bootlin.com, benjamin.tissoires@redhat.com, elder@linaro.org, robh@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] Fix defines in rf69.h Message-ID: References: <20240227221204.534131-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240227221204.534131-1-ikobh7@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Feb 28, 2024 at 12:11:59AM +0200, Shahar Avidar wrote: > This patchset fixes several misuses of the define statement in rf69.h. > Duplicted defines. > Define in header instead of source file. > Unused define. > Using units.h macro to define frequency. Good enough (esp. for staging), Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko