Received-SPF: pass (google.com: domain of linux-kernel+bounces-85429-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 28 Feb 2024 19:22:26 +0200
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "geert@linux-m68k.org" <geert@linux-m68k.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
	"sebastian.hesselbarth@gmail.com" <sebastian.hesselbarth@gmail.com>,
	"ojeda@kernel.org" <ojeda@kernel.org>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"javierm@redhat.com" <javierm@redhat.com>,
	"robin@protonic.nl" <robin@protonic.nl>,
	"lee@kernel.org" <lee@kernel.org>, "pavel@ucw.cz" <pavel@ucw.cz>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic
 7 segment LED
Message-ID: <Zd9r0lcnSuKFEsZF@smile.fi.intel.com>
References: <20240227212244.262710-1-chris.packham@alliedtelesis.co.nz>
 <20240227212244.262710-3-chris.packham@alliedtelesis.co.nz>
 <CAHp75Vdi2c=s_z9wwxWzVcL+4tx5ZnXymbiN4O1FS+D3kz5vqw@mail.gmail.com>
 <34b89a56-ab43-4d44-86f3-604e5be29db3@alliedtelesis.co.nz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <34b89a56-ab43-4d44-86f3-604e5be29db3@alliedtelesis.co.nz>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, Feb 28, 2024 at 01:53:08AM +0000, Chris Packham wrote:
> On 28/02/24 13:03, Andy Shevchenko wrote:
> > On Tue, Feb 27, 2024 at 11:22 PM Chris Packham
> > <chris.packham@alliedtelesis.co.nz> wrote:

..

> >> +  segment-gpios:
> >> +    description:
> >> +      An array of GPIOs one per segment.
> > This is a vague description. Please explain the order (e.g., LSB =
> > 'a', MSB = 'g'), use of DP (optional?), etc.
> >
> >> +    minItems: 7
> > maxItems?

> I plan on saying maxItems: 7 (more discussion below)

..

> >> +    led-7seg {
> > Probably it should be more human readable. DT people might suggest
> > something better.
> >
> >> +        compatible = "generic-gpio-7seg";
> >> +        segment-gpios = <&gpio 0 GPIO_ACTIVE_LOW
> >> +                         &gpio 1 GPIO_ACTIVE_LOW
> >> +                         &gpio 2 GPIO_ACTIVE_LOW
> >> +                         &gpio 3 GPIO_ACTIVE_LOW
> >> +                         &gpio 4 GPIO_ACTIVE_LOW
> >> +                         &gpio 5 GPIO_ACTIVE_LOW
> >> +                         &gpio 6 GPIO_ACTIVE_LOW>;
> > Dunno how to handle DP. Either we always expect it to be here (as
> > placeholder) or with additional property.
> 
> My current plan was to ignore it. As you see it my later patch I'm 
> (ab)using DP as a discrete gpio-led with a different function.

FWIW, I have _no_ indicator _without_ DP. So, my statistics is towards enabling
DP as a part of 7-segment displays.

> We could either a separate dp-gpios property or set maxItems to 8. Right 
> now the driver won't do anything with either option.To actually do 
> something in the linedisp driver we'd need to have a new character map 
> that includes the extra LED.

Yeah, we can leave it open for now.

> >> +    };

-- 
With Best Regards,
Andy Shevchenko