Received-SPF: pass (google.com: domain of linux-kernel+bounces-85493-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240227172852.2386358-1-tj@kernel.org> <20240227172852.2386358-7-tj@kernel.org>
 <CAOMdWSLVDaN_XFD6Ov-=6VrH4wyBz-0wq_L3EzgdsJ5zJi47qQ@mail.gmail.com> <Zd9yNByiBMcPxWbU@slm.duckdns.org>
In-Reply-To: <Zd9yNByiBMcPxWbU@slm.duckdns.org>
From: Allen <allen.lkml@gmail.com>
Date: Wed, 28 Feb 2024 10:00:08 -0800
Message-ID: <CAOMdWSJX43mqaSWaoVkNep9zJjr+v6OXup9YK9EuA_CWH+wThA@mail.gmail.com>
Subject: Re: [PATCH 6/6] r8152: Convert from tasklet to BH workqueue
To: Tejun Heo <tj@kernel.org>
Cc: jiangshanlai@gmail.com, torvalds@linux-foundation.org, 
	linux-kernel@vger.kernel.org, kernel-team@meta.com, boqun.feng@gmail.com, 
	tglx@linutronix.de, peterz@infradead.org, romain.perier@gmail.com, 
	mingo@kernel.org
Content-Type: text/plain; charset="UTF-8"

> > > @@ -6971,7 +6972,7 @@ static int rtl8152_open(struct net_device *netdev)
> > >                 goto out_unlock;
> > >         }
> > >         napi_enable(&tp->napi);
> > > -       tasklet_enable(&tp->tx_tl);
> > > +       enable_work(&tp->tx_work);
> >
> >   I think we are missing queue_work() above, right?
> >
> >    To avoid such situations, could we combine enable_work() + queue_work(),
> > into a single API?
>
> Here, the device is newly being opened and the work item is just disabled
> from the init. So, it doesn't need queueing.
>

Ah, my bad. Thanks for pointing it out.

> > Perhaps, something like:
> >
> > static inline bool enable_and_queue_work(struct workqueue_struct *wq,
> > struct work_struct *work)
> > {
> >        if (enable_work(work))
> >        {
> >              queue_work(wq, work);
> >              return true;
> >        }
> >        return false;
> > }
>
> That said, this may still be nice to have.
>

 If the above is okay, I could send out a patch. Please let me know.

Thanks.