Received-SPF: pass (google.com: domain of linux-kernel+bounces-85659-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240228-m4_lpuart-v1-0-9e6947be15e7@nxp.com> <20240228-m4_lpuart-v1-4-9e6947be15e7@nxp.com>
In-Reply-To: <20240228-m4_lpuart-v1-4-9e6947be15e7@nxp.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Wed, 28 Feb 2024 17:04:54 -0300
Message-ID: <CAOMZO5A0iNpU702DBEyPgkHyOR6M-xDkw9SQTxiFQK65Af79yw@mail.gmail.com>
Subject: Re: [PATCH 4/4] dts: arm64: imx8dxl-evk: add lpuart1 and cm40 uart
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, devicetree@vger.kernel.org, imx@lists.linux.dev, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 28, 2024 at 4:55=E2=80=AFPM Frank Li <Frank.Li@nxp.com> wrote:

> +       modem_reset: modem-reset {
> +               compatible =3D "gpio-reset";

I don't see this compatible documented.

> +               reset-gpios =3D <&pca6416_2 0 GPIO_ACTIVE_LOW>;
> +               reset-delay-us =3D <2000>;
> +               reset-post-delay-ms =3D <40>;
> +               #reset-cells =3D <0>;
> +       };
> +
> +       m2_uart1_sel: fixedregulator@101 {

Why is this @101 here? You should remove it.

Passing a unit address without a corresponding reg entry triggers a
dt-schema warning.

We want less warnings dt-schema warnings, not more :-)