Received-SPF: pass (google.com: domain of linux-kernel+bounces-85669-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: ibe194615:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-182-gaab6630818-fm-20240222.002-gaab66308
Precedence: bulk
MIME-Version: 1.0
Message-Id: <fdda6515-3b13-4727-9304-c740c77003ec@app.fastmail.com>
In-Reply-To: <d6d0806e-5b5d-474c-affa-d43d88785275@redhat.com>
References: <20240228150149.4799-1-vishnuocv@gmail.com>
 <d6d0806e-5b5d-474c-affa-d43d88785275@redhat.com>
Date: Wed, 28 Feb 2024 15:19:50 -0500
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Hans de Goede" <hdegoede@redhat.com>,
 "Vishnu Sankar" <vishnuocv@gmail.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: 
 "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>,
 linux-kernel@vger.kernel.org, "Vishnu Sankar" <vsankar@lenovo.com>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Add more ThinkPads with non-standard
 reg address for fan
Content-Type: text/plain

Hi Hans,

On Wed, Feb 28, 2024, at 11:09 AM, Hans de Goede wrote:
> Hi,
>
> On 2/28/24 16:01, Vishnu Sankar wrote:
>> Add more ThinkPads with non-standard register addresses to read fan values.
>> 
>> ThinkPads added are L13 Yoga Gen1, X13 Yoga Gen1, L380, L390, 11e Gen5 GL,
>> 11e Gen5 GL-R, 11e Gen5 KL-Y.
>> 
>> Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>
>
> Thanks, I have no objection against this patch:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> But this feels like it will become a game of whack-a-mole.
>
> Mark can you reach out to the ThinkPad firmware team and
> figure out if there is some supported way to automatically detect
> this ?
>
These are all older platforms and we're not expecting to see this on any newer platforms...if it shows up it's because they messed up (there is a spec and they're supposed to follow it).
Vishnu did review with the FW team which platforms had used this implementation, and we believe the list below to be complete.

Vishnu, please correct me if you've heard otherwise.

As a note, I did review this during an internal review, before Vishnu pushed it, so I'll add:

Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>

Mark