Received-SPF: pass (google.com: domain of linux-kernel+bounces-85662-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <26262e37-55e8-4488-9489-51e640ba1586@wolfvision.net>
Date: Wed, 28 Feb 2024 21:10:15 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 2/8] usb: misc: onboard_hub: rename to onboard_dev
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Helen Koike <helen.koike@collabora.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Russell King <linux@armlinux.org.uk>, linux-sound@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org,
 linux-arm-kernel@lists.infradead.org
References: <20240228-onboard_xvf3500-v5-0-76b805fd3fe6@wolfvision.net>
 <20240228-onboard_xvf3500-v5-2-76b805fd3fe6@wolfvision.net>
 <Zd946sKywJNvIJq6@google.com>
Content-Language: en-US
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <Zd946sKywJNvIJq6@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZWlIdkVRTXk3VlplWk5zWmpocFNzOC9GMXBqSGhIOUlxQm1LR2ZUZXlSKzk4?=
 =?utf-8?B?Vlc2eENnK1orN243OCtaK3FTVitsUklUeXVUenF0cll6Vlo4MXNrT0FXMGFv?=
 =?utf-8?B?QjFvemZyWDNsc01zMTZGdkhtQnFjWEFWTm91Z2NoMVlpRlRsSUtQcUNhWi9O?=
 =?utf-8?B?VkI0dXRFN0xFRU9ZRTJGd3lqNHROeWt5MHhySWtHYUFxTlVmbVpOYzJzWXhK?=
 =?utf-8?B?MkVFbnA4bm1yOWE5UzRKeXdaclRXWFk2SnE3VVVQa2dOZnFZN29DNkEzYnhH?=
 =?utf-8?B?TjNtTVRybDBnRUhPZStIMHhFTXlObzJ4TE1jNzlVdVkxMUhHZlpmQi9nSERq?=
 =?utf-8?B?Z3VxS2NBbmREOXdOYXFCdXFsamw5NEZ4VE5YZkdmSkhzNFdmV3p4NmFrWnAv?=
 =?utf-8?B?bUNwL0NlL3pjODhQNHVQM1IzMXFOTVdvUnJsRXNHbEFLanpsVEVIbmVqK1dK?=
 =?utf-8?B?eWhpWFNuekxXNm1BdFBLeVFLaXQwVm9wYkNIVEFueDZqZmFYQ2RWZ1pYdzVX?=
 =?utf-8?B?bWNBR2JBSFc1Y2ZIM1pwOFg4d1krbmRmS1Q2aFJqZ04xc1ZJOEpYWlVuOHVP?=
 =?utf-8?B?azhWQjc5aE5US3dZMU1TQVJyUCtGbE5mUlJvdm00b3YxckltUnNlZXFvWlBY?=
 =?utf-8?B?b2h5czBSVVdrS3RiQTJWdmxyOG5iZGtnSXBDZkt1RytOalhEOElDY3NCMm0w?=
 =?utf-8?B?QXp6alBiT1RFWmR5L3k0WDMzcE5JM2RqY04yZHZkNjBpUXM4Qzc1K1QrcmRD?=
 =?utf-8?B?QVhLWUt5ZFo4cFJyRVlySjNocFFjbHkyc1F1QldienJvd0tlUUk2K2JoTEpB?=
 =?utf-8?B?VStVbU5Yb3hiMm1lWEJHeGpQKzFSMzFoa0Zib0xzTUhXRi9rS3NXcUEyUkps?=
 =?utf-8?B?Q3JPN1BycnhMQ3dmM3FseVRFeXRqUWkxWGR3YnU1UFhQaCtCSFQwYTBVQ3NM?=
 =?utf-8?B?Ni84dkFseG5iNUdodTlhN0ZEUWpMaS83dGxnMXp4akVmdktKL0NEZktGcC9m?=
 =?utf-8?B?OHlMM3loZWVENHJYT2RNK2t5VUY3ZGRlWGFsSUdreE5JRUFzTWtlSXllNUZq?=
 =?utf-8?B?RU5vYjR6aXhURlh2aHZRbGJSb285N1NOZ3J0eFcxY1c1SmkzRTVzd3U3K3lN?=
 =?utf-8?B?WGVUcS9LV1RyZ3o4Uzl3S0VtUkhOdklJM0dmNkNPeENLcDdHY283Y3U2Y0Nz?=
 =?utf-8?B?WTg2WkhjTVRVek9LakpUc3V5T1lnNm5pemNEUkZmSU56MExzQ0tmSGEyU2J0?=
 =?utf-8?B?K0lwZkx4ZG1md1pGWjNEZk1ERmNQUmtPOGlBTjJOVjg2Z2FtZ2NmRllJRmla?=
 =?utf-8?B?OU15YzE4MGNxOWxLWUhUK25xR3daUGhSaDhXQUhLWmxZc1FUM2lNQ2cydHdw?=
 =?utf-8?B?Y2ZMalNtTno2VDNkRTdub0RzQm5uUEtTc3FtQVNUV29rZlJkVkFZUnJUUlFw?=
 =?utf-8?B?bFdvZXVOUEM5eE9Td2VyVUJ5dWxBai9sZmsxMGZwbVp0K2VEa1U4RzBpUldM?=
 =?utf-8?B?d1NsTGh4SkhUTzVVUFR1SFh0TG53MWlONHJBNDczYy9ERnhzem1lWHlwaE5u?=
 =?utf-8?B?SFN0aEpldUpBSS9pMVBxR3FDYWhsaHZaUXdyQk5RekJqcytVYWxIQm50cHpp?=
 =?utf-8?B?SVZsSENqVkJKZDhwQ25CQmlaeXg4bkdLVXdlWTN0OHJ6MFpuMVJGcjlPR1g1?=
 =?utf-8?B?VkJxWENoQ05zb3RkUHhibUhndUhRczVseFhYc2ZyeGlyMWx6LzhSM3hYelRJ?=
 =?utf-8?B?NVd1QUdNYitZejZzK3FyRWRZb2xmU1FQcHdZTVpVUzh5Wjc0M20ra3BzOXlu?=
 =?utf-8?B?OS9rZUE1MFJ3dmtWMDNhMEZQejBueVJyY2dad3FQQnZTOUdMZWdUbFZWU0lt?=
 =?utf-8?B?WGxpMm14cHN2T2xXdjRSenArdFVpZEszcUhENmwzNVhNbElNcWVXL0YwQm95?=
 =?utf-8?B?QVN4ZUJ5SWRrcithSlFBZDJrdHBUT2dvOVRwdU9HQWF1Q0dEa3VOaWlqREMz?=
 =?utf-8?B?TXNnMkVtbmg5MjdYMWttb2pzd29UNWl5WTFKQjhtemlWd1JKTEVRRG9SQW1m?=
 =?utf-8?B?T21lK0J3aEVVQThRek94Y0dOZk9EejFqcVZGV2QrWmoyTHRPSU1kS3lQK2Nw?=
 =?utf-8?B?L3pRYVpwRHFMUU91bFc3NjBLKy9UNE1aeEh1OE9uRzlnNURSRjR3alFKTmJI?=
 =?utf-8?B?M1JtMXFiU1laU0c4SGpWT0Y1SkZqL1lHS2VFNDIzOXNWRDlqYVFOajFINnR6?=
 =?utf-8?Q?m3cL96cJc+cLENKyuOv43nKTcQ0LyN1hx2NxPw0eJY=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 54db64ba-5bbe-4c55-c820-08dc38994928
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 20:10:18.9905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q4b47o10VPqMTJxcRDx7kPDEGf9FW95znYsRruPvslVkBZj6fVOHnNAgXwW2mZ6EKJLUDXpGKcjpIeVEPTxqX2QKw/hcWklw9FaA7vw1kGs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9590

On 28.02.24 19:18, Matthias Kaehlcke wrote:
> On Wed, Feb 28, 2024 at 02:51:29PM +0100, Javier Carrasco wrote:
>> This patch prepares onboad_hub to support non-hub devices by renaming
>> the driver files and their content, the headers and their references.
>>
>> The comments and descriptions have been slightly modified to keep
>> coherence and account for the specific cases that only affect onboard
>> hubs (e.g. peer-hub).
>>
>> The "hub" variables in functions where "dev" (and similar names) variables
>> already exist have been renamed to onboard_dev for clarity, which adds a
>> few lines in cases where more than 80 characters are used.
>>
>> No new functionality has been added.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
>> ---
>>  ...-usb-hub => sysfs-bus-platform-onboard-usb-dev} |   3 +-
>>  MAINTAINERS                                        |   4 +-
>>  drivers/usb/core/Makefile                          |   4 +-
>>  drivers/usb/core/hub.c                             |   8 +-
>>  drivers/usb/core/hub.h                             |   2 +-
>>  drivers/usb/misc/Kconfig                           |  16 +-
>>  drivers/usb/misc/Makefile                          |   2 +-
>>  drivers/usb/misc/onboard_usb_dev.c                 | 519 +++++++++++++++++++++
>>  .../misc/{onboard_usb_hub.h => onboard_usb_dev.h}  |  28 +-
>>  ...ard_usb_hub_pdevs.c => onboard_usb_dev_pdevs.c} |  47 +-
>>  include/linux/usb/onboard_dev.h                    |  18 +
>>  include/linux/usb/onboard_hub.h                    |  18 -
>>  12 files changed, 595 insertions(+), 74 deletions(-)
> 
> This does not rename/delete onboard_usb_hub.c. With a rename there would
> probably be an actual diff for onboard_usb_dev.c instead of a new file,
> which would help with reviewing.

Thanks, I noticed that when I started working on v6 and it has been
fixed. I must have lost that one when fixing conflicts during the patch
re-ordering.

Best regards,
Javier Carrasco