Received-SPF: pass (google.com: domain of linux-kernel+bounces-85713-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <2f8c2032-d8ac-4be2-a409-9880c310aead@intel.com>
Date: Thu, 29 Feb 2024 10:19:11 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCHv8 17/17] ACPI: tables: Print MULTIPROC_WAKEUP when MADT is
 parsed
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Peter Zijlstra
	<peterz@infradead.org>, Adrian Hunter <adrian.hunter@intel.com>, "Kuppuswamy
 Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com>, "Elena
 Reshetova" <elena.reshetova@intel.com>, Jun Nakajima
	<jun.nakajima@intel.com>, Rick Edgecombe <rick.p.edgecombe@intel.com>, Tom
 Lendacky <thomas.lendacky@amd.com>, "Kalra, Ashish" <ashish.kalra@amd.com>,
	"Sean Christopherson" <seanjc@google.com>, Baoquan He <bhe@redhat.com>,
	<kexec@lists.infradead.org>, <linux-coco@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
References: <20240227212452.3228893-1-kirill.shutemov@linux.intel.com>
 <20240227212452.3228893-18-kirill.shutemov@linux.intel.com>
 <0a633c22-8426-42cf-9572-7812ffc75d0a@intel.com>
 <3jgmzzbjmwtf2rtrbiulhwjj5xwzc3icf4gxcmugyyq5n7pg5m@ua3poay4gmku>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <3jgmzzbjmwtf2rtrbiulhwjj5xwzc3icf4gxcmugyyq5n7pg5m@ua3poay4gmku>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVByV2RKbFlGbkFNL1dsei9oQ1ZEKy90bmpZR0xSSUVRZVJVUGNDOHlDVktB?=
 =?utf-8?B?ZHg1Rll4NVhnSFZjRUtZVHpidUtaOElDajZ3Q2Ezd2I5V2NnTC8yenk1N0tO?=
 =?utf-8?B?WGNqQ3JIRCt0RVc5R3I1NWFFUjAzS1JMaTRaVU53L2lGck5tQnk3MExJbzU3?=
 =?utf-8?B?UzRrNVh1TGRrai8vTitpZ1NBYVdnVURoeUs5enR2NzVoWmhHK3R1K25tQlNk?=
 =?utf-8?B?ajI3UE1aOXV1S3NTYWpWbjhBMGsxZG9hdFlBZW16MjJ4YjlEQU1SL3dSMlc4?=
 =?utf-8?B?WWx3Z0N0N3hDTHFtOGdFdUZ0a3NDWFFPdnowNWpFZjk2cGI3eVMwWnVWTUF5?=
 =?utf-8?B?bkZWdHhJNjh4eUZQQ2FHcy9RWStLcStldnBhM2w1djkweTNZanZ2a013cGhx?=
 =?utf-8?B?dXZKcmZ3VFA3bXhiK0YzeDY1VGJJa0pEQ1NTM1llbXVpV0hnOVdzSGJQT3BL?=
 =?utf-8?B?enhOTkhHQU5qVlM2UXhURnFUMkwzMUVObVRWUm9vamd0TWxmTlpFVzU4SnZn?=
 =?utf-8?B?Si9DdzE4QmFxcGpncWhaam91TjNlWXoxRm5oOTBXVHY0RUJIRmhWN05ieFhs?=
 =?utf-8?B?OVpndUU0cjBqS2I0WGFDdTN5M1d3QTM0S2Y4Y3h4aGZUN05DSUlNVTd6VVpW?=
 =?utf-8?B?T2YvTzE2Q09QSmxIdmNha1JldUtWQnRFSVVLMVQ4RkMxcndjY0Y1OXlIeWFM?=
 =?utf-8?B?TFloSHBYSDFoREZrdUpDaHlWQWpVMWVhSlV2ZUFJL283azFVYW9HNjB2THI4?=
 =?utf-8?B?YkUwTlpjNml0M28xaVplem9sbzRZeVdkNnE2eXphcm9QM1lpUnVsOGhCMmtP?=
 =?utf-8?B?cE1NS1NrRko0MkNNL1pOd0FsdTBrZ25FMnpMS0JzaFRRQ2RJUlY4em9VQXgx?=
 =?utf-8?B?RTFiTlFwbU5CT2xDOGtGbTE3c011UHlZcUxkUkNqL3hleVFia3Q0Sm14ZHYz?=
 =?utf-8?B?UURlUERmNTlZdGRwU2ZIY1R3Q3pEbkxKRGNjZUlXVWhnakl4TmUxcjgxSXpX?=
 =?utf-8?B?SjZ0aUs2ZG4wSmxKVXNkU056Z2lmeVhTWVIrekNHMk9yTmdRVzRlelhjV3lV?=
 =?utf-8?B?cmpaQmdJUndncitiV2lhWGxXTk10bWNrYUJiNU1FY0Q3eTc4WTBiNHp0NEZa?=
 =?utf-8?B?azZ3RFdkbVB2WU9BaGVQaFJDM0FFanYwRU00c1JZemdqNklJdnZkSnNNVGNa?=
 =?utf-8?B?dkJJTlBwR09aK0NnTVBZZmJaVzRVVUJVTzBsTld2akNLSWhJYVFWbVVWTmZr?=
 =?utf-8?B?RVo0RjRweDhwVXdoTW5abGNSR0RZRGdyVHhDZUxHd2puUnRoTmNrUi8wdzlV?=
 =?utf-8?B?QkhvY0ZScnVSSHdjS2dCR3N0ZCtmc1BEY1NybTAwZUpZVHdiV1NSQjJsRW5i?=
 =?utf-8?B?eExhbisxdnkwRExrQk9TVFYvdkxBT1JIZVIrcGQwYTIraHlIOHplSVR1RWhS?=
 =?utf-8?B?L2RHRk11U3R5MWRyT0QxQ3BVS0duZGlDcW5DU1ZHS1c0Q1o4eGJUWkZkbWhU?=
 =?utf-8?B?Y0tSZFQxOFI2cmRjbWRhS051SGR4QmNBd2Jra1MveVZVY3kvVjIwVXY1ZUVS?=
 =?utf-8?B?aS9ieGVaV2xUVE9NbXVGZk10ZjNWU3hJODE5NFQwOC9GZ3N5bjhzTkttdElp?=
 =?utf-8?B?L2UyTEY4R2UxMUVqdkEzNUprMjB6Z2NTdmxuc0ZicHNqSTVKeUw5WEhXcVFz?=
 =?utf-8?B?d3FpMlFyZEFZRzNTZHIwcVgwaGJwVTN6Tm9qMHpHNnpmUTJCSU5hc3Rhd3JT?=
 =?utf-8?B?MjZTOTFySjQ5T3dsdjVUYjY0OU9zOS92OWlyZnVhV1A0bXJ0NDZ4bEVSdFJU?=
 =?utf-8?B?Z3d6bjMxWkFOeTl0Zk44ZFJDWWtHSTl3OWxoTkRYeVdLb3RqRThSV0x4ek1H?=
 =?utf-8?B?NUJqTEFkTWhJR3NxOGwvN3ZIc1puSjEzRVFVK01sU0pnbkNFRzgxZ3FidmdS?=
 =?utf-8?B?bUN5VGwxZ2pSR2F0cUtEMXdET2JhQTZoSnp6Wkh3dmllOUpxdzltM0Y2Nmho?=
 =?utf-8?B?OTRzalE1NjR4MWJYeHgxUFpuRTd4MTR4OFFYUEhBOW4rK29BZFoyS1UxQ1ph?=
 =?utf-8?B?UWRhei9zMnk0ZW9lVlNNMS9nc0ViRzc5bTJEQUxYdGR0alI3ekhVVDRndDBB?=
 =?utf-8?Q?aybAdkEmLWyFeu2HU/bqHVns/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5614ea36-3207-403c-d761-08dc38a2eff3
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 21:19:24.3211
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZbZZMEitphRh2orjKemTRan7HDQOPSYZYg8QcnhOXsP/OD+TtBMx7GwRC2fZzzO7r34vYQSyc+q3/BwqkfWGpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7603
X-OriginatorOrg: intel.com


On 29/02/2024 4:22 am, Kirill A. Shutemov wrote:
> On Wed, Feb 28, 2024 at 11:08:38AM +1300, Huang, Kai wrote:
>>
>>
>> On 28/02/2024 10:24 am, Kirill A. Shutemov wrote:
>>> When MADT is parsed, print MULTIPROC_WAKEUP information:
>>>
>>> ACPI: MP Wakeup (version[1], mailbox[0x7fffd000], reset[0x7fffe068])
>>>
>>> This debug information will be very helpful during bring up.
>>>
>>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>>> Reviewed-by: Baoquan He <bhe@redhat.com>
>>> ---
>>>    drivers/acpi/tables.c | 14 ++++++++++++++
>>>    1 file changed, 14 insertions(+)
>>>
>>> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
>>> index b07f7d091d13..c59a3617bca7 100644
>>> --- a/drivers/acpi/tables.c
>>> +++ b/drivers/acpi/tables.c
>>> @@ -198,6 +198,20 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
>>>    		}
>>>    		break;
>>> +	case ACPI_MADT_TYPE_MULTIPROC_WAKEUP:
>>> +		{
>>> +			struct acpi_madt_multiproc_wakeup *p =
>>> +				(struct acpi_madt_multiproc_wakeup *)header;
>>> +			u64 reset_vector = 0;
>>> +
>>> +			if (p->version >= ACPI_MADT_MP_WAKEUP_VERSION_V1)
>>> +				reset_vector = p->reset_vector;
>>> +
>>> +			pr_debug("MP Wakeup (version[%d], mailbox[%#llx], reset[%#llx])\n",
>>> +				 p->version, p->mailbox_address, reset_vector);
>>> +		}
>>> +		break;
>>> +
>>
>> Hmm.. I hate to say, but maybe it is better to put this patch at some early
>> place in this series w/o mailbox version and reset_vector, and add
>> incremental changes where mailbox/reset_vector is introduced in this series.
>>
>> The advantage is in this way someone can just backport this patch to the old
>> kernel if they care -- this should be part of commit f39642d0dbacd
>> ("x86/acpi/x86/boot: Add multiprocessor wake-up support") anyway.
> 
> It is not subject for backporting. It is just a cosmetics fix (or debug
> facility). Any new MADT type would generate a warning. Nothing wrong with
> it.
> 

OK fine to me.  Thanks.