Received: by 2002:a05:7208:13ce:b0:7f:395a:35b6 with SMTP id r14csp99792rbe; Wed, 28 Feb 2024 13:33:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXQ+Vs+ciK4ilM+HgfhBWC/ROHTISY31/mcmAY5dX7MSbiMskYo+ToB+Lz9TDsJ9yg4j1Ag+MlvpmMN3ZkVGwQVReYoLjwSd1F/+7+e5A== X-Google-Smtp-Source: AGHT+IFGu3YMBvnP8vyx6HDOWJnN+yy+AjuPOq/nsRSgkbx1TMc6zcMko8YA4CwN2zVE8M8njEBi X-Received: by 2002:a17:906:7f18:b0:a3f:4fd7:3cf5 with SMTP id d24-20020a1709067f1800b00a3f4fd73cf5mr104111ejr.17.1709156011332; Wed, 28 Feb 2024 13:33:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709156011; cv=pass; d=google.com; s=arc-20160816; b=vYdoL3gWfcVv5BwRtcVLOa98li9Uc+PCSGzpSH7eRCZqc3DlRv/tm9umZ/25PW3UOO 6qO/A5SlGjxwc9iZxbc7Jx53//0RA2L6bpHOTEiYvwVExko9RIwhDWsdFs4k0IaJ1gcK +CZiu7F/S4tiDu6K7rtV9DmiAStJlR0s7Hn49JZ2blJaC8IBc/aGyWPXg9SS04GQQ+CE C5DhSVyNSEblHIXME9IVq33EB+oVOEefT39LS86zz8njLUmeNqkbyUWbAG1Yi8uf7Kfs +BW747EAQwkJHtYecL8B0A8l6+EjCg2p2GvVfAXwzKKUaZPBufmdbxplxwfuyL+q2O7i q+Tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XLd8h0kEPBZWXG99LoXPX1j7y1LhX/a2aDKq9S3uX68=; fh=31S6NP2P6uuHmbEKwUD3qA8Vziee8OOtdWGmTa1P0p8=; b=Q1EjXS3awGQz7ytlz3Cy+f7oBB32YrYQOwxs8K++HWy04kEUhMvUglCfALpuWVBayY cUBDr3Sm2DT6A5C8ZKUqWOuj/iIP8BQV8w++VV/ajZSWjKNgZ9UWV6I3MOcFIqLFy6pG 5oT6m2rGI0xii3lUAghzeMG+jlFt3Z1qBVsIZaba2x7/e+yW6E9nTO8YdxyFISDRWjgE q+oqcO1AFKWmLavO0NPdPhKM6pGhq4nsptJmTx02Urq5FJbUhOsNdlVS2PGNAg7oUOGe emoZ6Fk9do1TCDZnM+cnVEfp/xw8G+GhrcRT+BBZ5kMfyjyQDHd6DKpCYx71Km7CNRDr QV1Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aBN6sDQb; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-85725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85725-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id s7-20020a170906284700b00a42f6f4615asi2068813ejc.1044.2024.02.28.13.33.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 13:33:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aBN6sDQb; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-85725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85725-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 13D011F24605 for ; Wed, 28 Feb 2024 21:33:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA21170041; Wed, 28 Feb 2024 21:33:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aBN6sDQb" Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81B8E4D11F for ; Wed, 28 Feb 2024 21:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709155998; cv=none; b=ra/CRRoq6q7s2tUVumJ3b3C3JCi34ml7nI/qEGqaYMJg6ZQxff1jwK5oWUjbY30rCSi6QWnJoHbPwkBfmkAgXd7b1zW2il8wKgehTynXMXQ/46DeF9V3UHA/Y/v0PQr/49vFomYDI3GWOW68ARhSMxa3UZR4Gi47eC9r1cPB61c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709155998; c=relaxed/simple; bh=2QplW/PSL+l5wBlz2Fhb2MD7icGVtnf5yghrdyR7zlI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hzQgaPxtXpcEJYN/faCYIOGfrg7DCPHMtaGa6/mKhs2iJL5gh1X8GX5RVjwqR+EyiCgMYEYDfQ+7lN2qQ5okC3gGUOgWFvUd0Tq1ivQLIFRoUKUbuPBp8P9VAxCT1WYWH6aOHEt+M2izOcpV19agZeZsddb+z78y25ef/oyJ1aw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=aBN6sDQb; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d944e8f367so2158555ad.0 for ; Wed, 28 Feb 2024 13:33:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709155997; x=1709760797; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XLd8h0kEPBZWXG99LoXPX1j7y1LhX/a2aDKq9S3uX68=; b=aBN6sDQbxrowODDrLK+SjX+fBVboj16jTtc0JmnAsYlX+IxsJR//Q78Ef229q7BVeH k1loVZK1lowplOUnadJZy6JVfXerQXD8WmyZTW9TvRQjvfhk9aXLvNV/TdU3BT+CZ6AJ AA8I7rfTB85C3iJawTE0geey0WYKINkco6uXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709155997; x=1709760797; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XLd8h0kEPBZWXG99LoXPX1j7y1LhX/a2aDKq9S3uX68=; b=JWYA2mtCQdSspT0zvjTLFj3jONagiHaaTObqxruw9gXfLUyeu8xaPLsft4pvXN1p/f bamyH4LydwkP20uE5mWpL9Y/Rlq860kC/V63RAwH2zwalaSRrIQjf+223cfhRV8413ny WBIlBAumUst06bKhb1M8p/ahPpGWxCeY2+fEIIVWkzgLcPgJqRlbwsHZ2nnG88xCF/Na jzDg4avVseRJyFWOR91JrahNy4hw1DddSTaLRey4Mj3ouAR3kRbnDPvOT2G8OfTJZnOc Jr8rQ6CI/oJcsKUIHjVFmdJ6YLfWw0zmale6S1itx9+W7J06Oo0XL1iSirTROlf3Q8y9 Ljlw== X-Forwarded-Encrypted: i=1; AJvYcCUkwoMdE8ZFEHkcYHS162B36f3Qqzx6nWCRoow7WeTI1rrBoDH4cO/E2I5xrlUns2G39s/GF+xUYS399TiK3VInupb2+qT5DBDVDGPB X-Gm-Message-State: AOJu0YzWMHiUraNX1TQLi6Rax47WWtfKRbAveEYYth3bQnSnYXTHhFgt V0ElqQRXEZYkG28Y46Flu+49YXcgS/8Ldq3dY4HvCZIrPD2Ogk2wntQkz1039Q== X-Received: by 2002:a17:902:ce02:b0:1d9:f83e:3a54 with SMTP id k2-20020a170902ce0200b001d9f83e3a54mr192671plg.64.1709155996838; Wed, 28 Feb 2024 13:33:16 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id c2-20020a170902848200b001dca997b3e3sm3729404plo.65.2024.02.28.13.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 13:33:15 -0800 (PST) Date: Wed, 28 Feb 2024 13:33:15 -0800 From: Kees Cook To: Andy Shevchenko Cc: Vinod Koul , Linus Walleij , Jonathan Cameron , Mark Brown , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Gustavo A. R. Silva" Subject: Re: [PATCH v4 1/8] overflow: Use POD in check_shl_overflow() Message-ID: <202402281332.9B2F13570@keescook> References: <20240228204919.3680786-1-andriy.shevchenko@linux.intel.com> <20240228204919.3680786-2-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240228204919.3680786-2-andriy.shevchenko@linux.intel.com> On Wed, Feb 28, 2024 at 10:41:31PM +0200, Andy Shevchenko wrote: > The check_shl_overflow() uses u64 type that is defined in types.h. > Instead of including that header, just switch to use POD type > directly. > > Signed-off-by: Andy Shevchenko Acked-by: Kees Cook -- Kees Cook